STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clean up errors

Browse source
This commit is contained in:
JP Ungaretti 2022-04-14 16:12:44 -05:00
parent eaf8f84baf
commit e8e9b58670
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pkg/cmd/codespace/jupyter.go
View file

@ -47,7 +47,7 @@ func (a *App) Jupyter(ctx context.Context, codespaceName string) error {
serverPort, serverUrl, err := session.StartJupyterServer(ctx)
a.StopProgressIndicator()
if err != nil {
return fmt.Errorf("error getting jupyter server details: %w", err)
return err
}
// Pass 0 to pick a random port

4
pkg/liveshare/session.go
View file

@ -77,12 +77,12 @@ func (s *Session) StartJupyterServer(ctx context.Context) (int, string, error) {
}
if !response.Result {
return 0, "", fmt.Errorf("failed to start jupyter server: %s", response.Message)
return 0, "", fmt.Errorf("failed to start JupyterLab: %s", response.Message)
}
port, err := strconv.Atoi(response.Port)
if err != nil {
return 0, "", fmt.Errorf("failed to parse port: %w", err)
return 0, "", err
}
return port, response.ServerUrl, nil