STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #81 from github/pr-status-single-check

Browse source 
`pr status`: avoid printing a lonely "1" when there is only one Check
This commit is contained in:
Mislav Marohnić 2019-11-21 15:27:53 +01:00 • committed by GitHub
commit eabcae84c7
1 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

17
command/pr.go
View file

@ -342,18 +342,19 @@ func printPrs(prs ...api.PullRequest) {
}
if checks.Total > 0 {
var ratio string
var summary string
if checks.Failing > 0 {
ratio = fmt.Sprintf("%d/%d", checks.Passing, checks.Total)
ratio = utils.Red(ratio)
if checks.Failing == checks.Total {
summary = utils.Red("All checks failing")
} else {
summary = utils.Red(fmt.Sprintf("%d/%d checks failing", checks.Failing, checks.Total))
}
} else if checks.Pending > 0 {
ratio = fmt.Sprintf("%d/%d", checks.Passing, checks.Total)
ratio = utils.Yellow(ratio)
summary = utils.Yellow("Checks pending")
} else if checks.Passing == checks.Total {
ratio = fmt.Sprintf("%d", checks.Total)
ratio = utils.Green(ratio)
summary = utils.Green("Checks passing")
}
fmt.Printf(" - checks: %s", ratio)
fmt.Printf(" - %s", summary)
}
if reviews.ChangesRequested {