STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Only fetch DefaultBranchRef when adding upstream remote during gh repo clone

Browse source
This commit is contained in:
cdce8p 2020-12-09 20:10:59 +01:00
parent f4152454f2
commit f536901bc1
5 changed files with 56 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pkg/cmd/repo/clone/clone.go
View file

@ -144,7 +144,7 @@ func cloneRun(opts *CloneOptions) error {
}
upstreamURL := ghrepo.FormatRemoteURL(canonicalRepo.Parent, protocol)
err = git.AddUpstreamRemote(upstreamURL, cloneDir)
err = git.AddUpstreamRemote(upstreamURL, cloneDir, []string{canonicalRepo.Parent.DefaultBranchRef.Name})
if err != nil {
return err
}

5
pkg/cmd/repo/clone/clone_test.go
View file

@ -218,6 +218,9 @@ func Test_RepoClone_hasParent(t *testing.T) {
"name": "ORIG",
"owner": {
"login": "hubot"
},
"defaultBranchRef": {
"name": "master"
}
}
} } }
@ -237,7 +240,7 @@ func Test_RepoClone_hasParent(t *testing.T) {
}
assert.Equal(t, 2, cs.Count)
assert.Equal(t, "git -C REPO remote add -f upstream https://github.com/hubot/ORIG.git", strings.Join(cs.Calls[1].Args, " "))
assert.Equal(t, "git -C REPO remote add -t master -f upstream https://github.com/hubot/ORIG.git", strings.Join(cs.Calls[1].Args, " "))
}
func Test_RepoClone_withoutUsername(t *testing.T) {

2
pkg/cmd/repo/fork/fork.go
View file

@ -273,7 +273,7 @@ func forkRun(opts *ForkOptions) error {
}
upstreamURL := ghrepo.FormatRemoteURL(repoToFork, protocol)
err = git.AddUpstreamRemote(upstreamURL, cloneDir)
err = git.AddUpstreamRemote(upstreamURL, cloneDir, []string{})
if err != nil {
return err
}