From f6a09a3e5cf45872835f3c24543bd2f3b658b705 Mon Sep 17 00:00:00 2001 From: Kynan Ware <47394200+BagToad@users.noreply.github.com> Date: Thu, 22 Jan 2026 14:23:51 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Babak K. Shandiz --- api/queries_pr.go | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/api/queries_pr.go b/api/queries_pr.go index d994d3aae..962999f09 100644 --- a/api/queries_pr.go +++ b/api/queries_pr.go @@ -715,16 +715,15 @@ func SuggestedAssignableActors(client *Client, repo ghrepo.Interface, assignable Issue struct { SuggestedActors struct { Nodes []struct { + TypeName string `graphql:"__typename"` User struct { ID string Login string Name string - TypeName string `graphql:"__typename"` } `graphql:"... on User"` Bot struct { ID string Login string - TypeName string `graphql:"__typename"` } `graphql:"... on Bot"` } } `graphql:"suggestedActors(first: 10, query: $query)"` @@ -732,16 +731,15 @@ func SuggestedAssignableActors(client *Client, repo ghrepo.Interface, assignable PullRequest struct { SuggestedActors struct { Nodes []struct { + TypeName string `graphql:"__typename"` User struct { ID string Login string - Name string - TypeName string `graphql:"__typename"` + Name string } `graphql:"... on User"` Bot struct { ID string Login string - TypeName string `graphql:"__typename"` } `graphql:"... on Bot"` } } `graphql:"suggestedActors(first: 10, query: $query)"` @@ -764,16 +762,15 @@ func SuggestedAssignableActors(client *Client, repo ghrepo.Interface, assignable } var nodes []struct { + TypeName string `graphql:"__typename"` User struct { ID string Login string Name string - TypeName string `graphql:"__typename"` } `graphql:"... on User"` Bot struct { ID string Login string - TypeName string `graphql:"__typename"` } `graphql:"... on Bot"` } @@ -789,12 +786,12 @@ func SuggestedAssignableActors(client *Client, repo ghrepo.Interface, assignable viewerIncluded := false for _, n := range nodes { - if n.User.TypeName == "User" && n.User.Login != "" { + if n.TypeName == "User" && n.User.Login != "" { actors = append(actors, AssignableUser{id: n.User.ID, login: n.User.Login, name: n.User.Name}) if query == "" && viewerLogin != "" && n.User.Login == viewerLogin { viewerIncluded = true } - } else if n.Bot.TypeName == "Bot" && n.Bot.Login != "" { + } else if n.TypeName == "Bot" && n.Bot.Login != "" { actors = append(actors, AssignableBot{id: n.Bot.ID, login: n.Bot.Login}) if query == "" && viewerLogin != "" && n.Bot.Login == viewerLogin { viewerIncluded = true