From 054b306d099d454b61e8788cf3da8889e454a031 Mon Sep 17 00:00:00 2001
From: William Martin <williammartin@github.com>
Date: Wed, 24 Apr 2024 15:50:29 +0200
Subject: [PATCH] Make error more obvious when bundle has wrong extension

---
 pkg/cmd/attestation/verification/attestation.go      | 4 ++--
 pkg/cmd/attestation/verification/attestation_test.go | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/pkg/cmd/attestation/verification/attestation.go b/pkg/cmd/attestation/verification/attestation.go
index b131b7acd..0b6499ece 100644
--- a/pkg/cmd/attestation/verification/attestation.go
+++ b/pkg/cmd/attestation/verification/attestation.go
@@ -13,7 +13,7 @@ import (
 	"github.com/sigstore/sigstore-go/pkg/bundle"
 )
 
-var ErrLocalAttestations = errors.New("failed to load local attestations")
+var ErrUnrecognisedBundleExtension = errors.New("bundle file extension not supported, must be json or jsonl")
 
 type FetchAttestationsConfig struct {
 	APIClient  api.Client
@@ -52,7 +52,7 @@ func GetLocalAttestations(path string) ([]*api.Attestation, error) {
 		}
 		return attestations, nil
 	}
-	return nil, ErrLocalAttestations
+	return nil, ErrUnrecognisedBundleExtension
 }
 
 func loadBundleFromJSONFile(path string) ([]*api.Attestation, error) {
diff --git a/pkg/cmd/attestation/verification/attestation_test.go b/pkg/cmd/attestation/verification/attestation_test.go
index ef7c7d879..1b3ed2cef 100644
--- a/pkg/cmd/attestation/verification/attestation_test.go
+++ b/pkg/cmd/attestation/verification/attestation_test.go
@@ -48,7 +48,7 @@ func TestGetLocalAttestations(t *testing.T) {
 		path := "../test/data/sigstore-js-2.1.0-bundles.tgz"
 		attestations, err := GetLocalAttestations(path)
 
-		require.ErrorIs(t, err, ErrLocalAttestations)
+		require.ErrorIs(t, err, ErrUnrecognisedBundleExtension)
 		require.Nil(t, attestations)
 	})
 }