From fda9659e4a515cb3df200bd6412e75bc599d141a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mislav=20Marohni=C4=87?= Date: Wed, 9 Sep 2020 17:02:02 +0200 Subject: [PATCH] Consistently print browsed URL across commands --- pkg/cmd/issue/view/view.go | 4 +++- pkg/cmd/pr/view/view.go | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/issue/view/view.go b/pkg/cmd/issue/view/view.go index 6d2b0eeaa..aeec309a0 100644 --- a/pkg/cmd/issue/view/view.go +++ b/pkg/cmd/issue/view/view.go @@ -83,7 +83,9 @@ func viewRun(opts *ViewOptions) error { openURL := issue.URL if opts.WebMode { - fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", openURL) + if opts.IO.IsStdoutTTY() { + fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", utils.DisplayURL(openURL)) + } return utils.OpenInBrowser(openURL) } if opts.IO.IsStdoutTTY() { diff --git a/pkg/cmd/pr/view/view.go b/pkg/cmd/pr/view/view.go index b653e5ffe..c42048043 100644 --- a/pkg/cmd/pr/view/view.go +++ b/pkg/cmd/pr/view/view.go @@ -94,7 +94,7 @@ func viewRun(opts *ViewOptions) error { if opts.BrowserMode { if connectedToTerminal { - fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", openURL) + fmt.Fprintf(opts.IO.ErrOut, "Opening %s in your browser.\n", utils.DisplayURL(openURL)) } return utils.OpenInBrowser(openURL) }