From 19788459cdda138f2aa6c45e1f1498d96866b0fa Mon Sep 17 00:00:00 2001 From: Naoya Yasuda <43776161+yanskun@users.noreply.github.com> Date: Sat, 25 Feb 2023 23:22:39 +0900 Subject: [PATCH] feat: add open num hash to browse command --- pkg/cmd/browse/browse.go | 2 +- pkg/cmd/browse/browse_test.go | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go index 524f9f20e..619c7f0aa 100644 --- a/pkg/cmd/browse/browse.go +++ b/pkg/cmd/browse/browse.go @@ -174,7 +174,7 @@ func parseSection(baseRepo ghrepo.Interface, opts *BrowseOptions) (string, error } } - if isNumber(opts.SelectorArg) { + if !opts.CommitFlag && isNumber(opts.SelectorArg) { return fmt.Sprintf("issues/%s", strings.TrimPrefix(opts.SelectorArg, "#")), nil } diff --git a/pkg/cmd/browse/browse_test.go b/pkg/cmd/browse/browse_test.go index 3a283f8f4..57b6ad99b 100644 --- a/pkg/cmd/browse/browse_test.go +++ b/pkg/cmd/browse/browse_test.go @@ -123,6 +123,15 @@ func TestNewCmdBrowse(t *testing.T) { }, wantsErr: false, }, + { + name: "commit hash flag", + cli: "-c 123", + wants: BrowseOptions{ + CommitFlag: true, + SelectorArg: "123", + }, + wantsErr: false, + }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { @@ -395,6 +404,17 @@ func Test_runBrowse(t *testing.T) { wantsErr: false, expectedURL: "https://github.com/vilmibm/gh-user-status/tree/6f1a2405cace1633d89a79c74c65f22fe78f9659/main.go", }, + { + name: "open number only commit hash", + opts: BrowseOptions{ + CommitFlag: true, + SelectorArg: "1234567890", + GitClient: &testGitClient{}, + }, + baseRepo: ghrepo.New("yanskun", "ILoveGitHub"), + wantsErr: false, + expectedURL: "https://github.com/yanskun/ILoveGitHub/commit/1234567890", + }, { name: "relative path from browse_test.go", opts: BrowseOptions{