Commit graph

25 commits

Author SHA1 Message Date
David van der Spek
9cdc0c4fe5 fix(cache delete): add unit tests and expand help doc
Signed-off-by: David van der Spek <david.vanderspek@flyrlabs.com>
2026-01-20 08:30:34 +01:00
David van der Spek
6a798e76e1 feat(cache delete): allow for delete all caches for a ref
Signed-off-by: David van der Spek <david.vanderspek@flyrlabs.com>
2026-01-20 08:30:34 +01:00
Babak K. Shandiz
ab9c99ec04
docs(cache delete): remove redundant comment
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-02 11:36:00 +01:00
Babak K. Shandiz
d574873f3b
docs(cache delete): add godoc for deleteCacheByKey
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-02 11:33:26 +01:00
Lucas
ccfc2c3045
fix(cache): report correct deleted count for key and key+ref deletions
Previously, deleting caches by key or key+ref could misreport the number of deleted entries, especially when multiple caches matched the criteria. This change ensures the actual number of deleted caches is reported by consuming the API response's total_count field.
2025-10-01 18:44:24 +02:00
Babak K. Shandiz
02d50700b5
docs(cache delete): explain different API responses
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-28 11:05:28 +01:00
Babak K. Shandiz
2dd54ae921
refactor(cache delete): simplify error handling
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-28 10:08:04 +01:00
Babak K. Shandiz
842d3449b4
refactor(cache delete): simplify condition
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-28 10:02:03 +01:00
Lucas
926327ce6d
fix(cache): validate --ref flag usage with cache ID
* Ensure that the `--ref` flag cannot be used in conjunction with a cache ID.
* Update error handling to provide clear feedback when this condition is violated.
* Add tests to cover scenarios involving the `--ref` flag and cache ID.
2025-08-27 19:54:19 +02:00
Lucas
1a19918581
fix(cache): prevent using --ref flag with cache ID
* Added validation to ensure that the `--ref` flag cannot be used when a cache ID is provided.
* Updated error message to include the reference when a cache is not found with the specified `--ref`.
2025-08-27 19:38:01 +02:00
Lucas
5c292286cf
refactor(cache): extract cache ID parsing logic
* Replaced direct conversion of cache ID string to int with a dedicated `parseCacheID` function.
* Improved readability and maintainability of the `deleteCaches` function.
2025-08-27 19:37:39 +02:00
Lucas
047326fcb4
fix(cache): update error message for missing cache key with --ref flag
* Changed the error message from "--ref cannot be used without cache key/ID" to "must provide a cache key" for clarity.
* Updated corresponding test case to reflect the new error message.
2025-08-27 04:56:48 +02:00
Lucas
3ba82b58a9
chore(cache): improve help text for --ref flag in cache deletion
* Clarified the description of the `--ref` flag to specify its purpose more accurately.
* Ensures users understand that it narrows down deletion by cache key and ref.
2025-08-27 04:56:48 +02:00
Lucas
aff2bfaa5c
feat(cache): add support for --ref flag in cache deletion
- Introduced `--ref` flag to narrow down cache deletion to a specific branch or PR reference.
- Updated command examples to include usage of `--ref`.
- Added validation to ensure `--ref` cannot be used with `--all` and must accompany a cache key/ID.
2025-08-27 04:56:46 +02:00
Azeem Sajid
76efb5ac81 Fix non-TTY case 2025-02-19 10:22:31 +05:00
Azeem Sajid
17e7b57b3b Use API without shorthand flag 2025-02-07 18:03:35 +05:00
Azeem Sajid
9e13890c77 Remove short (abbreviated) flag support 2025-02-06 11:56:08 +05:00
Azeem Sajid
d6be4981be Address PR review comments 2025-01-31 12:28:00 +05:00
Azeem Sajid
82ee9a2c75 [gh cache delete --all] Add --succeed-on-no-caches flag to return exit code 0 2025-01-29 14:53:09 +05:00
Kynan Ware
74f13a9b4f
Apply suggestions from code review
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-11-21 13:55:35 -07:00
bagtoad
677ed2cdcf Refactor command documentation to use heredoc 2024-11-21 13:23:03 -07:00
Viktor Szépe
6d9dd57774 Fix typos 2024-05-09 20:15:27 +00:00
Benoit Pierre
564d07ce00 cache/delete: percent-encode keys 2023-09-21 16:32:53 +02:00
Josh Kraft
1dc54f85fb typo 2023-05-03 11:08:32 -06:00
Josh Kraft
213a59b8bd create cache commands 2023-05-03 11:03:50 -06:00