William Martin
24964681a8
Respect --exit-status with --log and --log-failed
...
Fixes #12674
2026-02-13 16:04:06 +01:00
Babak K. Shandiz
f67bd9a7d1
test(run view): assert a skipped job does not cause error
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-16 14:19:57 +01:00
Babak K. Shandiz
555b8f1bf9
test(run view): update tests
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-04 14:12:07 +01:00
Babak K. Shandiz
2d21b4624c
Test normal job run log is preferred over legacy one
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 12:40:26 +01:00
Babak K. Shandiz
f673b409f7
Replace UNKNOWN with UNKNOWN STEP in job run log
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-11 09:57:13 +01:00
Babak K. Shandiz
021537418e
Verify fallback to job run logs when step logs are missing
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:30 +01:00
Babak K. Shandiz
02e8419124
Verify job run logs attached in attachRunLog test
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:29 +01:00
Uday R
8afb434e59
test(gh run): assert branch names are enclosed in square brackets
2024-12-09 12:45:36 -05:00
Andy Feller
19daa35c81
Merge pull request #9482 from benebsiny/cli-9153
...
fix the trimming of log filenames for `gh run view`
2024-08-22 15:23:06 -04:00
benebsiny
64415df08d
fix the trimming of log filenames for gh run view
2024-08-18 16:57:19 +08:00
Heath Stewart
81f3526740
Fix tests
2024-08-16 10:11:52 -07:00
Wing
f647131e1d
Gracefully degrade when fetching annotations fails due to 403 ( #9113 )
...
Co-authored-by: William Martin <williammartin@github.com>
2024-06-13 14:33:06 +02:00
William Martin
1d38230675
Move config interfaces into gh package ( #9060 )
2024-05-10 10:39:36 +02:00
William Martin
61a698a55a
Add support for jobs with long filenames
...
Co-authored-by: John Basila <john@orca.security>
Co-authored-by: Shay Nehmad <shay.nehmad@orca.security>
2024-05-06 11:32:41 +02:00
William Martin
61584b83cb
Close zip file in run view tests
2024-04-08 16:50:43 +02:00
William Martin
bbeccd69ad
Ensure run log cache creates cache dir if it doesn't exist
2024-04-08 15:51:29 +02:00
William Martin
b6239238c8
Merge pull request #8931 from cli/wm/run-log-cache-stronger-abstraction
...
Create stronger run log cache abstraction
2024-04-05 16:00:28 +02:00
William Martin
103586a94c
Remove RunLogCache interface
2024-04-05 15:33:49 +02:00
William Martin
a3ffc1ca33
Use real Run Log Cache in run view tests
2024-04-05 15:18:18 +02:00
William Martin
e644dc50d6
Capture error on Run Log Cache Exists
2024-04-05 15:16:12 +02:00
William Martin
a89d50fc63
Rework Run Log Cache so that cache dir is injected
2024-04-05 14:59:24 +02:00
Rachel Evans
628ade89a7
Anchor the log filename to the start
2024-03-28 13:08:42 +01:00
Andy Feller
3bb5f54073
Apply first round of owner/repo#number consistency
...
This commit expands on @nobe4 initial work by bringing the owner and repository name to the most obvious issue and PR number output use cases before making a second pass for any edge cases.
2024-03-01 14:03:18 -05:00
benebsiny
0b73f2af86
Verify the downloaded zip for gh run view --log
2023-12-14 01:54:16 +08:00
William Martin
8364301017
Simplify run view annotation fetch error handling
2023-11-06 12:40:13 +01:00
Arun Sathiya
9d04ee6c8d
update(run): Use attempt input when fetching jobs ( #7831 )
...
* Introduce attempt flag for run watch and use attempt input when fetching jobs
* Handle attempt input for 'run watch' commands instead of using the latest attempt
* Revert attempt flag implementation for 'run watch' command because it is intended only for the latest attempt
* Fix tests for cases when attempt flag is used on 'run view' command
---------
Co-authored-by: Andy Feller <andyfeller@github.com>
2023-10-03 14:36:47 +02:00
Harvey Sanders
137da73642
Simplify mock jobs response
2023-09-03 20:32:41 -04:00
Harvey Sanders
acc362f9d8
Fix pagination resp with "Link" header
2023-09-03 19:55:27 -04:00
Harvey Sanders
44e1efc221
Fetch all jobs on a gh view run --json
2023-08-21 10:29:58 -04:00
William Martin
2d3047c7e3
Support viewing logs for jobs with composite actions
2023-06-02 13:40:53 +02:00
nate smith
9010a2e12c
use new prompter in run view
2023-04-10 16:21:47 -07:00
Wing-Kam Wong
0fa168b80b
feat: add tests for attempt flag
2023-03-26 19:12:40 +08:00
Isaac Shalom
f1be4dc51c
Fix looking up workflow name for workflow runs ( #6266 )
...
The API field `WorkflowRun.name` is not guaranteed to correspond to the workflow name anymore. This introduces additional API lookups that resolve Workflows by their ID and look up their name in a future-proof fashion.
It also adds two new JSON fields for export: `displayTitle` and `workflowName`.
Co-authored-by: Christina Guo <61271066+guo-chris@users.noreply.github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-09-21 20:41:19 +02:00
Sam Coe
6a8deb1f5a
Integrate latest go-gh packages ( #6084 )
2022-08-18 09:04:13 +03:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os ( #5498 )
2022-04-26 13:07:44 +02:00
yasudanaoya
b77c37df0f
feat: add job id, into run view suggest command ( #5105 )
...
* feat: add job id, into run view suggest command
* fix: dry
* fix: run id to job id
* Change "a" to "the" when referencing a single job
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2022-01-27 08:19:37 +00:00
Mislav Marohnić
44775f87c8
Add nolint directives to allow-list current lint violations
2022-01-14 19:52:52 +01:00
Mislav Marohnić
11fbb60ae7
Rename the module to "github.com/cli/cli/v2"
2021-08-25 12:41:30 +02:00
Param Patidar
20f915d5ba
escape metacharacters in job name
2021-06-02 17:20:31 +00:00
Sam
aea6163a83
Merge pull request #3445 from adamslc/log_fix
...
Fix `run view --log` when steps have slashes
2021-04-20 08:13:26 -07:00
Sam Coe
75227f44d1
linter
2021-04-20 08:05:19 -07:00
Sam Coe
c77c7ec7c9
Match logs based on job name and step number
2021-04-19 12:21:34 -07:00
Mislav Marohnić
ac348b0dec
Fix requesting REST sub-resources on GHE
...
GitHub REST resources typically return full URLs to fetch related
resources at. We used to parse those URLs to find just the path portion
and pass that in to the `REST()` function, which only accepted paths. By
doing so, we are essential de-constructing a URL just to re-assemble it
again. While re-assembling it for Enterprise, though, we would
accidentally inject an extra `api/v3/` prefix where one was not needed.
The solution is just to use raw URLs as reported by the REST API with
no modifications. This extends the `REST()` function to accept full URLs
in addition to just paths to resources.
2021-04-19 12:41:09 +02:00
vilmibm
efe7aa1f78
fix small bug with startup_failure conclusion
2021-04-13 22:03:59 -05:00
Sam Coe
8a4a8dd451
Moar memory
2021-04-09 12:13:01 -07:00
Sam Coe
dc63480cf6
Add flag log-failed to display only logs of failed steps
2021-04-08 15:51:08 -07:00
Nate Smith
ed0ef6ad14
Merge branch 'trunk' into display-all-the-logs
2021-04-07 20:12:47 -05:00
Mislav Marohnić
026dc4657a
Merge remote-tracking branch 'origin' into artifact-download
2021-04-07 20:26:31 +02:00
Mislav Marohnić
a449a1a6f7
Add tests for artifact rendering in run view
2021-04-07 20:26:12 +02:00
Sam Coe
5cb4ece754
Renaming and cleanup
2021-04-07 10:10:11 -07:00