Commit graph

55 commits

Author SHA1 Message Date
Kynan Ware
9de48154de Add missing TODO comments for featuredetection if-statements
Add greppable TODO identifiers above all if-statements that reference
featuredetection struct fields, as required by the featuredetection
linter. This ensures every feature detection branch is tagged for
future cleanup when GHES gains support.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-16 14:24:32 -07:00
Babak K. Shandiz
56cdc36013
refactor(pkg/search): rename KeywordsVerbatim to ImmutableKeywords
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 16:53:16 +00:00
Babak K. Shandiz
1533d8177c
refactor(pkg/search): rewrite returns in a more verbose way
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 16:26:27 +00:00
Babak K. Shandiz
76b2de8a18
test(pkg/search): assert verbatim keywords are respected
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 13:08:27 +00:00
Babak K. Shandiz
d8486ccf10
fix(pkg/search): add KeywordsVerbatim field to Query type
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-20 13:07:27 +00:00
Babak K. Shandiz
917e365c5c
docs(pkg/search): fix typo
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:28 +00:00
Babak K. Shandiz
dde7fce602
refactor(pkg/search): remove passing resp for pagination
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:24 +00:00
Babak K. Shandiz
ef69901f05
refactor(search): rename Query.String to StandardSearchString
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-08 16:04:47 +01:00
Babak K. Shandiz
efddea720f
test(search): improve test cases
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-08 15:45:20 +01:00
Babak K. Shandiz
87bd76c5aa
docs: add cleanup/future TODO marks for advanced issue search changes
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-01 13:55:49 +01:00
Babak K. Shandiz
04cce6b35e
docs(search): improve Searcher.URL method docs
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 15:36:31 +01:00
Babak K. Shandiz
8ab6e722e2
docs(search): improve docs for Query.String and Query.AdvancedIssueSearchString methods
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 15:34:27 +01:00
Babak K. Shandiz
f0a130dd4e
refactor(search): improve special qualifier grouping
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 15:19:42 +01:00
Babak K. Shandiz
89b39e2df0
test(search): test advanced search support
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 13:59:45 +01:00
Babak K. Shandiz
1b2e2a24b6
fix(search): use advanced issue search when available
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 13:58:59 +01:00
Babak K. Shandiz
3086b6fc8a
refactor(search): sort qualifiers in query
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 13:54:52 +01:00
Babak K. Shandiz
188098d592
test(search): provide feature detection dependency
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 12:25:43 +01:00
Babak K. Shandiz
257f143711
fix(search): add feature detection dependency
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 12:24:05 +01:00
Babak K. Shandiz
cb249e6cbb
test(search): explain why is: and in: qualifiers used in test case
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 02:02:25 +01:00
Babak K. Shandiz
bf242ae2f4
fix(search): sort qualifiers in advacned issue search syntax
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 02:00:27 +01:00
Babak K. Shandiz
392c286db3
test(search): add tests for AdvancedIssueSearchString method
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 01:49:00 +01:00
Babak K. Shandiz
fd38b14898
fix(search): add AdvancedIssueSearchString method
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-31 01:48:13 +01:00
Sam Coe
40b2c9f10c
Merge branch 'trunk' into fix-web-code-search-filename-extension-flags 2025-07-10 11:33:31 +02:00
Babak K. Shandiz
e7f8bc89df
test(search): verify URL returns quoted query
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-07 15:45:32 +01:00
Babak K. Shandiz
d395172899
test(search): test pagination with multi-word quoted queries
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-07 15:44:56 +01:00
Babak K. Shandiz
81a1ce601c
fix(search): fix mutating query state fields
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-07 15:42:19 +01:00
Sam Coe
545b420ff8
Transform extension and filename qualifiers into path qualifier 2025-07-03 07:43:35 +02:00
leudz
4a885899d6 Add comments for Total 2025-04-16 20:46:29 +02:00
Andy Feller
ba390db71f PR feedback
- update local variables to communicate what they are
- added docblock explaining search results populated
2025-04-16 14:22:29 -04:00
Andy Feller
becd936e7b Update searcher tests
This commit moves the remaining searcher tests from using JSON marshaled types to using JSON responses for consistency.  There appears to be a weird JSON marshaling error with search.Repository that does not map `Name` field in the process.

Additionally, the test scenarios around pulling multiple pages beneath the total results have been updated to demonstrate that the REST API returns full pages in both of these cases, which is below the total number of results.
2025-04-15 17:13:43 -04:00
Andy Feller
bdfd51ca7f Fix search tests around totals, initialization
This commit is focused on fixing the `searcher` tests for a few reasons:

1. Correcting the `.Total` logic in the previous commit caused changes to tests to fail
2. Tests involving results that exceed the max per page have been improved with new initialize helper, allowing testing table scenarios to be self contained
3. Tests that stub JSON response payloads have been standardized on maps rather than GitHub type primitives (Repository, Issue, Commit, Code, etc)
4. Tests had some minor formatting changes to make them easier to understand and maintain
2025-04-15 14:43:10 -04:00
Andy Feller
f928cb1e19 Fix remaining search logic totals 2025-04-15 08:36:45 -04:00
Andy Feller
15ff7ba465 Restore result.Total logic, fix formatting
This change restores the original logic of passing the search total count logic as is to the result.

Additionally, this undoes some of the contributor's formatting changes that increase the changed lines to review.
2025-04-15 08:00:47 -04:00
leudz
072534c388 Fix multi pages search for gh search 2025-04-10 07:57:43 +02:00
w1mvy
9dd5805f9c
Add json export flags to variable list command (#8516) 2024-01-17 10:09:09 -08:00
Mislav Marohnić
94a6312eaf
💅 json export 2023-06-09 17:36:19 +02:00
Josh Kraft
88887c8d55 incorporate code review feedback 2023-05-08 18:04:52 -06:00
Josh Kraft
b0396d9af2 adopt changes to User 2023-04-26 18:55:33 -06:00
Josh Kraft
b8f86f54ad Merge branch 'trunk' into gh-search-code 2023-04-26 18:48:24 -06:00
Josh Kraft
65720e498e implement code search
updates
2023-04-26 18:38:35 -06:00
Kousik Mitra
7ee35e43cc
Enable owner flag to take multiple values for searching 2023-04-12 10:37:09 +05:30
Sam Coe
7bd7153285
Fix multiword keyword quoting for search commands (#7170) 2023-03-16 09:19:26 +11:00
Kevin Lee
9a1056fc87
Add search commits command (#6817) 2023-01-17 19:35:09 +00:00
Mislav Marohnić
e4f5545e86
Go 1.19: fix comment formatting for moq-generated mocks 2022-12-12 16:58:25 +01:00
Matthew Gabeler-Lee
eadc8e8372
Add isDraft to search prs json options, matching pr view (#6704) 2022-12-09 07:57:27 +00:00
vilmibm
c91c2d43cd export is_bot in issue/pr search 2022-12-08 12:55:03 -08:00
Ariel Deitcher
331dc24f07
show pull request merged state on search (#6411) 2022-10-11 14:40:16 +02:00
Sam Coe
e14d14cef2
Add support for issue state reason (#6245) 2022-09-14 12:39:15 +04:00
Sam Coe
e7102f9d84
Migrate to go-gh text package (#6236) 2022-09-14 09:23:55 +04:00
Ride The Snake
21014fbeb4
Add repository name without owner to search output fields (#6160) 2022-09-01 06:24:27 +00:00