David Gardiner
2cb044caf5
Parse SSH args before creating the shell
2024-01-30 13:16:46 -08:00
David Gardiner
8c77e53c35
Send activity signals during non-interactive codespace SSH command
2024-01-29 19:20:51 -08:00
Jose Garcia
37d8e9e915
Support --server-port behavior with conn details
2023-07-02 20:55:56 -04:00
JP Ungaretti
ec9e50ff93
Always set PasswordAuthentication option
2022-07-19 16:55:14 -07:00
Jake Shorty
08bbf3bd30
Check paths safely for codespaces SSH and SCP commands
2022-03-31 15:59:20 +00:00
Caleb Brose
623e67f6b1
Update comments/usage and remove --
2022-03-23 16:09:07 +00:00
Caleb Brose
a03051f295
Refactoring and comments
2022-03-22 14:49:58 +00:00
Caleb Brose
f22320a478
Parse scp args
2022-03-22 01:57:37 +00:00
Jose Garcia
bbea5ac95e
codespace: progress indication, logging ( #4555 )
...
* Rework logging, showing progress, and printing from `codespace` commands
* Change rendering of the general progress indicator so that it's visible on both dark and light backgrounds
* The progress indicator now "spins" faster
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-21 18:04:04 +02:00
Alan Donovan
f683d6cb4c
Disable remote shell expansion unless -e
2021-10-19 10:11:31 -04:00
Alan Donovan
48ada6d5f2
Use correct destination string, not root@localhost
2021-10-18 13:59:41 -04:00
Alan Donovan
e31b2567b8
gh cs cp: copy files between local/remote file systems
2021-10-18 12:39:09 -04:00
Jose Garcia
5890d6ad66
Switch if block logic, assert err string
2021-09-17 15:04:55 -04:00
Jose Garcia
da58313358
Remove redudant type def
2021-09-17 14:03:31 -04:00
Jose Garcia
9f84015bd0
Avoid append
2021-09-17 14:00:16 -04:00
Jose Garcia
76037ee753
Update docs, simplify loop to append to command
2021-09-17 13:54:00 -04:00
Jose Garcia
54265afda0
PR Feedback
...
- use named returns
- handle command flags + test case
- simplify tests
2021-09-17 13:43:23 -04:00
Jose Garcia
60d066f0a6
PR Feedback
...
- return nil for slices
- handle `-L -l` case
- document `parseSSHArgs`
2021-09-17 11:51:37 -04:00
Jose Garcia
42e47a98d7
add docs, simplify map, error on invalid args
2021-09-16 15:22:47 -04:00
Jose Garcia
8a0f8b6d1c
parse ssh args and command
2021-09-16 10:32:27 -04:00
Jose Garcia
514448dde8
Merge branch 'main' of github.com:github/ghcs into jg/ssh-cmd-flags
2021-09-15 15:45:53 -04:00
Jose Garcia
10ad85486f
Merge pull request #154 from github/jg/fix-ctx-error
...
ghcs create/ssh: fix ctx cancellation errors & fix todo for X11 forwarding
2021-09-15 15:45:35 -04:00
Jose Garcia
c5bd8c4127
initial spike to accept args
2021-09-15 15:37:37 -04:00
Jose Garcia
26d3199082
add back codespaces.Shell
2021-09-15 15:18:54 -04:00
Jose Garcia
ecd0c70567
upgrade to go-liveshare 0.16.0
2021-09-15 15:15:28 -04:00
Jose Garcia
547c629220
fix ctx cancellation errors & fix todo for X11 forwarding
2021-09-15 10:38:19 -04:00
Alan Donovan
981b2545bc
sketch of changes for https://github.com/github/go-liveshare/pull/13
2021-09-02 17:08:17 -04:00
Alan Donovan
3485bacc97
fix StartSharing data race
2021-09-02 15:53:56 -04:00
Alan Donovan
8570f4111d
sketch after API changes in go-liveshare#11
2021-09-02 12:38:27 -04:00
Alan Donovan
37b2f5e979
Merge branch 'main' into runcommand
2021-08-31 17:18:52 -04:00
Alan Donovan
f1c3a22a0b
Merge branch 'main' into product-spelling
2021-08-31 16:24:41 -04:00
Alan Donovan
c0aae52289
move port choice, and PortForwarder.Start call, into clients
2021-08-31 13:58:46 -04:00
Alan Donovan
509e037a5e
address review comments
2021-08-31 12:02:29 -04:00
Alan Donovan
bbcf2dd321
spell product names (Codespaces, Live Share) correctly
2021-08-31 11:15:26 -04:00
Alan Donovan
40317e91f8
cleanup to ssh api
2021-08-30 17:46:04 -04:00
Edmundo Gonzalez
903b7be7de
Comments from pr.
2021-08-30 21:01:13 +00:00
Edmundo Gonzalez
954d46dce5
Changes from comments on pr.
2021-08-30 17:30:28 +00:00
Edmundo Gonzalez
13917a289d
Moved function to ssh.go file.
2021-08-30 04:52:27 +00:00
Edmundo Gonzalez
5db9e2d83e
PR changes.
2021-08-30 04:48:56 +00:00
Edmundo Gonzalez
b6094e0006
Changes to point to RPC service.
2021-08-26 21:50:20 +00:00
Mislav Marohnić
b47686163a
Fixes for log/output streams
2021-08-17 13:04:55 +02:00
Jose Garcia
58a055609d
logs cmd spike and refactor of ssh tunnel methods
2021-07-29 10:57:51 -04:00
