Commit graph

73 commits

Author SHA1 Message Date
Azeem Sajid
69fff52026
Inconsistent format of description of flags (starting with lowercase letter) (#10507) 2025-02-27 11:40:21 +01:00
David Gardiner
20273d1f17 Move create codespace permission opt out behind else to fix token permissions 2024-01-12 12:16:38 -08:00
Mateus Marquezini
7a32b8b5f3 some code improvements after code review 2023-11-27 17:17:24 -03:00
Mateus Marquezini
7af33d090a added a new error handling when the display name flag exceeds 48 characters #8356 2023-11-20 18:45:12 -03:00
David Gardiner
500f359592
Don't poll for addition codespace permissions if user chooses to create without them (#8267) 2023-10-30 13:22:38 -05:00
David Gardiner
a8f8728056 Poll permission acceptance endpoint on codespace creation 2023-10-12 16:55:13 -07:00
Josh Gross
c5f88bb551
Show full permissions URL in gh cs create (#7983)
* Show full permissions URL in `gh cs create`

* Validate that full permissions URL is displayed
2023-09-12 10:12:53 -07:00
John Keech
93e1511bae
Codespaces: Use the host name from the logged in server for commands (#7795)
* Use the host name from the logged in server for codespace commands

* Fix existing tests

* Add tests for server url configuration

* Rename defaultApiUrl to defaultAPIURL and comment cleanup

* Switch to t.Setenv in codespaces api tests

* Switch to t.Setenv in other tests

* Support custom server in web flows for list and create

* Rename GetServerURL() to ServerURL()
2023-08-08 09:32:06 -07:00
doaortu
83322104b7
feat: add web flag for codespace list & create subcommand (#7288)
* feat: add web flag to cs list subcommand

web flag only works with repo flag, because,
currently there only param for listing with repo_id

* feat: add web flag to cs crate subcommand

web flag used for creating codespace through web UI instead of terminal.
web flag cannot be used with display-name, idle-timeout,
or retention retention-period
because there's no option for that in the Web UI

* refactor: extract mutual excusive logic to PreRunE

- changed web flag mutual exclusive logic, using cmdutil
- extract that logic to PreRunE clause in createCmd
- move web flag up to make it close to PreRunE clause (for clarity)
- add new param to newCreateCmd fn to facilitate test logic
- apply new newCreateCmd fn to root.go

* fix: clarify flag desc and error message

- remove 'yet' from error messages that can cause misunderstanding
- clarify list web flag can only be used with repo flag

* fix: skip machine check when we use web flag ...
(..and no machine flag provided)

+ add test for this new case
+ adjust related test cases for this new change.

* refactor: move flag check logic to PreRunE

why: err on PreRunE or RunE will also print help if error happened

+ move web, repo, org, user mutual exclusive logic to PreRunE clause
+ move repo, org, user mutual exclusive logic to PreRunE
+ move limit check flag to PreRunE
+ modify newListCmd fn to facilitate test logic
+ apply new newListCmd to root.go
+ add test cases to check PreRunE clause
- remove mutual exclusive test cases from Test_AppList

* refactor: remove the opts equality checks

* fix: mutually exclusive misfires
because of wrong logic

+ refine test case too

* cleanup:removing useWeb check in fn getMachineName

because it's no longer needed

+ remove redundant test-case

* refactor: remove redundant ifs

* refactor: clarify test name

* re-clarify web flag desc in list.go

* refactor: break long lines, use more idiomatic err

* add test case for nonexistent/wrong machine
2023-04-13 10:37:16 -05:00
JP Ungaretti
a388358348 Merge branch 'trunk' into jungaretti/fix-jupyter-spinner 2023-02-09 23:18:22 +00:00
JP Ungaretti
d815d54bd2 Adopt in create.go 2023-02-09 22:24:09 +00:00
Robin Neatherway
78fb90956c
Teach gh cs create to use current repo as default (#6596)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2023-02-07 20:05:38 +00:00
Ryan Caldwell
71ec2c4e23
Codespaces create: Fix missing billable owner notice for individuals (#6891) 2023-01-23 13:15:44 +01:00
Des Preston
4ade907ae8
Allow setting codespace display name during create (#6739)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-12-19 17:10:34 +01:00
Caleb Brose
57c53e6268 linter 2022-12-12 21:21:23 +00:00
Caleb Brose
8e0b4ef21b Use -R for --repo shorthand and deprecate -r 2022-12-12 19:44:59 +00:00
Ashwin Jeyaseelan
a756ffb1e8
Fix Codespace Creation Devcontainer bug (#6389) 2022-10-18 11:11:28 +03:00
Sam Coe
a30de8d72a
Output paid message for codespace create to stderr not stdout (#6258) 2022-09-14 11:33:55 +00:00
Sam Coe
e7102f9d84
Migrate to go-gh text package (#6236) 2022-09-14 09:23:55 +04:00
Ayesha Gagguturi
a80a63f3aa Delete blob + pool 2022-07-27 17:03:54 -07:00
Jake Shorty
5893c9864d
Merge pull request #5828 from cli/jshorty/indent-billable-owner-notice
Indent org billable owner notice for new codespaces
2022-06-21 09:32:27 -06:00
Jake Shorty
c48e6ee4c9 Indent org billable owner notice for new codespaces 2022-06-20 21:36:01 +00:00
Gabe D
95b7533a5f Uncomment retention period flag from create cmd 2022-06-20 18:40:56 +00:00
Jake Shorty
df3b40999e Flip conditional 2022-06-20 17:13:42 +00:00
Jake Shorty
832f35e000 PreFlight => BillableOwner for less confusion 2022-06-20 17:12:07 +00:00
Jake Shorty
e8bde879b2 Always show org billable owner in stdout 2022-06-17 22:44:43 +00:00
Jake Shorty
b3d2cc6e37 Handle 404s smoothly during create on codespaces pre-flight 2022-06-17 21:09:38 +00:00
Jake Shorty
7e4ec074f5 Use expanded copy for org billable owner 2022-06-17 18:42:31 +00:00
Jake Shorty
cad9a050be Get basics working with codespaces pre-flight during creation 2022-06-16 15:42:29 +00:00
Fengyi Li
04ed77ddf0
Update prebuild availability status display at codespace creation (#5737) 2022-06-02 17:20:12 +00:00
Greggory Rothmeier
77507cd94c
Bugfix: Retention period is being sent to the API as 0 (#5706)
Co-authored-by: Jose Garcia <josebalius@github.com>
2022-05-25 17:36:27 +02:00
Greggory Rothmeier
a0a9099037
Hide retention-period flag (#5607)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-05-10 19:49:55 +02:00
Greggory Rothmeier
06153770a9
Merge pull request #5504 from greggroth/gregg/retention-period
Add support for setting codespace retention-period
2022-05-10 18:21:55 +02:00
Jeff Hubbard
2b57084bd0 PR feedback 2022-04-20 11:52:32 -07:00
Jeff Hubbard
9fb6cf5423 Fix tests 2022-04-12 10:26:08 -07:00
Jeff Hubbard
de9b5ad8f8
Merge branch 'trunk' into multi-devcontainer 2022-04-08 15:17:33 -07:00
Jake Shorty
6783509d3b
Merge pull request #5410 from cli/codespaces-location-optional
Make location an optional flag when creating codespaces
2022-04-07 10:58:39 -06:00
Jake Shorty
e9ed200c1b
Use proper syntax for location values
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-07 10:49:03 -06:00
Jake Shorty
be7a4ed70b Enumerate available codespace locations for now
We'll probably want to have an intermediate geographical abstraction for these eventually, but this gives parity with the github.com UI.
2022-04-06 15:00:42 +00:00
Amanda Lin
5b10b6e986 use stderr instead and add tests 2022-04-06 09:57:36 -05:00
Jake Shorty
4aca945e2e Drop unused locationResult 2022-04-05 20:27:10 +00:00
Jake Shorty
41719f7624 Location is an optional flag when creating codespaces 2022-04-05 20:19:19 +00:00
Amanda Lin
6490f658de handle IdleTimeoutNotice 2022-04-05 10:27:26 -05:00
Jeff Hubbard
a84e43cadf Final copy and behavior update for prompt 2022-04-04 16:32:38 -07:00
Jeff Hubbard
9554e522af Change the way we parse list-devcontainers response 2022-03-28 14:24:57 -07:00
Jeff Hubbard
8abf50be1d Change some copy per product's suggestions 2022-03-18 10:10:57 -07:00
Jeff Hubbard
ce3d0791c3
Merge branch 'trunk' into multi-devcontainer 2022-03-16 12:51:03 -07:00
Mark Phelps
43e4e9514d
Merge pull request #5276 from markphelps/codespaces-accept-perms-wording 2022-03-15 12:55:44 -04:00
Josh Spicer
4d5ce7aa56
Adds internal codespace developer flags (#5287) 2022-03-09 15:59:29 +00:00
Mark Phelps
625f3ac144 Updates wording for codespaces accept permissions flow 2022-03-03 15:36:53 -05:00