Commit graph

38 commits

Author SHA1 Message Date
William Martin
971be976b3 Add nameWithOwner to necessary tests 2026-03-26 13:23:43 +01:00
Kynan Ware
5ed8cf0faa fix(pr view): fetch nameWithOwner in headRepository GraphQL query
Commit dd424d85f added NameWithOwner to PRRepository for agent-task
listings but didn't update the headRepository GraphQL query to fetch it.
This caused gh pr view --json headRepository to emit an empty
"nameWithOwner":"" field, breaking the pr-create-respects-simple-
pushdefault acceptance test.

Fetch nameWithOwner in the query and update the test assertion to expect
it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-25 12:47:45 -06:00
William Martin
fb97b3efaa
Fix pr create when push.default tracking and no merge ref (#10863)
* Fix pr create when push.default tracking and no merge ref

* Update pkg/cmd/pr/shared/find_refs_resolution.go

---------

Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-24 16:41:14 +00:00
William Martin
4e68a61a58 Fix pr create when branch name contains slashes
Intentionally have not fixed remote names containing slashes because we
want to get a fix out for the vast majority failure case.
2025-04-24 15:14:49 +02:00
William Martin
a9dbda6913 Rework ref usage when finding and creating PRs 2025-04-15 13:38:10 -06:00
William Martin
ebd147b43e Use verbose upstream setting 2025-04-15 13:38:10 -06:00
Kynan Ware
bdfec50186 fix(pr create): use REPO var in AT 2025-04-15 13:38:10 -06:00
Kynan Ware
6004fc2cd8 fix(pr create): use curly brace for vars in AT 2025-04-15 13:38:10 -06:00
Kynan Ware
0611d9d06d test(pr create): fix user:branch syntax AT
This test was setting `remote.pushDefault` which likely caused
the `user:branch` syntax to be ignored. Update the test to not set
this config value.
2025-04-15 13:38:10 -06:00
Kynan Ware
188e1388b3 test(pr create): add AT for no local repo 2025-04-15 13:38:10 -06:00
Kynan Ware
1ce3d99227 test(pr create): add logical spacing between operations
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
ba6e2ec3ed test(pr create): skip tests that create forks 2025-04-15 13:38:10 -06:00
Kynan Ware
a5fe37f91b test(pr create): add AT for remote:branch syntax 2025-04-15 13:38:10 -06:00
Kynan Ware
1848beb94b test(pr create): unset gh-resolved 2025-04-15 13:38:10 -06:00
Kynan Ware
cd67c2efcb test(pr create): AT assert head repo and head ref 2025-04-15 13:38:10 -06:00
Kynan Ware
a8d01c70cd feat: support @{push} revision syntax 2025-04-15 13:38:10 -06:00
William Martin
cf9ac4447a Acceptance test issue/pr create/edit with project 2025-03-31 17:06:51 +02:00
Andy Feller
c2ba5c0199 Curly bracket wrapping acceptance tests 2025-03-19 08:05:51 -04:00
Andy Feller
018b6d6d07 Initial pass fixing gh issue and gh pr comment
There is still a bit of work to get the gh pr comment tests in order, however this goes a way towards fixing the issue along with acceptance tests.

Also, it turns out some of the issue acceptance tests were really running `pr` tests.
2025-03-17 23:18:36 -04:00
Tyler McGoffin
29e57ee8e7 Add tests for using the pr Finder outside of repo
This includes an acceptance test for `gh pr view` and a unit test on
`TestFind`
2025-01-31 14:22:02 -08:00
Andy Feller
be250b3d33
Add renamed acceptance tests 2025-01-07 10:22:49 +11:00
Andy Feller
8bb2879b87
Reflect coverage for view and status subcommands 2025-01-07 10:22:48 +11:00
Andy Feller
eb16a75ab1
Expand with gh pr status 2025-01-07 10:22:46 +11:00
Andy Feller
2d1e4d625b
Add base gh pr view acceptance tests for changes
These are acceptance tests based on @williammartin work within various issues associated with #9208.

These need to be enhanced to account for `gh pr status`, however that should be quicker given these pass based on the updated branch and upstream fix for cross-repo same org changes.
2025-01-07 10:22:44 +11:00
Caleb Brose
7a1052ca33
Set LocalBranch even if the git config fails 2025-01-03 20:35:48 +00:00
William Martin
96ac8d6a2f Support pr view for intra-org forks 2024-12-13 14:27:41 +01:00
Heath Stewart
5da86e07e7
Merge changes from #10004
Merges changes from @williammartin including acceptance tests and word changes.

Co-authored-by: William Martin <williammartin@github.com>
2024-12-08 20:34:21 -08:00
William Martin
694e565384 Fix PR checkout panic when base repo is not in remotes 2024-12-02 17:20:57 +01:00
William Martin
2a0be61d5e Ensure pr create with metadata has assignment 2024-10-14 14:50:59 +02:00
William Martin
1f94cf9dac Acceptance test PR list 2024-10-14 14:31:24 +02:00
William Martin
4d986aaed4 Acceptance test PR creation with metadata 2024-10-14 13:54:31 +02:00
William Martin
ee5709a4b6 Acceptance test PR comment 2024-10-11 16:31:22 +02:00
William Martin
99a9b35410 Acceptance test PR merge and rebase 2024-10-11 16:31:22 +02:00
William Martin
eb9eeb10e1 Use txtar extension for testscripts 2024-10-11 16:31:22 +02:00
William Martin
464a69ae87 Use stdout2env in PR acceptance tests 2024-10-11 16:31:21 +02:00
William Martin
37171628c6 Acceptance test PR checkout 2024-10-11 16:31:21 +02:00
William Martin
5ed237c65a Add pr view test script 2024-10-11 16:31:21 +02:00
William Martin
d7465bdf3c Initial testscript introduction 2024-10-11 16:31:16 +02:00