Commit graph

407 commits

Author SHA1 Message Date
Alan Donovan
4de4572813 add comment 2021-09-17 09:31:05 -04:00
Alan Donovan
fb197c8e75 Merge branch 'main' into delete-parallel 2021-09-17 09:30:48 -04:00
Raffaele Di Fazio
c6b5fb5ba3 add the tests
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-17 14:55:50 +02:00
Raffaele Di Fazio
054fec0ba1 address code comments
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-17 14:45:08 +02:00
Max Beizer
a4f1fa076b Fix up all the static-check warnings (#162) 2021-09-17 13:10:37 +02:00
Raffaele Di Fazio
29c2a17866 Update cmd/ghcs/delete.go
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 08:55:54 +02:00
Alan Donovan
bc74c4aafa make delete --repo parallel 2021-09-16 18:29:19 -04:00
Jose Garcia
42e47a98d7 add docs, simplify map, error on invalid args 2021-09-16 15:22:47 -04:00
Raffaele Di Fazio
35e0f95243 Update cmd/ghcs/delete.go
Co-authored-by: CamiloGarciaLaRotta <camilogarcialarotta@github.com>
2021-09-16 18:42:41 +02:00
Raffaele Di Fazio
5cd90fea88 fix linter
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 16:45:07 +02:00
Raffaele Di Fazio
68f4cad1af implement delete all with thresold
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 16:42:53 +02:00
Christian Gregg
cc1b86461e Confirm deletion of codespaces with unpushed/uncommited changes (#129)
Adds a confirmation dialog on `ghcs delete` if the codespace in question
has unpushed or uncommited changes.

This confirmation can be skipped using the `--force` or `-f` flag.

Closes: #84
Closes: #10
2021-09-16 13:47:15 +01:00
Mislav Marohnić
dbb4e0c177 Merge remote-tracking branch 'origin' into ruleguard 2021-09-16 11:46:50 +02:00
Jose Garcia
514448dde8 Merge branch 'main' of github.com:github/ghcs into jg/ssh-cmd-flags 2021-09-15 15:45:53 -04:00
Jose Garcia
10ad85486f Merge pull request #154 from github/jg/fix-ctx-error
ghcs create/ssh: fix ctx cancellation errors & fix todo for X11 forwarding
2021-09-15 15:45:35 -04:00
Jose Garcia
45a9715e9f Merge pull request #158 from github/jg/go-liveshare-0.16.0
upgrade to go-liveshare 0.16.0
2021-09-15 15:40:58 -04:00
Jose Garcia
b2234969e4 update logs 2021-09-15 15:40:07 -04:00
Jose Garcia
c5bd8c4127 initial spike to accept args 2021-09-15 15:37:37 -04:00
Jose Garcia
ecd0c70567 upgrade to go-liveshare 0.16.0 2021-09-15 15:15:28 -04:00
Jose Garcia
0f72e3d886 defer stopPolling and docs 2021-09-15 14:29:16 -04:00
Alan Donovan
06719866c9 move api to internal/ 2021-09-15 13:13:10 -04:00
Jose Garcia
547c629220 fix ctx cancellation errors & fix todo for X11 forwarding 2021-09-15 10:38:19 -04:00
Mislav Marohnić
fb5a35568c Ensure original errors are wrapped with "%w" instead of "%v" 2021-09-15 13:58:41 +02:00
Jose Garcia
f5adc9e3a7 remove all deprecation messages and deprecated functionality 2021-09-13 10:58:00 -04:00
Alan Donovan
a5b985523c Merge pull request #147 from github/tty-windows
Don't assume stdin/stdout fds are 0/1 on windows
2021-09-13 09:30:39 -04:00
Alan Donovan
c4be0a0e28 this time without compile errors 2021-09-13 09:29:46 -04:00
Issy Long
74a4afcd77 Merge pull request #139 from github/fix-version-string
goreleaser: Fix version string replacement
2021-09-13 10:32:19 +01:00
Alan Donovan
1526ab5bff fix URL 2021-09-10 18:08:48 -04:00
Alan Donovan
af301bfff1 stdin/stdout fds are not 0/1 on windows 2021-09-10 17:36:20 -04:00
Jose Garcia
ad600d22ed merge upstream 2021-09-10 16:03:09 -04:00
Jose Garcia
798075045e remove terminal, bash_profile setup 2021-09-10 14:58:47 -04:00
Jose Garcia
31e1d974aa Merge pull request #142 from github/jg/delete-flags
ghcs delete: deprecate argument/subcommands & introduce flags
2021-09-10 14:17:44 -04:00
Alan Donovan
2fe71e3576 Merge pull request #138 from github/sigint-delay
Wait forever for SIGINT delivery
2021-09-10 14:15:36 -04:00
Jose Garcia
34e52ba24a deprecate subcommands 2021-09-10 14:11:50 -04:00
Jose Garcia
28ab023b07 Merge pull request #133 from github/jg/ports-flags
ghcs ports: deprecate codespace arg, introduce global flag
2021-09-10 13:33:26 -04:00
Jose Garcia
9b9e533cb9 add comment for special handling 2021-09-10 13:32:30 -04:00
Issy Long
810c127608 goreleaser: Fix version string replacement
- The `Version` variable casing changed in 6a4950cf7a (diff-d897a31624bae4fe935e8dc2243f41626c68639be6643535297c06935277ffb4), so we need to update our version setting code.
- Otherwise, for `ghcs 0.11.0`, `ghcs --version` would print "DEV".
2021-09-10 16:17:37 +01:00
Alan Donovan
4f6cab195a wait for sigint delivery 2021-09-10 10:08:54 -04:00
Alan Donovan
c06d56fa20 Merge pull request #136 from github/sigint
deliver SIGINT to self after Ctrl-C in survey
2021-09-09 18:10:09 -04:00
Jose Garcia
fe2d5ebf37 merge upstream + pr feedback 2021-09-09 17:22:07 -04:00
Alan Donovan
0afdcdec84 Merge pull request #126 from github/lightstep
ghcs: add --lightstep flag for tracing
2021-09-09 16:41:38 -04:00
Alan Donovan
2cbe120774 return err, don"t fatal 2021-09-09 16:39:41 -04:00
Alan Donovan
22f9824ec8 deliver SIGINT to self after Ctrl-C in survey 2021-09-09 16:33:39 -04:00
Jose Garcia
81f08e7baf start converting to flags 2021-09-09 12:08:07 -04:00
Alan Donovan
b96341a5f9 Merge branch 'main' into ask-tty 2021-09-09 12:01:55 -04:00
Alan Donovan
cbb8253544 consolidate survey functions 2021-09-09 11:57:37 -04:00
Jose Garcia
230bf640c5 global flag, choose codespace when empty 2021-09-09 11:06:18 -04:00
Jose Garcia
3a4088a31c Merge branch 'main' of github.com:github/ghcs into jg/ports-flags 2021-09-09 10:19:23 -04:00
Jose Garcia
3b198c1707 switch to Errorln 2021-09-09 10:09:14 -04:00
Jose Garcia
8422e29242 Merge branch 'main' of github.com:github/ghcs into jg/code-flag 2021-09-09 10:08:00 -04:00