Jose Garcia
e87ca729f1
Merge pull request #115 from github/jg/logs-flags
...
ghcs logs: codespace flag, deprecate argument
2021-09-09 10:07:41 -04:00
Alan Donovan
ecb6c8a09a
Merge branch 'main' into lightstep
2021-09-09 09:07:02 -04:00
Christian Gregg
09a6609050
Show * after branch name if codespace working directory is dirty
...
Append a `*` to the end of a branch name in `ghcs list` if the working
directory of the codespace is dirty (has uncommited or unpushed
changes).
Closes : #104
2021-09-09 12:57:39 +01:00
Mislav Marohnić
c89c14aff0
Merge remote-tracking branch 'origin' into jg/logs-flags
2021-09-09 12:55:32 +02:00
Alan Donovan
cbbfafee98
Merge branch 'main' of https://github.com/github/ghcs
2021-09-08 18:04:56 -04:00
Alan Donovan
c6a9915861
add --lightstep flag for tracing
2021-09-08 17:27:34 -04:00
Alan Donovan
3a46f2ac56
add --lightstep flag for tracing
2021-09-08 17:15:42 -04:00
Jose Garcia
d8138c08b8
revert errgroup usage for ssh and logs
2021-09-08 14:56:16 -04:00
Jose Garcia
c86cd34f5e
switch to Errorln
2021-09-08 13:38:27 -04:00
Jose Garcia
efc6fd369c
merge upstream
2021-09-08 13:37:35 -04:00
Jose Garcia
5569cc56c6
Merge pull request #120 from github/jg/output-logger
...
output pkg: new Errorln method and add comments
2021-09-08 13:34:14 -04:00
Jose Garcia
fda40a9682
new Errorln method and add comments
2021-09-08 10:29:30 -04:00
Alan Donovan
d395dae3a8
don't double-print errors
2021-09-06 15:17:24 -04:00
Jose Garcia
b79ea871fd
rename arg
2021-09-03 16:04:00 -04:00
Alan Donovan
9e81dc7fde
fix missing error return
2021-09-03 12:56:47 -04:00
Alan Donovan
2c660fa2e5
avoid ListenTCP helper
2021-09-03 12:55:40 -04:00
Alan Donovan
43198b24aa
use errgroup
2021-09-03 12:50:11 -04:00
Jose Garcia
9193b03b69
introduce follow, deprecate tail
2021-09-03 12:40:01 -04:00
Jose Garcia
9dbf267e54
codespace flag, deprecate argument
2021-09-03 12:33:47 -04:00
Jose Garcia
3216cbc07f
codespace flag, deprecate argument
2021-09-03 11:43:10 -04:00
Jose Garcia
b1d83fe294
codespace flag, deprecate argument
2021-09-03 11:33:33 -04:00
Alan Donovan
a56a84947a
Update ghcs for go-liveshare@v0.12.0
2021-09-03 10:11:29 -04:00
Mislav Marohnić
8f3b6749d7
Merge pull request #4241 from cli/saml-error
...
Suggest to re-authenticate to fix "SAML enforcement" error
2021-09-03 16:10:16 +02:00
Alan Donovan
786a631995
fix local/remote confusion in getPorts (!)
2021-09-02 17:21:24 -04:00
Alan Donovan
981b2545bc
sketch of changes for https://github.com/github/go-liveshare/pull/13
2021-09-02 17:08:17 -04:00
Alan Donovan
1162c8adff
fix go vet loopclosure finding
2021-09-02 16:02:09 -04:00
Alan Donovan
4e2c20606a
Merge branch 'main' into join-session
2021-09-02 15:57:34 -04:00
Alan Donovan
cee761238b
update go-liveshare@v0.11.0
2021-09-02 15:54:00 -04:00
Alan Donovan
3485bacc97
fix StartSharing data race
2021-09-02 15:53:56 -04:00
Jose Garcia
881e6d5940
Merge pull request #111 from github/jg/remove-dir
...
ghcs ssh: remove dir command
2021-09-02 13:33:53 -04:00
Jose Garcia
c15d810d68
remove extra verb arg
2021-09-02 13:27:12 -04:00
Alan Donovan
8570f4111d
sketch after API changes in go-liveshare#11
2021-09-02 12:38:27 -04:00
Alan Donovan
65c19a3317
Merge pull request #107 from github/spelling-again
...
use correct correct spelling of codespace
2021-09-02 11:38:25 -04:00
Alan Donovan
c31fc05746
more typo fixes
2021-09-02 09:09:05 -04:00
Alan Donovan
72a2099a50
fix breakage from API changes
2021-09-01 17:50:24 -04:00
Alan Donovan
49ccdd3d21
use correct correct spelling of codespace
2021-09-01 17:26:26 -04:00
Jose Garcia
bfeb4e77c9
remove dir command
2021-09-01 14:38:37 -04:00
Jose Garcia
2163aba3d5
pass branch for sku selection, pre-select if only one is returned
2021-09-01 13:54:45 -04:00
Alan Donovan
37b2f5e979
Merge branch 'main' into runcommand
2021-08-31 17:18:52 -04:00
Alan Donovan
6a527941bf
suppress display of usage message after errors
2021-08-31 16:35:28 -04:00
Alan Donovan
f1c3a22a0b
Merge branch 'main' into product-spelling
2021-08-31 16:24:41 -04:00
Alan Donovan
68792d5aa5
Merge branch 'main' into runcommand
2021-08-31 16:19:37 -04:00
Edmundo Gonzalez
d6f52ae557
Merge pull request #91 from github/edgonmsft/codespaces-ssh-rpc
...
Implement RPC interface so that the codespaces agent starts and configures ssh in the codespace
2021-08-31 13:05:56 -07:00
Alan Donovan
c0aae52289
move port choice, and PortForwarder.Start call, into clients
2021-08-31 13:58:46 -04:00
Alan Donovan
509e037a5e
address review comments
2021-08-31 12:02:29 -04:00
Alan Donovan
bbcf2dd321
spell product names (Codespaces, Live Share) correctly
2021-08-31 11:15:26 -04:00
Alan Donovan
ea97e2e73d
remove sleep 1s
2021-08-30 18:15:37 -04:00
Alan Donovan
40317e91f8
cleanup to ssh api
2021-08-30 17:46:04 -04:00
Edmundo Gonzalez
903b7be7de
Comments from pr.
2021-08-30 21:01:13 +00:00
Mislav Marohnić
b0b67014f1
Suggest to re-authenticate to fix "SAML enforcement" error
...
As far as I can put together, this error appears when someone has
authenticated GitHub CLI with a PAT that isn't authorized to access a
certain org. It can also happen if someone has authorized GitHub CLI
using the legacy "GitHub CLI (dev)" OAuth app instead of our production
OAuth app.
Doing `gh auth refresh` will re-authenticate the user using our
production "GitHub CLI" OAuth app which will not have problems accessing
resources in different GitHub organizations.
2021-08-30 17:18:59 +02:00
