Edmundo Gonzalez
ee36a005b1
Merge remote-tracking branch 'origin/main' into edgonmsft/codespaces-ssh-rpc
2021-08-30 05:01:22 +00:00
Edmundo Gonzalez
5db9e2d83e
PR changes.
2021-08-30 04:48:56 +00:00
Jose Garcia
634796e8a8
merge main
2021-08-27 18:18:30 -04:00
Jose Garcia
adc1ee5e2d
merge main
2021-08-27 17:43:43 -04:00
Jose Garcia
368e8c6110
simplify contract for state polling
2021-08-27 17:34:06 -04:00
Alan Donovan
9f082ca887
Merge branch 'main' into main-style
2021-08-27 17:30:34 -04:00
Jose Garcia
c66cf0da39
Merge pull request #92 from github/jg/remove-dst-port
...
Remove destination port column and add docs
2021-08-27 17:06:48 -04:00
Jose Garcia
e5f45d4bfa
docs and improvement to the showStatus implementation
2021-08-27 16:41:22 -04:00
Jose Garcia
1e8a8370fe
initial round of PR feedback
2021-08-27 16:29:02 -04:00
Alan Donovan
e423cb0ef9
display colon and cursor in survey prompts
2021-08-27 16:09:02 -04:00
Alan Donovan
8b395b5ab5
ghcs code: improve vscode error
2021-08-27 15:53:55 -04:00
Alan Donovan
a5ae72cb26
revert removal of _ = f() to pacify linter
2021-08-27 15:38:41 -04:00
Alan Donovan
d8f1baa519
more SKU renames.
2021-08-27 15:36:45 -04:00
Alan Donovan
da34d12abb
respond to review
2021-08-27 15:26:34 -04:00
Jose Garcia
da8655209b
make things private
2021-08-27 12:52:30 -04:00
Jose Garcia
cb6552f4ca
more efficient impl for processing states
2021-08-27 12:50:32 -04:00
Alan Donovan
38ff786a7d
cmd/ghcs: style tweaks
2021-08-27 12:03:20 -04:00
Jose Garcia
8e95493872
period
2021-08-27 15:46:40 +00:00
Jose Garcia
5dc923777b
update docs, make ports private to be more consistent
2021-08-27 15:32:18 +00:00
Jose Garcia
3dcee5cca7
remove dst port column and add docs
2021-08-27 12:41:36 +00:00
Edmundo Gonzalez
b6094e0006
Changes to point to RPC service.
2021-08-26 21:50:20 +00:00
Jose Garcia
e4e77a4294
merge upstream
2021-08-26 08:55:38 -04:00
Jose Garcia
151eb2b656
fix linter
2021-08-26 08:35:30 -04:00
Gabriel Ramírez
a48f1070c3
Merge pull request #86 from github/auto-ssh-composition
...
Piping support for ssh and code
2021-08-25 09:11:43 -05:00
Mislav Marohnić
11fbb60ae7
Rename the module to "github.com/cli/cli/v2"
2021-08-25 12:41:30 +02:00
Jose Garcia
2ef6e95982
show status under a flag
2021-08-24 20:15:21 -04:00
Jose Garcia
46ee45bcdd
simplify the state iteration
2021-08-24 17:46:24 -04:00
Gabriel Ramirez
30be4c98f9
Send codespace name to Stdout to enable scripting
2021-08-24 13:12:18 -05:00
Josh Gross
ae88091fd8
Replace options struct with variable
2021-08-23 12:01:13 -04:00
Mislav Marohnić
af2aecd40b
Merge pull request #4146 from cli/force-tty
...
Add ability to force terminal-style output even when redirected
2021-08-23 16:46:14 +02:00
Mislav Marohnić
8129fb3d3e
Merge pull request #4171 from mahdyar/chore/make-gh-status-clickable
...
chore: make gh status link clickable
2021-08-23 13:12:35 +02:00
Mahdyar Hasanpour
db74830e64
chore: make gh status clickable
...
Adding https:// to githubstatus.com to make it clickable on terminal emulators
2021-08-22 18:01:55 +04:30
Josh Gross
530c0244f9
Add support to code for VS Code Insiders
2021-08-19 17:37:57 -04:00
Mislav Marohnić
51d609078b
Enable gh help <command> for extensions
...
This sends the `--help` flag to the extension. The extension is
reponsible for printing something useful as a result.
2021-08-19 20:38:19 +02:00
Jose Garcia
55f0dad3db
merge upstream
2021-08-19 18:30:10 +00:00
Issy Long
a53eb53ad4
cmd/ghcs/ports: Fix usage docs for the new source:forward syntax
...
Co-authored-by: George Brocklehurst <georgebrock@github.com>
2021-08-19 10:10:30 +01:00
Issy Long
28a3644a07
cmd/ghcs/delete: I learnt about strings.EqualFold - thanks, linter!
2021-08-18 18:15:15 +01:00
Issy Long
5af1cccb73
cmd/ghcs/delete: When matching repos to delete, standardize casing
...
- It was possible to delete Codespaces for repo `SomePerson/foo` but not
`someperson/foo`, despite the fact that the GitHub APIs don't actually
care about casing - `SomePerson` and `someperson` is the same account.
- This fixes that by lowercasing both the user-provided repo name, and
the repository that is attached to the Codespace for a match.
- Fixes #76 .
2021-08-18 18:11:11 +01:00
Mislav Marohnić
321fd98f82
Add ability to force terminal-style output even when redirected
2021-08-17 20:12:25 +02:00
Jose Garcia
8533d08461
rename var
2021-08-17 13:07:40 +00:00
Jose Garcia
b5670252de
small update to description
2021-08-17 12:58:46 +00:00
Jose Garcia
5fe84c6121
merge upstream
2021-08-17 12:57:04 +00:00
Mislav Marohnić
517aae2805
Merge remote-tracking branch 'origin' into docs
2021-08-17 14:42:09 +02:00
Mislav Marohnić
6dd0bf8e5e
Merge pull request #67 from github/jg/output-formats
...
add back . indicators & update ConnectToTunnel
2021-08-17 13:07:14 +02:00
Mislav Marohnić
b47686163a
Fixes for log/output streams
2021-08-17 13:04:55 +02:00
Mislav Marohnić
5e472bc0e5
Improve command descriptions and argument assertions
2021-08-16 23:24:11 +02:00
Mislav Marohnić
97d8285b58
Do not require GITHUB_TOKEN for merely viewing command help
2021-08-16 23:19:20 +02:00
Mislav Marohnić
22be26431e
Have --codespace <name> flag be consistent across commands
2021-08-16 22:31:29 +02:00
Jose Garcia
c9c1ff8dac
add back . indicators & update ConnectToTunnel
2021-08-16 20:16:50 +00:00
Mislav Marohnić
20d75f0ff9
Normalize logging, output, and error reporting
...
- Return errors as errors, not print to stdout and return nil
- Ensure errors and warnings are always written to stderr, not stout
- Do not print progress to stdout unless stdout is a terminal
2021-08-12 14:37:23 +02:00
