Jose Garcia
535d832f8a
small tweak
2021-08-31 15:50:04 -04:00
Alan Donovan
c0aae52289
move port choice, and PortForwarder.Start call, into clients
2021-08-31 13:58:46 -04:00
Alan Donovan
509e037a5e
address review comments
2021-08-31 12:02:29 -04:00
Alan Donovan
bbcf2dd321
spell product names (Codespaces, Live Share) correctly
2021-08-31 11:15:26 -04:00
Alan Donovan
40317e91f8
cleanup to ssh api
2021-08-30 17:46:04 -04:00
Edmundo Gonzalez
903b7be7de
Comments from pr.
2021-08-30 21:01:13 +00:00
Edmundo Gonzalez
954d46dce5
Changes from comments on pr.
2021-08-30 17:30:28 +00:00
Edmundo Gonzalez
0c066cbd09
Fix compilation error.
2021-08-30 05:05:43 +00:00
Edmundo Gonzalez
ee36a005b1
Merge remote-tracking branch 'origin/main' into edgonmsft/codespaces-ssh-rpc
2021-08-30 05:01:22 +00:00
Edmundo Gonzalez
13917a289d
Moved function to ssh.go file.
2021-08-30 04:52:27 +00:00
Edmundo Gonzalez
5db9e2d83e
PR changes.
2021-08-30 04:48:56 +00:00
Jose Garcia
634796e8a8
merge main
2021-08-27 18:18:30 -04:00
Jose Garcia
0cf2640c86
better docs and stop ticker
2021-08-27 18:14:10 -04:00
Jose Garcia
272af2fadf
add docs
2021-08-27 18:12:06 -04:00
Jose Garcia
a5a18026cc
fix linter
2021-08-27 17:39:10 -04:00
Jose Garcia
368e8c6110
simplify contract for state polling
2021-08-27 17:34:06 -04:00
Jose Garcia
1e8a8370fe
initial round of PR feedback
2021-08-27 16:29:02 -04:00
Jose Garcia
2cc91c224e
add comment for improvements
2021-08-27 12:53:27 -04:00
Jose Garcia
cb6552f4ca
more efficient impl for processing states
2021-08-27 12:50:32 -04:00
Alan Donovan
38ff786a7d
cmd/ghcs: style tweaks
2021-08-27 12:03:20 -04:00
Edmundo Gonzalez
d5a26e1536
Apply renames on the go-liveshare side.
2021-08-26 23:14:13 +00:00
Edmundo Gonzalez
b6094e0006
Changes to point to RPC service.
2021-08-26 21:50:20 +00:00
Jose Garcia
46ee45bcdd
simplify the state iteration
2021-08-24 17:46:24 -04:00
Jose Garcia
55f0dad3db
merge upstream
2021-08-19 18:30:10 +00:00
Mislav Marohnić
b47686163a
Fixes for log/output streams
2021-08-17 13:04:55 +02:00
Mislav Marohnić
20d75f0ff9
Normalize logging, output, and error reporting
...
- Return errors as errors, not print to stdout and return nil
- Ensure errors and warnings are always written to stderr, not stout
- Do not print progress to stdout unless stdout is a terminal
2021-08-12 14:37:23 +02:00
Jose Garcia
76aca39f5b
Create status support
2021-08-04 17:35:11 +00:00
Jose Garcia
e57b390d4a
dotfiles status spike
2021-08-03 13:42:34 +00:00
Jose Garcia
58a055609d
logs cmd spike and refactor of ssh tunnel methods
2021-07-29 10:57:51 -04:00
Jose Garcia
9544f8acc9
Commit vendors
2021-07-28 09:05:58 -04:00
Jose Garcia
798413848b
Portfowarding private/public/forward now supported
2021-07-17 20:32:47 -04:00
