Commit graph

18 commits

Author SHA1 Message Date
Kynan Ware
25c0d0cf90 Refactor comments in stripDiffFormat function
Simplified and clarified comments in the stripDiffFormat function to improve readability and maintainability. No functional changes were made to the code.
2025-09-17 12:16:04 -06:00
Kynan Ware
b3401ffd74 Refactor stripDiffFormat guard clause logic
Rearranged the guard clause in stripDiffFormat to return early if no hunk header is found, improving code clarity and reducing nesting.
2025-09-16 17:46:43 -06:00
Kynan Ware
c0a2648436 Use filepath.Ext to detect file extension in markdown renderer
Replaces manual string splitting with filepath.Ext for determining the file extension in renderFileContentAsMarkdown. This improves accuracy, especially for files with multiple dots in their names.
2025-09-16 17:34:57 -06:00
Kynan Ware
65b45adbd8 Improve log rendering error handling and test coverage
Refactors log rendering to print errors to stderr and continue processing on JSON parse or rendering failures, instead of returning early. Updates tests to check both stdout and stderr outputs, and adds new test cases and testdata for tolerant parsing and error scenarios.
2025-09-16 17:21:01 -06:00
Kynan Ware
97d3253aaf Prefix rendered shell commands with '$ ' in logs
Shell commands in log output are now prefixed with '$ ' for improved readability and consistency with common shell output conventions. Updated related test data and test helper comments to reflect this change.
2025-09-16 11:58:58 -06:00
Kynan Ware
37d8e0a438 Refactor generic tool call titles map to package scope
Moved the genericToolCallNamesToTitles map from inside the renderGenericToolCall function to a package-level variable for improved readability and potential reuse. This change also updates the function signature order for consistency.
2025-09-16 11:46:16 -06:00
Kynan Ware
f779a3d16c Add TODO for bash-related tool call details
Inserted a TODO comment to consider including more details for bash-related tool calls in the log rendering function.
2025-09-15 14:23:12 -06:00
Kynan Ware
77509fcfb3 Update comment for reasoning text formatting
Clarifies that reasoning text should be formatted as a normal 'thought' message without a heading, improving code documentation.
2025-09-15 14:19:31 -06:00
Kynan Ware
887e842717 Enable Bash session tool handling in log rendering
Uncomments and activates support for Bash session tool calls (write_bash, read_bash, stop_bash, async_bash, read_async_bash, stop_async_bash) in the renderLogEntry function. Also defines the corresponding argument structs, enabling proper handling and display of these tool calls in the log output.
2025-09-15 14:18:42 -06:00
Kynan Ware
e5e7bc8ad6 Add and improve function documentation in log.go
Added and expanded Go doc comments for multiple functions in pkg/cmd/agent-task/shared/log.go to clarify their purpose and usage. Also refactored renderToolCallTitle and related logic for improved naming consistency and robustness.
2025-09-15 13:05:47 -06:00
Kynan Ware
282a25f466 Rename renderToolCall to renderToolCallTitle
Refactors the function renderToolCall to renderToolCallTitle and updates all its usages for clarity. This improves function naming to better reflect its purpose of rendering tool call titles.
2025-09-15 12:41:46 -06:00
Kynan Ware
3829cff8da Rename relativePath to relativeFilePath in log rendering
Refactored the function name from relativePath to relativeFilePath for clarity and updated all usages accordingly in log rendering functions. Also improved comments in stripDiffFormat for better context.
2025-09-15 12:41:17 -06:00
Kynan Ware
718c462454 Refactor markdown rendering helper function names
Renamed renderMarkdownWithPadding to renderMarkdownWithFormat and related variables for clarity. Updated comments and TODOs for better context on GUI support and code behavior.
2025-09-15 12:34:44 -06:00
Kynan Ware
ec3fce0dfb Improve log rendering and tool call handling
Enhances log rendering by stripping diff formatting from viewed file content and improving JSON rendering with optional labels. Expands the list of recognized tool calls with descriptive titles, especially for Playwright and GitHub MCP server tools. Refactors related helper functions for clarity and robustness.
2025-09-15 10:13:55 -06:00
Kynan Ware
9e16a82e5e Refactor JSON content rendering in log entries
Extracted JSON content rendering into a new helper function renderContentAsJSONMarkdown for reuse. Updated 'report_progress' and 'create' tool call handling to use this helper, improving code clarity and reducing duplication. Also added support for rendering PR descriptions in 'report_progress' tool calls.
2025-09-15 10:13:55 -06:00
Kynan Ware
0fb10fca7d Various log rendering improvements
Updated the LogRenderer interface and implementations to accept *iostreams.IOStreams instead of *iostreams.ColorScheme, enabling access to terminal theme and width for improved markdown rendering. Refactored related code, tests, and mocks to support this change, and enhanced log rendering to better handle markdown and code output for various tool calls.
2025-09-15 10:13:55 -06:00
Babak K. Shandiz
1155e83070 feat(agent-task view): add --log and --follow flags
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-15 10:13:55 -06:00
Babak K. Shandiz
05e609c5b3 fix(agent-task/shared): add log renderer
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-15 10:13:55 -06:00