Ashwin Jeyaseelan
a756ffb1e8
Fix Codespace Creation Devcontainer bug ( #6389 )
2022-10-18 11:11:28 +03:00
Mislav Marohnić
3fe5026d39
Migrate to tableprinter from go-gh ( #6346 )
2022-10-17 15:15:39 +02:00
David Gardiner
f80f566ab2
Merge pull request #6358 from dmgardiner25/dmgardiner25/grpc-client
...
Implement gRPC client and `GetRunningServer` method
2022-10-11 10:45:50 -07:00
Jose Garcia
a356a1bef0
no need to ignore cancel
2022-10-11 13:15:34 -04:00
Jose Garcia
e11b43f8f6
Fixes for handling the grpc client lifecyle
2022-10-11 08:55:14 -04:00
David Gardiner
f89b1b6a45
Create timeout context in caller
2022-10-10 14:39:12 -07:00
JP Ungaretti
982aa5ba82
Rename RPC command to RebuildContainer
2022-10-10 21:01:29 +00:00
JP Ungaretti
0e963ebd4f
Move codespace construction to its test
2022-10-09 01:11:04 +00:00
JP Ungaretti
d05cdf5ff3
Tidy up comments and errors
2022-10-08 06:30:42 +00:00
JP Ungaretti
4c49fd3e64
Add rebuild command
2022-10-08 06:12:36 +00:00
JP Ungaretti
da91216c31
Add new Rebuild function
2022-10-08 00:04:45 +00:00
David Gardiner
766e6a2314
Use existing context
2022-09-29 09:58:44 -07:00
Anthony Fok
f6d0f82701
Fix missing text in gh-codespace-ssh.1 man page
...
Rearrange the long help text so that '--config' does not appear at the
start of a line which groff interprets as an undefined macro and skips
the content of that whole line.
To reproduce:
$ go run cmd/gen-docs/main.go --man-page --doc-path /tmp/gh-manpages
$ man --warnings -E UTF-8 -l -Tutf8 -Z /tmp/gh-manpages/gh-codespace-ssh.1 >/dev/null
troff: <standard input>:26: warning: macro '--config'' not defined
Discovered by the Debian Lintian tool.
2022-09-28 14:00:37 -06:00
David Gardiner
35d2cf30d0
Send session token
2022-09-28 11:28:35 -07:00
David Gardiner
3f34d6d95e
Make suggested gRPC client changes
2022-09-28 10:39:26 -07:00
Caleb Brose
cc98ffd6fa
Ensure local keys don't interfere with ssh_test
2022-09-21 19:43:31 +00:00
Caleb Brose
bb6db4b309
PR suggestions
2022-09-20 22:00:27 +00:00
Caleb Brose
4a8047ed61
Improve error handling
2022-09-20 19:36:07 +00:00
Caleb Brose
deedd35a2c
Merge branch 'cmbrose/no-ssh-api-call' of https://github.com/cli/cli into cmbrose/no-ssh-api-call
2022-09-20 18:32:01 +00:00
Caleb Brose
373634ad75
Rename to generateAutomaticSSHKeys
2022-09-20 18:32:00 +00:00
Caleb Brose
045bb54157
Apply suggestions from code review
...
Co-authored-by: Jose Garcia <josebalius@github.com>
2022-09-20 13:22:38 -05:00
Caleb Brose
049a3676f4
Use filepath instead of path
2022-09-20 15:59:38 +00:00
Caleb Brose
3b52df6f99
Don't add private key for -i
2022-09-20 15:21:59 +00:00
Caleb Brose
dba1259d32
Update tests
2022-09-20 01:02:06 +00:00
Caleb Brose
0c00ca911e
Clean up API interface
2022-09-16 22:25:11 +00:00
Caleb Brose
939c7c71cd
Remove API call for ssh keys
2022-09-16 22:22:13 +00:00
Sam Coe
a30de8d72a
Output paid message for codespace create to stderr not stdout ( #6258 )
2022-09-14 11:33:55 +00:00
Sam Coe
e7102f9d84
Migrate to go-gh text package ( #6236 )
2022-09-14 09:23:55 +04:00
Mislav Marohnić
a6636994bf
Disable flakey ports update visibility tests ( #6203 )
2022-09-06 15:31:36 +00:00
Caleb Brose
6b24949649
Merge pull request #5958 from cli/cmbrose/no-auto-key-if-uploaded
...
Check for already configured ssh keys before using automatic key
2022-08-23 12:09:16 -05:00
Sam Coe
6a8deb1f5a
Integrate latest go-gh packages ( #6084 )
2022-08-18 09:04:13 +03:00
Caleb Brose
d8b06ae8af
Add check to -i short circuit for the automatic key
2022-08-16 10:15:43 -05:00
Eljo George
54e5673bd6
remove blank spaces
2022-08-12 21:04:21 +00:00
Eljo George
9f1f74c30a
SSH help text to suggest the new features syntax
2022-08-12 21:00:57 +00:00
Caleb Brose
c781ea520a
Better .ssh directory
2022-08-10 14:29:14 -05:00
Caleb Brose
3d45244dcc
Add -i option to the proxy ssh call in config
2022-08-10 10:57:34 -05:00
Caleb Brose
d410830f7f
Handle comment in local ssh key
2022-08-09 11:11:11 -05:00
Caleb Brose
cb914c1873
Cleanup extra param, array declaration
2022-08-09 10:16:24 -05:00
Caleb Brose
b25df2daf4
Merge branch 'trunk' into cmbrose/no-auto-key-if-uploaded
2022-08-09 10:06:37 -05:00
Caleb Brose
0d9b2bf4ce
SHort circuit api check if auto keys exist
2022-08-05 18:24:36 +00:00
Mislav Marohnić
2dd63e23fc
Merge pull request #6008 from AyeshaGagguturi/ayesha/delete-prebuild-availibity-enum
...
Delete blob + pool
2022-08-04 19:09:13 +02:00
Eljo George
53bddb0fd5
Update codespaces ssh doc
2022-08-03 19:50:55 +00:00
Caleb Brose
f63d4c0a4a
Linter
2022-08-03 15:50:30 +00:00
Caleb Brose
5212fc8d5b
Error handling
2022-08-03 15:26:00 +00:00
Caleb Brose
b6c469518f
Linter
2022-08-02 21:53:17 +00:00
Caleb Brose
894b553b78
Add a couple more scenarios
2022-08-02 21:39:33 +00:00
Caleb Brose
d3d72dd820
Add test for hasUploadedPublicKeyForConfig
2022-08-02 21:37:02 +00:00
Caleb Brose
d3c07706a4
Merge branch 'cmbrose/no-auto-key-if-uploaded' of https://github.com/cli/cli into cmbrose/no-auto-key-if-uploaded
2022-08-02 20:57:55 +00:00
Caleb Brose
88b28c5228
Fix api mock
2022-08-02 20:57:52 +00:00
Eljo George
ace223d782
updated message
2022-08-01 23:49:49 +00:00
