Commit graph

34 commits

Author SHA1 Message Date
Babak K. Shandiz
284880c21e
Fix StatusJSONResponse usage (#10810)
* Fix `StatusJSONResponse` usage

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Replace `assert` with `require`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Improve assertion against errors

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Add `JSONErrorResponse` helper func

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `httpmock.JSONErrorResponse`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Replace `StatusJSONResponse` to `JSONErrorResponse` for better readibility

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix improper use of `StatsJSONResponse`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-01 20:22:43 +01:00
Andy Feller
f9d50d86ac
Merge pull request #10508 from iamazeem/10449-inconsistent-examples-format
Inconsistent format of examples in help text
2025-02-27 09:15:14 -05:00
Azeem Sajid
33c30d5bd1 Inconsistent format of examples in help text 2025-02-27 16:26:25 +05:00
Azeem Sajid
69fff52026
Inconsistent format of description of flags (starting with lowercase letter) (#10507) 2025-02-27 11:40:21 +01:00
Tyler McGoffin
3feeb9a826 Add tests for deleteGist 2025-01-14 14:21:49 -08:00
danochoa
1d9b4e4464 fix tests 2025-01-12 19:36:44 -06:00
danochoa
08f7706c42 fix tests 2025-01-12 19:18:24 -06:00
danochoa
7885167c70 gist delete - check no gists 2025-01-12 17:01:45 -06:00
danochoa
5de282c970 drop description from prompts, fix tests 2025-01-11 01:35:12 -06:00
danochoa
7f71681ace gist delete - use in confirmation and success info 2025-01-10 01:07:11 -06:00
danochoa
dccbc99fdf fix gist description in tests 2025-01-08 20:47:50 -06:00
danochoa
9c65a32ef8 gist delete prompt with gist description 2025-01-08 17:56:02 -06:00
danochoa
a8f0aaeb3d tentative updates for acceptance criteria
- pending confirmation re description in prompt
2025-01-08 02:22:21 -06:00
danochoa
75ace410a3 cleanup 2025-01-03 13:09:32 -06:00
danochoa
f87d9f98f1 gist delete prompt for confirmation 2025-01-03 12:51:09 -06:00
danochoa
61ffbe157d undo extra move 2024-12-31 01:43:39 -06:00
danochoa
8390b4154b rearrange struct vals for consistency 2024-12-30 18:18:50 -06:00
danochoa
8f19d3b102 add gist delete tests for blank gist id 2024-12-30 17:24:10 -06:00
danochoa
049332d844 gh gist delete: prompt for gist id 2024-12-30 15:41:18 -06:00
William Martin
1d38230675
Move config interfaces into gh package (#9060) 2024-05-10 10:39:36 +02:00
Sam Coe
c9a2d85793
Cleanup config.AuthToken and config.DefaultHost methods (#7049) 2023-02-28 00:24:45 +00:00
Sam Coe
cacff4ad6d
Use go-gh config package (#5771) 2022-06-23 11:50:04 +00:00
Mislav Marohnić
0bc8aae45f Avoid crash when deleting gist with no owner
This removes the explicit check for the gist owner, speeding up the gist
deletion due to fewer API requests, but resulting in a more vague error
message in case the gist is "not found".
2022-04-25 13:24:19 +02:00
nate smith
2f19fa792f maint: clean up some errors 2022-01-24 17:34:21 -06:00
Mislav Marohnić
e43cb2b880 Port more legacy stubs to the new ask stubber 2022-01-14 19:34:15 +01:00
Mislav Marohnić
11fbb60ae7 Rename the module to "github.com/cli/cli/v2" 2021-08-25 12:41:30 +02:00
Sam
9ec1e21d4c
Default to GHES host if only GHES is authenticated (#3286) 2021-03-30 16:51:00 +02:00
Gowtham Munukutla
61eb7eeeab Add msg in gist delete 2021-02-24 15:53:07 +05:30
Gowtham Munukutla
cbf8a0d964 Accept only one argument when deleting a gist 2021-02-23 20:12:26 +05:30
Mislav Marohnić
622317ee89 Tweak gist docs 2021-02-03 22:39:58 +01:00
Nate Smith
3a9e47bf1b
Merge pull request #2664 from cristiand391/gist-friendly-error
Print friendly error when 'gh gist <command>' is missing required argument
2021-01-21 14:41:03 -08:00
Cristian Dominguez
ce151420f3 Migrate legacy tests 2021-01-11 21:07:19 -03:00
Cristian Dominguez
55c717d3d3 Print friendly error when 'gh gist <command>' is missing required argument 2020-12-21 10:01:30 -03:00
Alex Johnson
99574f85a3
Add a command to delete a gist (#2265)
* Add a command to delete a gist

* minor cleanup

Co-authored-by: vilmibm <vilmibm@github.com>
2020-11-16 15:47:55 -06:00