bahtya
57b2477752
Fix infinite loop in 'gh release list --limit 0'
...
Other list subcommands correctly reject --limit 0 but 'release list'
does not validate the limit, causing an infinite loop.
Add validation consistent with other subcommands and a test.
Closes #13078
2026-04-04 18:13:25 +08:00
Kynan Ware
8ed2fc913c
Clarify --clobber flag deletes assets before re-uploading
...
Update the help text and flag description for `gh release upload --clobber`
to make it clear that existing assets are deleted before new ones are uploaded,
and that original assets will be lost if the upload fails.
Fixes #8822
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-17 18:11:57 -07:00
Kynan Ware
9de48154de
Add missing TODO comments for featuredetection if-statements
...
Add greppable TODO identifiers above all if-statements that reference
featuredetection struct fields, as required by the featuredetection
linter. This ensures every feature detection branch is tagged for
future cleanup when GHES gains support.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-16 14:24:32 -07:00
Babak K. Shandiz
9d2bea6308
docs(release list): fix typo
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 20:38:04 +00:00
Babak K. Shandiz
98389269b6
docs(release list): reword comment
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 20:36:27 +00:00
Babak K. Shandiz
065fc38c4d
feat(release list): add isImmutable JSON field
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 19:53:39 +00:00
Brian DeHamer
95719714d9
Merge pull request #11991 from cli/copilot/update-gh-release-verification
...
Use "release" sentinel value for release attestation verification
2025-10-23 09:14:11 -07:00
Brian DeHamer
b7cea1d935
test fixup
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-10-22 08:56:13 -07:00
copilot-swe-agent[bot]
74ac20671c
Update release verify commands to use sentinel value
...
Co-authored-by: bdehamer <398027+bdehamer@users.noreply.github.com>
2025-10-22 15:26:36 +00:00
Brian DeHamer
937f6d8c2e
improve docstring for release-create
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-10-16 11:54:05 -07:00
ejahnGithub
a2034545cc
update the description
2025-09-24 14:04:28 -04:00
ejahnGithub
c1969f0523
remove hidden value for release verify cmd
2025-09-23 16:45:26 -04:00
Eugene
ea08200f01
Merge branch 'trunk' into eugene/release_verify_tag_name_fix
2025-09-23 11:52:17 -04:00
ejahnGithub
4fb9b29ac9
fix latest tag for relase verify asset
2025-09-23 11:50:57 -04:00
ejahnGithub
8d701dc13e
update the test
2025-09-23 11:12:19 -04:00
ejahnGithub
3ba03e3200
add initiator_type for attestations
2025-09-23 10:59:07 -04:00
Andrey
204536cdd0
docs(release create): difference --generate-notes and --notes-from-tag ( #11534 )
...
* docs(release create): distinguish difference between '--generate-notes' and '--notes-from-tag'
Signed-off-by: Andrey <andrekabatareika@gmail.com>
* Clarify release notes behavior for unannotated tags
Updated help text to specify that if a git tag is not annotated, the release notes will use the commit message instead of the tag annotation.
---------
Signed-off-by: Andrey <andrekabatareika@gmail.com>
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-08-25 15:20:21 +00:00
Eugene
5ae174b6b3
Merge pull request #11511 from cli/eugene/trusted_root_flag_for_release_verify
...
Hidden trusted root flag for release verify
2025-08-15 16:58:19 -04:00
Eugene
7316ddc57d
Update pkg/cmd/release/verify/verify.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-08-14 16:08:44 -04:00
Eugene
e23c9d087d
Update pkg/cmd/release/verify-asset/verify_asset.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-08-14 16:08:37 -04:00
ejahnGithub
79888378d8
Hidden trusted root flag for release verify
2025-08-14 14:00:55 -04:00
ejahnGithub
c4d14044c7
udpate the test
2025-08-13 14:42:50 -04:00
ejahnGithub
2d9cf84690
replace /git/refs/tags/ to /git/ref/tags/
2025-08-13 11:23:06 -04:00
ejahnGithub
ec086af25c
add test for FetchRefSHA
2025-08-08 17:32:30 -04:00
ejahnGithub
1beb8252a7
fix error for ErrReleaseNotFound when fetching ref
2025-08-04 20:58:45 -04:00
Eugene
806ae030ce
Merge pull request #11261 from cli/attester/tenancy-aware-for-san
2025-07-17 17:17:31 -04:00
Brian DeHamer
c335c5e25f
include immutable field in release view
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-07-10 11:46:09 -07:00
ejahnGithub
d068696c4d
add tenancy aware for san matcher
2025-07-09 15:55:41 -04:00
ejahnGithub
169b909015
improve the description for gh release verify cmd
2025-06-19 10:18:23 -04:00
Eugene
898bb42719
Merge branch 'trunk' into eugene/release-verify
2025-06-17 07:54:26 -07:00
William Martin
49ed6c4681
Use t.Chdir in tests
2025-06-17 11:44:14 +02:00
Brian DeHamer
53cae592f6
refactor to simplify implementation
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-06-05 10:35:21 -07:00
ejahnGithub
d7d9228609
use standardize color roles logic for the logging
2025-05-30 14:08:59 -07:00
ejahnGithub
5048d586dc
moved to shared lib
2025-05-30 13:46:54 -07:00
ejahnGithub
bf4b793eff
moved to shared lib
2025-05-30 13:43:07 -07:00
ejahnGithub
56f8877097
update the artifact and bundle for testing
2025-05-30 13:31:23 -07:00
ejahnGithub
df87b15598
clean the code
2025-05-30 12:53:19 -07:00
ejahnGithub
96db923f19
revert the workflow
2025-05-30 12:33:40 -07:00
ejahnGithub
b423edff7b
debug windows env
2025-05-30 11:51:33 -07:00
ejahnGithub
53cb90aeca
debug windows env
2025-05-30 11:16:04 -07:00
ejahnGithub
2312cfb146
clean the path
2025-05-30 10:07:18 -07:00
ejahnGithub
6d90ad6a2d
clean the path
2025-05-30 09:58:23 -07:00
ejahnGithub
e00e1c414b
clean the path
2025-05-30 09:46:46 -07:00
ejahnGithub
8e6ed6eb38
improve test
2025-05-30 09:30:05 -07:00
ejahnGithub
3b17318ee4
fix test
2025-05-30 08:31:07 -07:00
Eugene
15b7692f1a
Merge branch 'trunk' into eugene/release-verify
2025-05-30 08:20:42 -07:00
ejahnGithub
71c2361dfc
add unit test
2025-05-30 08:17:21 -07:00
Brian DeHamer
fc6ac59bbc
fixup release asset digest tests
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-05-29 12:00:40 -07:00
Brian DeHamer
0d6b9f89a4
remove nolint comment for release header
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-05-29 11:54:44 -07:00
Brian DeHamer
7b33da981e
Update pkg/cmd/release/view/view.go
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-29 11:53:33 -07:00