STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11279 commits 87 branches 0 tags 160 MiB
Commit graph

5446 commits

Author SHA1 Message Date
Meredith Lancaster
6b226754fd pass http client for use with tuf 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-05-07 09:18:43 -06:00
Meredith Lancaster
c5a2defec8 Merge branch 'trunk' into gh-attestation-tuf-client-retry 2025-05-07 08:50:51 -06:00
William Martin
55cd3c34cd Feature detect v1 projects on pr edit 2025-05-07 16:17:15 +02:00
Azeem Sajid
ee281fd9ba
Add closedByPullRequestsReferences JSON field to issue view (#10941) 
* [gh issue view] Expose `closedByPullRequestsReferences` JSON fields

* Incorporate GitHub Copilot review suggestions

* Incorporate review changes
 2025-05-07 13:59:22 +01:00
Meredith Lancaster
315876852a
Merge pull request #10670 from malancas/move-predicate-type-filtering 
Move predicate type filtering in `gh attestation verify`
 2025-05-06 11:08:34 -06:00
William Martin
a2fcb9b2df
Merge pull request #10915 from cli/wm/projectsv1-deprecation-pr-create-rest 
Feature detect v1 projects on interactive `pr create`
 2025-05-06 15:24:04 +02:00
William Martin
4967a5edd5
Merge pull request #10911 from cli/wm/projectsv1-deprecation-pr-web 
Feature detect v1 projects on web mode pr create
 2025-05-06 14:19:15 +02:00
Meredith Lancaster
e4ef9bcedd
Merge branch 'trunk' into move-predicate-type-filtering 2025-05-05 14:34:00 -06:00
Kynan Ware
7b86830ade
Merge pull request #10729 from nopcoder/trunk 
Fix panic on `gh pr view 0`
 2025-05-02 09:47:48 -06:00
William Martin
1a5b7ca60c Feature detect v1 projects for preview URL 
As far as I can see, when there is project metadata, the preview option
will never be shown in the interactive multiselect, so I don't believe
this change has any functional difference. However, I did use the
opportunity to drive out tests for generateCompareURL
 2025-05-02 17:42:23 +02:00
William Martin
5a3aee056a Feature detect v1 projects on interactive pr create 2025-05-02 17:42:23 +02:00
William Martin
9822bb5d07 Feature detect v1 projects on web mode pr create 2025-05-02 15:11:04 +02:00
William Martin
e995a873cb Feature detect v1 projects on non-interactive pr create 2025-05-02 15:08:34 +02:00
William Martin
c5d8e6f8f5
Merge pull request #10821 from cli/wm/projectsv1-deprecation-pr-view 
Feature detect v1 projects on pr view
 2025-05-02 15:07:40 +02:00
William Martin
64370ce73e Cleanup run command stubbed finders in tests 2025-05-02 14:48:52 +02:00
Babak K. Shandiz
284880c21e
Fix StatusJSONResponse usage (#10810) 
* Fix `StatusJSONResponse` usage

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Replace `assert` with `require`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Improve assertion against errors

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Add `JSONErrorResponse` helper func

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `httpmock.JSONErrorResponse`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Replace `StatusJSONResponse` to `JSONErrorResponse` for better readibility

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix improper use of `StatsJSONResponse`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-05-01 20:22:43 +01:00
Barak Amar
232c024987
Merge branch 'trunk' into trunk 2025-05-01 22:16:55 +03:00
William Martin
3bcf9758ad Feature detect v1 projects on pr view 2025-05-01 15:31:36 +02:00
Sinan Sonmez (Chaush)
0a1e7a1fdc
Add --delete-last option to pr comment and issue comment (#10596) 
* deletion for issues with confirmation flag

* add handling for interaction case

* finish implementation for issues

* finish the implementation for issues

* finalize the implementation for PR

* fix missing --yes flag for PR

* address PR comments related to feedbacks

* improve CommentablePreRun for pre checks

* improve confirmation prompt and truncate long comment body

* address PR comments on tests

* Truncate comment for confirmation prompt

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Improve test case descriptions

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix mock comment body

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Remove irrelevant prompt stub

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `opts.Interactive` as TTY indicator

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Fix expected `Interactive` value

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Polish `TestNewCmdComment`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
 2025-05-01 14:12:55 +01:00
Meredith Lancaster
050c68c13b
Merge branch 'trunk' into move-predicate-type-filtering 2025-04-30 14:14:42 -06:00
Andy Feller
c20a4a2ae9
Merge pull request #10890 from cli/andyfeller/gh-accessibility-help-topic 
Introduce `gh accessibility` help topic highlighting GitHub CLI accessibility experiences
 2025-04-30 15:40:27 -04:00
Andy Feller
830335d920 PR feedback 2025-04-30 15:05:07 -04:00
Andy Feller
c20138d844
Update pkg/cmd/accessibility/accessibility.go 2025-04-30 14:35:35 -04:00
Andy Feller
2fd1a45a81
Update pkg/cmd/accessibility/accessibility.go 2025-04-30 14:21:02 -04:00
Andy Feller
096106a3d7
Apply suggestions from code review 
Co-authored-by: Melissa Xie <mxie@users.noreply.github.com>
 2025-04-30 14:20:16 -04:00
Barak Amar
a491578751
Merge branch 'trunk' into trunk 2025-04-29 14:33:21 +03:00
Barak Amar
692bdaf578 Apply code review changes 2025-04-29 14:32:51 +03:00
Azeem Sajid
9ed733fa5e
Add closingIssuesReferences JSON field to pr view (#10544) 
* [gh pr view] Support `closingIssuesReferences` JSON field

* Support pagination

* Support pagination

* Fix typo

* Add more fields
 2025-04-29 11:48:20 +01:00
Andy Feller
d7e2468286 Update a11y text based on draft feedback 2025-04-28 15:01:15 -04:00
Barak Amar
afba7b9e8b
Merge branch 'trunk' into trunk 2025-04-28 18:17:36 +03:00
William Martin
fb97b3efaa
Fix pr create when push.default tracking and no merge ref (#10863) 
* Fix pr create when push.default tracking and no merge ref

* Update pkg/cmd/pr/shared/find_refs_resolution.go

---------

Co-authored-by: Tyler McGoffin <jtmcg@github.com>
 2025-04-24 16:41:14 +00:00
Meredith Lancaster
fcd23dc657 create fetcher with custom http client and retry options 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-24 08:55:57 -06:00
Andy Feller
274a09bbc9 Initial gh accessibility command draft 
This commit captures the initial command along with functionality and description.

There is an internal discussion about the appropriate place for some of this content.
 2025-04-23 10:11:51 -04:00
Kynan Ware
5316f052d8 Merge branch 'trunk' into kw/accessible-prompter-and-disable-spinners-config 2025-04-23 07:30:54 -06:00
Kynan Ware
41f94502e3
Merge pull request #10817 from cli/kw/project-query-uses-iostreams-progress-indicator 
Fix: `project` commands use shared progress indicator
 2025-04-23 07:15:54 -06:00
William Martin
bdc0886492
Merge pull request #10819 from cli/wm/projectsv1-deprecation-issue-edit 
Feature detect v1 projects on issue edit
 2025-04-23 14:18:31 +02:00
William Martin
1a15212e4a
Merge pull request #10818 from cli/wm/projectsv1-deprecation-issue-create-web 
Feature detect v1 projects on web mode issue create
 2025-04-23 14:14:43 +02:00
William Martin
2f06fafd1b
Merge pull request #10815 from cli/wm-kw/projectsv1-deprecation-issue-create 
Feature detect v1 projects on non web-mode `issue create`
 2025-04-23 13:31:24 +02:00
Kynan Ware
138bccd437 feat(config): add accessible prompter and spinner 2025-04-22 16:50:58 -06:00
William Martin
636453059c
Merge pull request #10813 from cli/wm-kw/projectsv1-deprecation-issue-view 
Feature detect v1 projects on `issue view`
 2025-04-22 17:15:13 +02:00
Barak Amar
66527cf75c
Merge branch 'trunk' into trunk 2025-04-22 09:05:38 -04:00
William Martin
3fc362b279
Merge pull request #10811 from cli/wm/issue-pr-base-repo-resolution 
Issue commands should parse args early
 2025-04-22 15:02:14 +02:00
Barak Amar
36f0bf6b8b
Merge branch 'trunk' into trunk 2025-04-22 03:32:00 -04:00
Andy Feller
f61961907e Update configuration support for accessible colors 
- added support for `accessible_colors` configuration setting in `gh config` commandset
- updated default configuration file to contain `accessible_colors: disabled`
- add `GH_ACCESSIBLE_COLORS` env var to `gh environment`
- generated mocks via `go generate ./...` including previously missed prompter changes
 2025-04-17 15:57:49 -04:00
William Martin
0aa49b7741 Feature detect v1 projects on issue edit 2025-04-17 21:19:41 +02:00
William Martin
c208b1f075 Feature detect v1 projects on web mode issue create 2025-04-17 21:04:08 +02:00
Kynan Ware
c08425aef1 fix(projects): use iostreams progress indicator 2025-04-17 11:06:27 -06:00
William Martin
c8dd61d837 Feature detect v1 projects on non-interactive issue create 2025-04-17 17:51:38 +02:00
Barak Amar
a1f5d42283 Update the test code to align with latest changes 2025-04-17 17:13:28 +03:00
Barak Amar
265139f268
Merge branch 'trunk' into trunk 2025-04-17 09:56:12 -04:00