STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11279 commits 87 branches 0 tags 160 MiB
Commit graph

5446 commits

Author SHA1 Message Date
Andy Feller
addbc6ac5c Add label color env var to help topic, unused fix 
This commit adds the new environment variable to the `gh environment` help topic.

Additionally, there is a small fix for Go linter for an unused variable raised as a problem.
 2025-04-04 11:02:44 -04:00
Andy Feller
e9a12853cb Merge branch 'trunk' into andyfeler/colorize-label-optin 2025-04-04 09:47:41 -04:00
Barak Amar
06d22d96c0 handle find pr number 0 2025-04-04 11:14:02 +03:00
Meredith Lancaster
579fae19c9
Merge branch 'trunk' into move-predicate-type-filtering 2025-04-03 11:20:21 -06:00
Meredith Lancaster
69507282d2 restore deleted file 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-03 11:07:06 -06:00
Meredith Lancaster
164a56cb66 move filterAttestations function 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-03 11:02:45 -06:00
Andy Feller
3eca268a7f Introduce color_labels support, update commands 
This commit implements the actual changes around configuration setting / environment variable logic for displaying labels using their RGB hex color code in terminals with truecolor support.

One of the subtler changes in this commit is renaming generic ColorScheme.HexToRGB logic to render truecolor to ColorScheme.Label as this feature was being used exclusively for labels.  This is due to confusion about introducing the new `color_labels` config on top of generic coloring logic.
 2025-04-02 18:24:20 -04:00
Andy Feller
b52c131d4c
Merge pull request #10709 from cli/andyfeller/table-datetime-contrast-github-cli-832 
Ensure table datetime columns have thematic, customizable muted text
 2025-04-02 17:20:15 -04:00
Meredith Lancaster
56d924d25b getAttestations unit tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-01 12:58:37 -06:00
Meredith Lancaster
13dafefcb5 add missing nil struct checks and udpate error messages 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-01 11:23:25 -06:00
Meredith Lancaster
cdfb1b7279 Merge branch 'move-predicate-type-filtering' of github.com:malancas/cli into move-predicate-type-filtering 2025-04-01 11:16:05 -06:00
Meredith Lancaster
05d9156a99 add check for nil api client 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-01 11:16:00 -06:00
Meredith Lancaster
a04be55092
Merge branch 'trunk' into move-predicate-type-filtering 2025-04-01 10:48:13 -06:00
Andy Feller
3c38cedaf3 Implement tests for muted logic, standardize reset 
This commit covers testing around the new ColorScheme.Muted logic based on various situations to gain confidence we get the accessible colors expected when enabled.

Additionally, this commit includes a small change to the existing 8-bit color logic to standardize on the same reset sequence for testing purposes.  Essentially, `ESC[m` and `ESC[0m` are equivalent but this inconsistency with our other libraries makes setting up tests a little extra confusing and difficult.
 2025-03-31 15:33:52 -04:00
Phill MV
0dd9f47159
Merge pull request #10685 from cli/phillmv/document-gh-at-verify-output 
Improve `gh at verify --help`, document json output
 2025-03-31 15:26:25 -04:00
Andy Feller
d2cd14b4cd Remove out of scope changes, update list commands 
After discussing this with the team, the `gh config` changes to display `accessible_colors` have been removed from this branch being outside of acceptance criteria.  This will be moved to a separate issue along with any other work needed to finalize the public preview such as `gh help` entries for `GH_ACCESSIBLE_COLORS` environment variable.

List commands that use ColorScheme.Gray have been updated to use ColorScheme.Muted.
 2025-03-31 11:58:30 -04:00
Andy Feller
346fab212b Accessible color config boilerplate, colors update 
This commit is focused on incorporating cli/go-gh accessible colors configuration setting into GitHub CLI experience along with new color function to supersede ColorScheme.Gray and ColorScheme.Grayf.

Originally, I was considering having all use of ColorScheme.Gray and ColorScheme.Grayf fallback to the new muted logic if accessible colors were enabled, however I decided not being that it exceeds the acceptance criteria.  This means that every command using ColorScheme.Gray needs to be updated to use ColorScheme.Muted
 2025-03-31 11:19:51 -04:00
Phill MV
0427f26884
Update pkg/cmd/attestation/verify/verify.go 
Co-authored-by: Meredith Lancaster <malancas@users.noreply.github.com>
 2025-03-31 11:05:23 -04:00
Kynan Ware
e30244686c
Merge pull request #10680 from cli/kw/update-go-gh-and-document-sprig-funcs 
Update go-gh and document available sprig funcs
 2025-03-28 12:22:14 -06:00
Kynan Ware
aac43870d4 test(release view): fix indentation 2025-03-28 12:11:57 -06:00
Kynan Ware
c6b4da8f20 doc(formatting): add line breaks for readability 2025-03-28 12:00:06 -06:00
Andy Feller
77ae842eb0
Merge pull request #10649 from cli/andyfeller/table-headers-contrast-github-cli-831 
Ensure table headers are thematically contrasting
 2025-03-28 13:30:49 -04:00
Kynan Ware
89def92f04 doc(formatting): update sprig func descriptions 2025-03-28 09:58:48 -06:00
Kynan Ware
c1fbc2f05b test(many): fix whitespace in tests expectations 
Due to https://github.com/charmbracelet/glamour/pull/334, the margin
used for markdown rendering has changed by a couple spaces. This
corrects the relevant tests to accomodate that change.
 2025-03-27 14:21:13 -06:00
Kynan Ware
0750750f7c
Merge pull request #10660 from cli/kw/fix-run-list-with-org-required-workflows 
`run list`: do not fail on ruleset imposed workflows
 2025-03-27 13:36:29 -06:00
Phill MV
f099a54243 updated test 2025-03-27 09:57:00 -04:00
Phill MV
9c9b158d12 added minor caveat 2025-03-27 09:55:14 -04:00
Phill MV
33ab0b8f3b Tweaked language a bit, improved error message. 2025-03-27 09:47:11 -04:00
Phill MV
321e5687a6 Rewrote the gh at verify --help text to a) clarify and b) document the verificationResult object. 2025-03-26 17:40:35 -04:00
Kynan Ware
229216e830 doc(run shared): clarify 404 handling 2025-03-26 15:29:20 -06:00
Kynan Ware
49588555c3
Merge branch 'trunk' into kw/update-go-gh-and-document-sprig-funcs 2025-03-26 12:38:10 -06:00
Andy Feller
86ad62a62d Fixes #10590 
Implement missing safeguard causing `gh alias delete` tests to wipe out tester's GitHub CLI configuration.
 2025-03-26 13:42:39 -04:00
Kynan Ware
ffd42ea256 docs: add Sprig library functions to help topics 2025-03-26 10:21:41 -06:00
Andy Feller
79f1b07fb1 Implement and fix tests for table headers 2025-03-25 15:29:05 -04:00
Meredith Lancaster
166e211e2b clean up test fixtures 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-25 08:28:33 -06:00
Meredith Lancaster
e3fbe9008f reduce test duplication 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-25 08:25:00 -06:00
Meredith Lancaster
d1c4bf7dd9 comment 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-25 08:24:52 -06:00
Meredith Lancaster
baeaf66011 restructure api client methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 19:13:27 -06:00
Meredith Lancaster
0d0654738b simplify client methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:58:35 -06:00
Meredith Lancaster
a856a796f0 remove duplicate predicate filtering code 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:34:54 -06:00
Meredith Lancaster
a9cc7b481e create single fetch by digest client method 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:28:27 -06:00
Meredith Lancaster
5a895b9d72 dedpulicate if else logic 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:12:41 -06:00
Meredith Lancaster
95a61974bf pass params object to api client methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 18:01:57 -06:00
Meredith Lancaster
ad20ef35d9 move local and oci registry attestation filtering 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 17:35:52 -06:00
Meredith Lancaster
cbe80fd169 Merge branch 'trunk' into move-predicate-type-filtering 2025-03-24 17:29:24 -06:00
Meredith Lancaster
faef81f4bc reorganize getAttestations func to check for remote gh api fetching first 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 17:28:50 -06:00
Meredith Lancaster
a78c06970a pass predicate type to get attestation api methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-03-24 17:28:00 -06:00
Kynan Ware
c6f574ccb1
test(run list): update rulesets test name 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-03-24 14:14:50 -06:00
Kynan Ware
30960d59bc
doc(run list): add enterprise ruleset notes 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-03-24 14:04:16 -06:00
Kynan Ware
a35ae3b8bb refactor(tests): update test name for org workflows 2025-03-24 12:54:47 -06:00