nilvng
c6c27113fe
issue #2329 : add happy path unit test
2024-11-17 16:36:10 +11:00
nilvng
1832c1a767
issue #2329 : fix the linting issue
2024-11-17 14:58:38 +11:00
nilvng
4386fcb4e5
issue #2329 : fix the unit tests issue - ensure its backward compatible
2024-11-17 14:57:48 +11:00
Nillin
49b10b745d
Merge branch 'trunk' into nil/fix-2329
2024-11-17 13:47:29 +11:00
bagtoad
68f3ef79ca
Handle missing "workflow" scope in createRelease
2024-11-16 19:32:37 -07:00
Kynan Ware
04e2a5dd63
Merge branch 'trunk' into 9904-gh-repo-create-to-work-on-bare-repos
2024-11-15 11:56:31 -07:00
Meredith Lancaster
a56ff4a0eb
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-14 10:29:24 -07:00
Meredith Lancaster
91577594de
formatting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-14 10:20:48 -07:00
Andy Feller
b8ef951de1
Shorten extension release checking from 3s to 1s
...
Addressing feedback from extension author demonstration about a noticable pause waiting for extension execution to complete due to amount of time waiting on channel.
2024-11-13 13:04:01 -05:00
William Martin
7bcb063391
Modify push prompt on repo create when bare
2024-11-11 16:17:06 +01:00
William Martin
8e63268aba
Doc push behaviour for bare repo create
2024-11-11 16:10:32 +01:00
William Martin
e3665955a5
Push --mirror on bare repo create
2024-11-11 16:09:03 +01:00
William Martin
2efb9935db
Doc isLocalRepo and git.Client IsLocalRepo differences
2024-11-11 14:18:26 +01:00
William Martin
f515e9c1e7
Use errWithExitCode interface in repo create isLocalRepo
2024-11-11 14:17:29 +01:00
William Martin
bc85e11d05
Backfill repo creation failure tests
2024-11-11 14:11:16 +01:00
William Martin
4a7f2e57b0
Support bare repo creation
2024-11-11 13:57:05 +01:00
Meredith Lancaster
43e5abbcd8
use logger println method
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 15:50:46 -07:00
Tyler McGoffin
9b9e654c76
Merge pull request #9866 from andyfeller/andyfeller/cli-cli-8183
...
Check extension for latest version when executed
2024-11-07 14:48:12 -08:00
Andy Feller
3ec657d087
Enhance extension upgrade tests for URL
2024-11-07 17:35:59 -05:00
Meredith Lancaster
e4cd729a7b
simplify verifyCertExtensions
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 14:59:21 -07:00
Meredith Lancaster
8ab5f247af
rename type
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 14:47:53 -07:00
Meredith Lancaster
ff9b6bb883
refactor fetch attestations funcs
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 14:39:11 -07:00
Meredith Lancaster
c7e4411a88
print policy information before verifying
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 13:16:13 -07:00
Meredith Lancaster
07e9a4a19d
add initial policy info method
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 11:08:58 -07:00
Meredith Lancaster
6d4c74b252
Merge pull request #9856 from malancas/verify-attestation-monotonic-tests
2024-11-07 07:45:25 -07:00
Andy Feller
ddf7287ab8
Test extension command update behaviors
...
This commit expands upon the previous work by creating tests around extension command execution and how various extension update scenarios are handled.
Along the way, the logic handling formatting update messaging has been switched to use `ColorScheme` in order to honor color behavior flags.
2024-11-06 22:49:02 -05:00
Tyler McGoffin
667f90ad51
Merge branch 'trunk' into nil/fix-7804
2024-11-06 15:25:07 -08:00
nilvng
2eaab56912
chore: tidy up
2024-11-07 10:20:23 +11:00
nilvng
874fa7ad4d
feat: add test
2024-11-07 10:20:23 +11:00
nilvng
a780b488a3
fix: ignore template flag
2024-11-07 10:20:23 +11:00
Andy Feller
e356c69a6f
Merge pull request #9881 from cli/cmbrose/cs-config-autokey
...
Create the automatic key when specified with -i
2024-11-06 16:24:43 -05:00
Caleb Brose
509a181d79
Remove unimplemented tests
2024-11-06 19:10:28 +00:00
William Martin
0f85e4e0e0
Merge pull request #9883 from cli/9882-gh-cache-list-json-should-return-when-no-caches-exist-instead-of-text-message
...
Print empty array for `gh cache list` when `--json` is provided
2024-11-06 18:18:44 +01:00
Meredith Lancaster
0665fb4916
comments
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-06 09:45:42 -07:00
Meredith Lancaster
b65c942e1f
update verification slice building
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-06 09:45:03 -07:00
Meredith Lancaster
eae3b5baec
Merge branch 'trunk' into verify-attestation-monotonic-tests
2024-11-06 09:41:33 -07:00
Caleb Brose
940560acf2
Fix ssh directory
2024-11-06 16:13:29 +00:00
Meredith Lancaster
ffc499110d
Merge branch 'trunk' into verify-attestation-monotonic-tests
2024-11-06 08:08:40 -07:00
Meredith Lancaster
f376ac1a2c
Merge branch 'trunk' into simplify-sigstore-verify-result-handling
2024-11-06 07:59:23 -07:00
Meredith Lancaster
bfd140c0e5
initial pass at fetching bundles with sas urls
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-06 07:57:18 -07:00
Meredith Lancaster
446a0d5885
Merge pull request #9848 from malancas/attestation-refactor-policy
2024-11-06 07:50:25 -07:00
William Martin
a569d1030d
Export empty results for cache list
2024-11-06 13:02:14 +01:00
Caleb Brose
b4c221dfb7
Create the automatic key when specified with -i
2024-11-05 22:30:15 +00:00
Aarni Koskela
1c4c8e5145
Fix verbiage for deleting workflow runs
...
It's not deleting _workflows_ (which are specified in YAML)...
2024-11-04 17:55:35 +02:00
Meredith Lancaster
b9c9f0acc2
move comment
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-04 07:35:42 -07:00
Meredith Lancaster
3281bd457c
simplify logic, add comments
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-04 07:32:10 -07:00
nilvng
7d7c240f4b
feat: let user select pr to checkout
2024-11-03 11:38:58 +11:00
Andrew Feller
47d77bd51b
Add version checking when executing extensions
...
Building on logic from the `gh ext list` for retrieving and assessing extension release information, this commit enhances the logic around invoking extensions to check for new releases.
Using the same user experience from checking `gh` version, this should only output information when the extension is used and gives the user information on how to upgrade depending on the type of extension and whether it is pinned or not.
```shell
andrewfeller@Andrews-MacBook-Pro cli % gh ext install dlvhdr/gh-dash --pin v4.6.0
✓ Installed extension dlvhdr/gh-dash
✓ Pinned extension at v4.6.0
andrewfeller@Andrews-MacBook-Pro cli % ./bin/gh dash
A new release of dash is available: 4.6.0 → 4.7.0
To upgrade, run: gh extension upgrade dash --force
https://github.com/dlvhdr/gh-dash
```
2024-11-02 13:14:05 -04:00
Meredith Lancaster
91967cced8
Update pkg/cmd/attestation/verify/verify.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-01 09:51:05 -06:00
Meredith Lancaster
43810a5fc3
use predicate type stored in enforcementCriteria
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-01 09:17:47 -06:00
