David Gardiner
20273d1f17
Move create codespace permission opt out behind else to fix token permissions
2024-01-12 12:16:38 -08:00
ihmpavel
72b6dc5d8c
chore: Unify calling gh in examples ( #8560 )
2024-01-11 09:07:23 -08:00
Zack Sloane
1b58b7d7f1
Merge branch 'trunk' into trunk
2024-01-11 09:51:22 -05:00
Andy Feller
e9fabfe9a9
Merge pull request #8479 from muzimuzhi/docs/backquote-gh-config
...
Backquote settings in `gh-config` docs
2024-01-10 08:18:25 -05:00
Sam Coe
785a340f78
Prevent downloading releases with assets that match windows reserved filenames ( #8517 )
...
* Prevent downloading releases with assets that match windows reserved filenames
* Add comment noting potential use of build constraints in the future
2024-01-09 09:53:57 -08:00
Heath Stewart
0cf5d22ead
Support template, jq flags with standard format flag ( #7832 )
...
* Use standard JSON flags for project command
Deprecates the --format flag and adds the standard JSON flags to properly filter, template, and write JSON.
* Add format flags cmdutil
Resolves PR feedback
* Remove unnecessary fields from JSON format flags
* Add standard format help to remaining commands
* Add JSON format regression tests
Also fixed a number of `project` commands that didn't format the right object as JSON.
* Resolve PR feedback
2024-01-09 09:46:39 -08:00
Zack Sloane
b6dadfa7fb
test update, more consistent default value display
2024-01-08 23:23:24 -05:00
Yukai Chou
c73f41b32e
Mark-up gh-config settings with backticks
2024-01-08 02:05:40 +08:00
Andy Feller
586eb8b865
Merge pull request #8453 from samueldurantes/samueldurantes/browse-help-message
...
Add more help message to browse command
2024-01-05 10:19:51 -05:00
Samuel Durante
109458cf66
Update pkg/cmd/browse/browse.go
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-01-05 10:53:15 -04:00
EBIBO
be81f9f0cb
Merge branch 'trunk' into cli-8009
2023-12-13 12:56:26 -05:00
benebsiny
0b73f2af86
Verify the downloaded zip for gh run view --log
2023-12-14 01:54:16 +08:00
William Martin
a9bdd8d186
Fix flaky tests coupled to relative dates
2023-12-13 14:44:16 +01:00
Samuel Durante
ab7e55e20a
Add more help message to browse command
2023-12-12 20:36:40 -03:00
Sam Coe
52fb3b62b3
Update multi-account migration error msg ( #8448 )
...
* Make sure default host is stubbed out for all auth login tests
* Improve multi-account migration error message
2023-12-11 15:20:23 +00:00
Andy Feller
b442a1b4d2
Fix run exported jobs error for completedAt
2023-12-11 08:42:43 -05:00
William Martin
b281269052
Fix affect effect typo in login cmd
2023-12-07 15:03:26 +01:00
Sam Coe
94de5290e0
Auth switch special case one host with two users to avoid unnecessary prompting
2023-12-07 09:44:07 -04:00
William Martin
0763c1d4a7
Locally prevent mixup of username and token in refresh
2023-12-07 11:43:05 +01:00
William Martin
16cfe5f21a
Fix token username return ordering in auth refresh
2023-12-07 11:35:02 +01:00
Sam Coe
fd7dc25e2a
Add error to auth refresh when active user does not match newly authenticated token user
2023-12-06 16:51:48 -04:00
Sam Coe
80fc413592
Polish auth status timeout error message
2023-12-06 14:06:28 +01:00
Sam Coe
024cb939af
Rename authCfg.Token to authCfg.ActiveToken and authCfg.SetToken to authCfg.SetActiveToken
2023-12-06 14:06:28 +01:00
Sam Coe
1a3392a379
Rename authCfg.User to authCfg.ActiveUser
2023-12-06 14:06:28 +01:00
Sam Coe
8cdbc1a8ca
Refactor authCfg.UsersForHost to not return an error
2023-12-06 14:06:28 +01:00
Sam Coe
92a902e453
Add context to auth token command error message
2023-12-06 14:06:28 +01:00
William Martin
af8bcd3ed2
Print useful error when switch fails outside user control
2023-12-06 14:06:28 +01:00
William Martin
dbff555835
Update auth token short and long
2023-12-06 14:06:28 +01:00
William Martin
2c72647cf7
Update git protocol login prompt to indicate it is host level
2023-12-06 14:06:28 +01:00
William Martin
4e04b98f6f
Add user flag to auth token command
2023-12-06 14:06:28 +01:00
William Martin
ecfb226d5d
Fix linting errors
2023-12-06 14:06:28 +01:00
William Martin
ab5103f061
Don't set user level git protocol and don't switch
2023-12-06 14:06:28 +01:00
William Martin
08c659bdf8
Document that git protocol during login is host level
2023-12-06 14:06:28 +01:00
Sam Coe
587007a562
Additional auth status tests
2023-12-06 14:06:28 +01:00
William Martin
15ba536317
Ensure subtests use the right t during setup
2023-12-06 14:06:28 +01:00
William Martin
c165d5ccc0
Use isolated config in logout cmd tests
2023-12-06 14:06:28 +01:00
William Martin
c9a6b7cc00
Always mock the keyring in NewIsolatedTestConfig
2023-12-06 14:06:28 +01:00
William Martin
0a7871c6d3
Use real config in setupgit cmd tests
2023-12-06 14:06:28 +01:00
William Martin
20dd95b88d
Use real config in token cmd tests
2023-12-06 14:06:28 +01:00
William Martin
748d59ec64
Use real config in auth refresh tests
2023-12-06 14:06:28 +01:00
William Martin
dc0f6d55e2
Use real config in fork cmd tests
2023-12-06 14:06:28 +01:00
William Martin
5b3e7290be
Use real config and env in login cmd tests
2023-12-06 14:06:28 +01:00
Sam Coe
e806664ef7
New UX for auth status
2023-12-06 14:06:28 +01:00
Sam Coe
760dc91faa
Include environment variable users in auth status output
2023-12-06 14:06:28 +01:00
William Martin
b2997cc7bd
Handle multi account golden path in auth status
2023-12-06 14:06:28 +01:00
William Martin
e4ed4041cd
Use auth config and only print stdout in status
2023-12-06 14:06:28 +01:00
William Martin
5d10beb60a
Use config to look up user for status
2023-12-06 14:06:28 +01:00
William Martin
08c7bd1df2
Use real config and login in status tests
2023-12-06 14:06:28 +01:00
Sam Coe
eca5f72328
UX polish and standardization of language
2023-12-06 14:06:28 +01:00
William Martin
98381e63c9
Refactor switch test to be more structural
2023-12-06 14:06:28 +01:00