Commit graph

5446 commits

Author SHA1 Message Date
Babak K. Shandiz
897c2b12b4
fix(agent-task view): disable PR finder progress indicator
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-17 11:50:08 +01:00
Babak K. Shandiz
1f5cbc5dff
test(pr/shared): assert FindOptions.DisableProgress is respected
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-17 11:47:49 +01:00
Babak K. Shandiz
5b9d6ae3fc
fix(pr/shared): add DisableProgress field to FindOptions
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-17 11:47:18 +01:00
Kynan Ware
b3401ffd74 Refactor stripDiffFormat guard clause logic
Rearranged the guard clause in stripDiffFormat to return early if no hunk header is found, improving code clarity and reducing nesting.
2025-09-16 17:46:43 -06:00
Kynan Ware
c0a2648436 Use filepath.Ext to detect file extension in markdown renderer
Replaces manual string splitting with filepath.Ext for determining the file extension in renderFileContentAsMarkdown. This improves accuracy, especially for files with multiple dots in their names.
2025-09-16 17:34:57 -06:00
Kynan Ware
65b45adbd8 Improve log rendering error handling and test coverage
Refactors log rendering to print errors to stderr and continue processing on JSON parse or rendering failures, instead of returning early. Updates tests to check both stdout and stderr outputs, and adds new test cases and testdata for tolerant parsing and error scenarios.
2025-09-16 17:21:01 -06:00
Benjamin Levesque
914531e6f1
fixup! examples 2025-09-16 23:07:11 +02:00
Benjamin Levesque
4449af614c
fix error missing in json output 2025-09-16 23:00:41 +02:00
Benjamin Levesque
5bb76e832b
examples 2025-09-16 22:00:07 +02:00
Benjamin Levesque
3cdd359987
remove showToken from authEntry 2025-09-16 21:57:28 +02:00
Kynan Ware
97d3253aaf Prefix rendered shell commands with '$ ' in logs
Shell commands in log output are now prefixed with '$ ' for improved readability and consistency with common shell output conventions. Updated related test data and test helper comments to reflect this change.
2025-09-16 11:58:58 -06:00
Kynan Ware
d636f4c213 Clarify comment on CRLF normalization in tests
Updated comments in log_test.go to clarify that CRLF is normalized to LF for OS-agnostic test behavior, improving code readability.
2025-09-16 11:47:48 -06:00
Kynan Ware
37d8e0a438 Refactor generic tool call titles map to package scope
Moved the genericToolCallNamesToTitles map from inside the renderGenericToolCall function to a package-level variable for improved readability and potential reuse. This change also updates the function signature order for consistency.
2025-09-16 11:46:16 -06:00
Kynan Ware
4d9038ad31 Add pager support to log output in printLogs
Introduces use of a pager for log output in the printLogs function. If the pager fails to start, an error message is printed to stderr. This improves log readability for long outputs.
2025-09-16 11:26:55 -06:00
Babak K. Shandiz
dab285c61a
test(agent-task create): add test for --follow
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-16 13:27:39 +01:00
Babak K. Shandiz
f5ed563a42
docs(agent-task create): add example for --follow flag
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-16 13:18:26 +01:00
Babak K. Shandiz
4f7d577b97
feat(agent-task create): add --follow flag
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-16 13:18:09 +01:00
Babak K. Shandiz
134ae31fea
refactor(agent-task create): extract session URL polling into a func
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-16 13:07:01 +01:00
Kynan Ware
f779a3d16c Add TODO for bash-related tool call details
Inserted a TODO comment to consider including more details for bash-related tool calls in the log rendering function.
2025-09-15 14:23:12 -06:00
Kynan Ware
77509fcfb3 Update comment for reasoning text formatting
Clarifies that reasoning text should be formatted as a normal 'thought' message without a heading, improving code documentation.
2025-09-15 14:19:31 -06:00
Kynan Ware
887e842717 Enable Bash session tool handling in log rendering
Uncomments and activates support for Bash session tool calls (write_bash, read_bash, stop_bash, async_bash, read_async_bash, stop_async_bash) in the renderLogEntry function. Also defines the corresponding argument structs, enabling proper handling and display of these tool calls in the log output.
2025-09-15 14:18:42 -06:00
Kynan Ware
2c68168611 Rename testdata log files for clarity
Renamed sample log input and expected output files in testdata to use a consistent 'log-*-input.txt' and 'log-*-want.txt' naming scheme. Updated references in log_test.go to match the new file names for improved clarity and maintainability.
2025-09-15 13:52:14 -06:00
Kynan Ware
f33ef4227a Normalize line endings in log testdata files too 2025-09-15 13:43:12 -06:00
Kynan Ware
62d7a7541a Fix line ending conversion in tests 2025-09-15 13:41:19 -06:00
Kynan Ware
87d8d835f7 Add note for updating testdata files in log tests
A comment was added to TestFollow with instructions on how to update the .want testdata files when test outputs change. This helps maintainers regenerate expected output files more easily.
2025-09-15 13:36:35 -06:00
Kynan Ware
0b5a0491ca Make log tests OS-agnostic by normalizing line endings
Updated TestFollow to normalize line endings in test log files, ensuring consistent behavior across different operating systems, especially Windows.
2025-09-15 13:27:01 -06:00
Kynan Ware
ab796c80ef Fix comment for GetSessionLogs method 2025-09-15 13:07:00 -06:00
Kynan Ware
e5e7bc8ad6 Add and improve function documentation in log.go
Added and expanded Go doc comments for multiple functions in pkg/cmd/agent-task/shared/log.go to clarify their purpose and usage. Also refactored renderToolCallTitle and related logic for improved naming consistency and robustness.
2025-09-15 13:05:47 -06:00
Kynan Ware
6bbb5c43c5 Update log test expectation files 2025-09-15 12:46:08 -06:00
Kynan Ware
282a25f466 Rename renderToolCall to renderToolCallTitle
Refactors the function renderToolCall to renderToolCallTitle and updates all its usages for clarity. This improves function naming to better reflect its purpose of rendering tool call titles.
2025-09-15 12:41:46 -06:00
Kynan Ware
3829cff8da Rename relativePath to relativeFilePath in log rendering
Refactored the function name from relativePath to relativeFilePath for clarity and updated all usages accordingly in log rendering functions. Also improved comments in stripDiffFormat for better context.
2025-09-15 12:41:17 -06:00
Kynan Ware
718c462454 Refactor markdown rendering helper function names
Renamed renderMarkdownWithPadding to renderMarkdownWithFormat and related variables for clarity. Updated comments and TODOs for better context on GUI support and code behavior.
2025-09-15 12:34:44 -06:00
Kynan Ware
ec3fce0dfb Improve log rendering and tool call handling
Enhances log rendering by stripping diff formatting from viewed file content and improving JSON rendering with optional labels. Expands the list of recognized tool calls with descriptive titles, especially for Playwright and GitHub MCP server tools. Refactors related helper functions for clarity and robustness.
2025-09-15 10:13:55 -06:00
Kynan Ware
9e16a82e5e Refactor JSON content rendering in log entries
Extracted JSON content rendering into a new helper function renderContentAsJSONMarkdown for reuse. Updated 'report_progress' and 'create' tool call handling to use this helper, improving code clarity and reducing duplication. Also added support for rendering PR descriptions in 'report_progress' tool calls.
2025-09-15 10:13:55 -06:00
Kynan Ware
0fb10fca7d Various log rendering improvements
Updated the LogRenderer interface and implementations to accept *iostreams.IOStreams instead of *iostreams.ColorScheme, enabling access to terminal theme and width for improved markdown rendering. Refactored related code, tests, and mocks to support this change, and enhanced log rendering to better handle markdown and code output for various tool calls.
2025-09-15 10:13:55 -06:00
Babak K. Shandiz
1155e83070 feat(agent-task view): add --log and --follow flags
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-15 10:13:55 -06:00
Babak K. Shandiz
1ccbb0af83 feat(agent-task view): add --log and --follow flags
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-15 10:13:55 -06:00
Babak K. Shandiz
05e609c5b3 fix(agent-task/shared): add log renderer
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-15 10:13:55 -06:00
Babak K. Shandiz
fbcdeed41f feat(agent-task/capi): add GetSessionLogs method
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-15 10:13:55 -06:00
Benjamin Levesque
e2df8ac1cc
address copilot comment on parameter order 2025-09-13 22:33:27 +02:00
Benjamin Levesque
5ae0410bd2
add examples 2025-09-13 22:25:20 +02:00
Benjamin Levesque
a69f7a6b53
simplify exporter usage 2025-09-13 22:14:59 +02:00
Benjamin Levesque
5abb467e69
remove includeScope 2025-09-13 21:50:06 +02:00
Benjamin Levesque
54bf8432f6
do not mutate opts.ShowToken 2025-09-13 21:35:02 +02:00
Benjamin Levesque
60088e0e7d
move displayToken to String method 2025-09-13 21:30:20 +02:00
Benjamin Levesque
b38e12ef61
move flag validation to RunE 2025-09-13 21:30:19 +02:00
Kynan Ware
48cf448622
Merge pull request #11708 from cli/kw/edit-file-and-prompt-for-confirmation-interactively
`gh agent task create`: Allow interactively editing task description file and add confirmation prompt
2025-09-11 11:44:39 -06:00
Kynan Ware
3831380d13 Add error type assertion to createRun tests
Introduces a new 'wantErrIs' field to test cases in Test_createRun to assert specific error types using require.ErrorIs. This enhances test coverage by verifying not only error messages but also error types.
2025-09-11 11:23:18 -06:00
Kynan Ware
1dbb694790 Add test for non-interactive problem statement input
Adds a test case to ensure that when a problem statement is provided as an argument non-interactively, the command does not prompt or return an error, and the correct job is created.
2025-09-11 09:24:42 -06:00
Kynan Ware
f22dc9271b Update test to use edited task description
Modified the test in create_test.go to return and expect 'edited task description' instead of concatenating the prompt string. This clarifies the test's intent and expected behavior for the MarkdownEditorFunc and CreateJobFunc.
2025-09-11 09:22:27 -06:00