vilmibm
a27a94f8b5
Merge remote-tracking branch 'origin/trunk' into repo-fork-gitflags
2021-01-21 11:58:20 -08:00
Sam
938f6f4bdd
Merge pull request #2809 from cli/deadcode
...
delete unused parameter
2021-01-21 09:56:15 -08:00
Mislav Marohnić
a70b69e359
Bring the "Press Enter" UI closer to the authentication experience
...
- "Press Enter" is both bold
- "Enter" is capitalized
- The prompt ends with "..."
2021-01-21 09:47:38 -08:00
Sam Coe
a26fba7800
Comment on pull requests
2021-01-21 09:47:38 -08:00
Mislav Marohnić
10b1314dc1
Hide ssh-key command until it's ready for prime-time
2021-01-21 17:55:44 +01:00
Mislav Marohnić
ad62d6a471
Merge pull request #2798 from cli/pr-merge-crossrepo
...
Handle case when a cross-repo PR was already merged
2021-01-21 17:36:00 +01:00
Mislav Marohnić
4158209d50
Merge pull request #2811 from cli/utils-spinner-buh-bye
...
Retire utils.Spinner in favor of IOStreams.StartProgressIndicator
2021-01-21 17:34:39 +01:00
vilmibm
509e5dd0c9
fix tests
2021-01-20 16:10:56 -08:00
vilmibm
99c312e8ce
accept a remote name instead of doing magic remote naming in repo fork
2021-01-20 15:32:19 -08:00
vilmibm
03f99a0140
Merge remote-tracking branch 'origin/trunk' into remote-renaming-847
2021-01-20 15:10:20 -08:00
Nate Smith
5430728a0a
Merge pull request #2813 from cli/token-from-env-err
...
More descriptive error when aborting auth due to environment variables
2021-01-20 15:06:52 -08:00
Björn Heinrichs
c9f79271b1
Add --maintainer-edit flag ( #2250 )
...
* Add --maintainer-edit flag
Closes #2213 while retaining backwards compatibility.
* Fix linting
* Adjust documentation and validation
* Negate logic and fix build errors
* rename to no-maintainer-edit
* test
* use a positive option instead of negative
Co-authored-by: vilmibm <vilmibm@github.com>
2021-01-20 14:51:27 -08:00
Sam Coe
b9b1079493
Display reviews when viewing pull requests
2021-01-20 12:15:25 -08:00
Mislav Marohnić
dcf5a27f53
Merge pull request #1862 from edualb/trunk
...
[#1755 ] SSH key management (gh ssh-key list)
2021-01-20 20:47:21 +01:00
Mislav Marohnić
4a2cc8d2a4
Simplify ssh-key list
...
Do not require nor request `read:public_key` scope by default.
2021-01-20 20:23:57 +01:00
edualb
e26a1b98a1
add ssh-key command
2021-01-20 20:23:38 +01:00
Cristian Dominguez
2086d135f3
Respect system/user timezone in API requests ( #2630 )
...
* Respect system/user timezone in API requests
* Fall back to a known timezone if TZ is not set
Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
2021-01-20 10:44:46 -08:00
Mislav Marohnić
c9407b2629
More descriptive error when aborting auth due to environment variables
...
Old message:
read-only token in GH_TOKEN cannot be modified
This message was vague and some users did not understand that this
refers to the value that is read from environment variables.
New message:
$ GH_TOKEN=123 ghd auth login -h github.com
The value of the GH_TOKEN environment variable is being used for authentication.
To have GitHub CLI store credentials instead, first clear the value from the environment.
2021-01-20 18:27:35 +01:00
Mislav Marohnić
a2bee1fad3
🔥 utils.Spinner
2021-01-20 14:48:14 +01:00
Mislav Marohnić
aa0de5f636
Stop using utils.Spinner in repo fork
2021-01-20 14:46:45 +01:00
Peter Kristensen
bc7f733267
Add body argument to pr merge command.
2021-01-20 13:24:27 +01:00
vilmibm
3797aa72ff
delete unused parameter
2021-01-19 19:08:49 -08:00
Karel Coudijzer
a7b9e3916c
Show progress while creating pr
2021-01-19 22:19:10 +01:00
Mislav Marohnić
b5366c6ebf
Merge pull request #2794 from cristiand391/use-testify-assertion
...
Use Testify assertions in tests
2021-01-19 14:08:25 +01:00
Mislav Marohnić
75ebb863e3
Use testify assertions for error matching
2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087
Equal: flip arguments position
2021-01-18 21:00:59 -03:00
Mislav Marohnić
fc77cbc964
Deprecate test.ExpectLines
...
For asserting command output, exact string matches are preferred in most cases. In cases when a pattern match is needed, the test can use regexp ad hoc.
2021-01-18 23:25:45 +01:00
Mislav Marohnić
c308f1cd91
Prevent further use of SetPrepareCmd and InitCmdStubber
2021-01-18 22:44:53 +01:00
Mislav Marohnić
5531498f27
Migrate to new cmd stubber in repo fork tests
2021-01-18 22:42:27 +01:00
Mislav Marohnić
584b33e79c
Migrate to new cmd stubber in repo clone tests
2021-01-18 22:42:13 +01:00
Mislav Marohnić
c63acf6728
Migrate to new cmd stubber in misc. tests
2021-01-18 22:42:01 +01:00
Mislav Marohnić
bf4bc1511f
Migrate to new cmd stubber in merge tests
2021-01-18 20:15:40 +01:00
Mislav Marohnić
683ebee6ef
Consistently use green success icon
...
For operations such as closing an issue or merging a PR, we would
display the success icon (a checkmark) in red and magenta colors,
respectively, to reflect the latest state of the record operated on
(red: closed; magenta: merged).
This was always confusing to me, seeing it both in code and in the UI,
because I'm instinctively thinking that it's a bug and have to remind
myself that it's by design.
2021-01-18 19:57:38 +01:00
Mislav Marohnić
6e5a90821c
pr merge: handle case when a cross-repo PR was already merged
...
In this case, do not ever offer to delete the branch.
2021-01-18 19:49:20 +01:00
Mislav Marohnić
66546e2245
When pr merge --delete-branch flag is supplied, avoid prompting for it
2021-01-18 18:10:20 +01:00
Nilesh Singh
f3fcaf6c9c
Fix error message text & add test case
2021-01-17 14:42:49 +05:30
Cristian Dominguez
3afb1d0b1a
Use Testify assertions in test
2021-01-16 19:19:30 -03:00
Devon Romanko
df31fae9c6
remove prompt for deleting branches on pr merge in interactive mode when -d flag is passed
2021-01-15 17:34:00 -05:00
Devon Romanko
2c35eb04ff
address pr comments
2021-01-15 16:54:46 -05:00
Devon Romanko
85e0e44920
Add prompt to delete local branch when attempting to merge a PR that is already merged
2021-01-15 07:25:24 -05:00
Nilesh Singh
2f5ffbd60a
Add fail message for non-existent hostname
2021-01-15 13:28:57 +05:30
Sam
b0ae09e627
Merge pull request #2535 from cli/create-comments
...
Create issue comments
2021-01-12 11:24:09 -08:00
Cristian Dominguez
ce151420f3
Migrate legacy tests
2021-01-11 21:07:19 -03:00
Sam Coe
723e9e31ba
Address PR comments
2021-01-11 13:56:17 -08:00
Sam Coe
155507d31d
Make comment command easier to test
2021-01-05 15:14:25 -08:00
xhqr
8b5c5896f2
[repo/create] Create local repo dir with non tty. ( #2671 )
...
This addresses issue #2587 .
2021-01-05 14:40:52 -08:00
Sam Coe
1fc8b66b26
Address PR comments
2021-01-05 10:36:03 -08:00
Sam Coe
f862123071
Modify issue commenting to adhere to designs and add tests
2021-01-05 10:35:09 -08:00
Yuki Osaki
338bf1d112
fix linter issue
2021-01-05 10:35:09 -08:00
Yuki Osaki
8ef2bb4d14
Comment on issues from editor
2021-01-05 10:35:09 -08:00
