STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11279 commits 87 branches 0 tags 160 MiB
Commit graph

26 commits

Author SHA1 Message Date
Yukai Chou
d7b8ecf33d Unify use of tab indent in non-test source files 
Found with
    rg '(^ | \t|\t )' -g '*.go' -g '!*_test.go'

Mixed indent exceptions:
- wrapped long list items with extra 2-space indent
- code snippets using space indent
- commented code lines having "\t*// \t+" prefix
 2024-08-03 00:35:30 +08:00
Josh Soref
723daf714e feat: Fallback to notepad on Windows 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
 2022-08-18 17:05:14 -04:00
Mislav Marohnić
5986f88565 issue comment: support quotes and arguments in EDITOR value 
The `issue comment` command would perform a `filepath.Base()` on the
value of EDITOR and use the result for launching the editor, which is
undesireable for both functional and display purposes:

- For functional purposes, always shellsplit the value of GH_EDITOR or
  EDITOR before we shell out to that process;
- For display purposes, extract the basename only after shellsplitting.
 2022-04-29 18:05:39 +02:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
Mislav Marohnić
5d8f4a66a5
Merge pull request #5326 from mgabeler-lee-6rs/issue-5239-less-bom 
Only write UTF-8 BOM on Windows where it is needed
 2022-03-30 18:48:46 +02:00
dependabot[bot]
ad313f77f7
Bump github.com/AlecAivazis/survey/v2 from 2.3.2 to 2.3.4 (#5337) 
Co-authored-by: Mislav Marohnić <mislav@github.com>
 2022-03-24 15:54:40 +01:00
Matthew Gabeler-Lee
be07983a62
Only write UTF-8 BOM on Windows where it is needed 
Fixes #5239
 2022-03-17 11:40:49 -04:00
Tomohiro Nishimura
a9d397be69
Add --generate-notes flag to gh release create command. (#4467) 2021-12-08 15:20:59 +04:00
Mislav Marohnić
1f4bd80c56 Fix test flaky due to race in showing/hiding cursor 
https://github.com/cli/cli/pull/3787/checks?check_run_id=2793254411
 2021-06-14 10:58:53 +02:00
Mislav Marohnić
f570deb118 Add tests for opening the editor program 2021-06-04 21:24:17 +02:00
Mislav Marohnić
bcfe176594 Fix flaky editor test 
There was a race condition wherein the test didn't wait enough time for
the prompt to get rendered before testing the terminal output.
 2021-06-04 20:06:21 +02:00
Mislav Marohnić
c2c691f444 Add test for our survey editor extension 2021-06-03 18:05:43 +02:00
chemotaxis
d974dbd338 Return default text if skipping the text editor when prompted 
If we are allowed to skip the editor _and_ we want to append the default
text to the editor if we'd opened it, we just return the default text.

Co-Authored-By: Mislav Marohnić <mislav@github.com>
 2021-06-03 14:50:13 +02:00
Sam Coe
a26fba7800
Comment on pull requests 2021-01-21 09:47:38 -08:00
Mislav Marohnić
5b4a08dcb9 Ensure that only PATH is searched when shelling out to external commands 
Works around https://github.com/golang/go/issues/38736 for Windows.
 2020-11-11 16:33:13 +01:00
Mislav Marohnić
f7d0988799 Offer different editor modes during release create 2020-08-25 20:20:44 +02:00
vilmibm
7009321314 review feedback 2020-05-11 17:06:18 -05:00
vilmibm
9641eee38a use more clear name 2020-04-22 14:31:09 -05:00
vilmibm
3c8b87c9c6 respect configured editor 2020-04-22 11:23:14 -05:00
Mislav Marohnić
734497a8d8
Code fixes informed by golangci-lint failures (#738) 2020-04-03 16:33:34 +02:00
Ahmed El Gabri
4a5135d820
Use if/else/if instead 2020-02-12 23:07:36 +01:00
Ahmed El Gabri
ff2d5fa6d0
Check $GIT_EDITOR first 2020-02-07 19:38:04 +01:00
HowJMay
c517fd79b9 fix: Fix typos 
Fix typos in files
 2020-02-02 01:49:11 +08:00
Mislav Marohnić
a710893fc1 Rename to cli/cli 2020-01-24 16:08:52 +01:00
vilmibm
7aa186fe02 make prompt match mockup more 2020-01-16 14:29:59 -06:00
vilmibm
ffb6b8e29f move survey extension to its own package and clarify 2020-01-16 14:28:40 -06:00