Trevor Rosen
b808612769
Remove skipped tests
...
Signed-off-by: Trevor Rosen <trevrosen@github.com>
2025-10-24 13:45:16 -05:00
Trevor Rosen
b6013cf409
Make verifier choice more explicit
...
Signed-off-by: Trevor Rosen <trevrosen@github.com>
2025-10-24 13:42:58 -05:00
Kynan Ware
b90e39ea91
Merge pull request #8826 from lucasmelin/lucasmelin/add-pr-revert-command
...
feat: implement gh `pr revert`
2025-10-23 13:13:08 -06:00
Brian DeHamer
95719714d9
Merge pull request #11991 from cli/copilot/update-gh-release-verification
...
Use "release" sentinel value for release attestation verification
2025-10-23 09:14:11 -07:00
Lucas Melin
6db1441eb6
Return only basic pull request info when reverting a PR
...
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-10-22 18:02:35 -04:00
Trevor Rosen
d5399b79b9
Merge branch 'trunk' into copilot/fix-gh-attestation-verification
2025-10-22 16:56:55 -05:00
Brian DeHamer
0579d74f6d
Merge pull request #11945 from cli/bdehamer/gh-release-create-docs
...
Improve docstring for release-create
2025-10-22 11:35:49 -07:00
Brian DeHamer
b7cea1d935
test fixup
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-10-22 08:56:13 -07:00
copilot-swe-agent[bot]
74ac20671c
Update release verify commands to use sentinel value
...
Co-authored-by: bdehamer <398027+bdehamer@users.noreply.github.com>
2025-10-22 15:26:36 +00:00
copilot-swe-agent[bot]
b27889b76b
Make PGI verifier initialization non-fatal to allow GitHub attestation verification
...
Co-authored-by: trevrosen <1402+trevrosen@users.noreply.github.com>
2025-10-22 15:03:21 +00:00
Kynan Ware
31398fe765
Add test for non-interactive projects v1 unsupported
...
Introduces a test case to ensure that when editing pull requests non-interactively and projects v1 is unsupported, v1 project metadata is not fetched and only v2 project queries are made.
2025-10-21 19:09:14 -06:00
Kynan Ware
ec526bf72b
Inject Detector mock in edit command tests
...
Added Detector field with EnabledDetectorMock to EditOptions in issue and PR edit command tests to ensure feature detection logic is exercised during test runs. Also updated EditableOptionsFetch signature in pr/edit/edit_test.go to include projectsV1Support parameter for compatibility with shared.FetchOptions.
2025-10-21 15:55:42 -06:00
Kynan Ware
e373ad6c9f
Pass ProjectsV1Support to FetchOptions functions
...
Update FetchOptions and related function signatures to accept a ProjectsV1Support parameter, enabling conditional logic based on project support. This change improves flexibility for handling project fields in issue and PR editing flows.
2025-10-21 15:03:52 -06:00
Brian DeHamer
937f6d8c2e
improve docstring for release-create
...
Signed-off-by: Brian DeHamer <bdehamer@github.com>
2025-10-16 11:54:05 -07:00
Babak K. Shandiz
5685b9a443
refactor(auth refresh): use PlainHttpClient instead of zero http.Client
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-13 16:51:13 +01:00
Babak K. Shandiz
365ca1a901
refactor(auth login): use PlainHttpClient for OAuth flow
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-13 16:51:11 +01:00
Babak K. Shandiz
2794f7b8d6
fix(factory): add PlainHttpClient to factory
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-13 16:42:18 +01:00
Kynan Ware
8840df2eb3
Fix agentTaskCmd to use repoResolvingCmdFactory
...
`agent-task` uses smart base repo func to fix bug with resolving upstream instead of local repo.
2025-10-10 10:39:52 -06:00
Kynan Ware
91c6bc609a
Add new displaying message to test expectation
...
Updated the Test_createRun test to expect a message indicating that session logs are being displayed for the job
2025-10-07 23:37:43 -06:00
Kynan Ware
a78bb5e899
Fix --follow not killing the progress indicator
...
Fixes --follow not stopping the progress indicator. Also includes a nice message to indicate what is happening because even after we create the agent task, there's a period of time where we poll and receive nothing as the task session starts. We want there to be some sort of feedback in that period of time to not make the user panic and think it has hanged.
2025-10-07 23:19:45 -06:00
Lucas Melin
ef7ac8caab
Address remaining PR comments for revert implementation
2025-10-06 13:27:45 -04:00
Lucas Melin
4f10a525bc
Adjust PR revert based on new acceptance criteria
...
Also adds test cases for the new acceptance criteria.
2025-10-06 13:27:45 -04:00
Lucas Melin
5368f409a7
Fix revert unit tests by using renamed helper
2025-10-06 13:27:45 -04:00
Lucas Melin
023a639c8c
feat: include revert PR info in message output
2025-10-06 13:25:31 -04:00
Lucas Melin
60b6a5eed5
feat: implement pr revert
2025-10-06 13:25:31 -04:00
Kynan Ware
67bf27bf0c
Merge pull request #11835 from cli/kw/do-not-request-org-teams-for-reviewer-set
...
`gh pr edit`: Only fetch org teams for reviewers when required
2025-10-03 12:25:55 -06:00
Kynan Ware
43e834a691
Apply suggestion from @babakks
...
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-10-02 09:55:58 -06:00
Kynan Ware
8d85946098
Apply suggestion from @babakks
...
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-10-02 09:55:45 -06:00
Kynan Ware
bf728893fa
Fix argument order in httpStubs test functions
...
Swaps the argument order of the httpStubs functions in edit_test.go to match the expected (t *testing.T, reg *httpmock.Registry) signature. This improves consistency and prevents potential confusion or errors when calling these test helpers.
2025-10-02 09:54:01 -06:00
Babak K. Shandiz
ab9c99ec04
docs(cache delete): remove redundant comment
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-02 11:36:00 +01:00
Babak K. Shandiz
d574873f3b
docs(cache delete): add godoc for deleteCacheByKey
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-02 11:33:26 +01:00
Kynan Ware
52bb1dec30
Fix typo in error message for required flags
...
Corrected '--tile' to '--title' in the error message shown when required flags are missing in non-interactive mode.
2025-10-01 16:09:33 -06:00
Kynan Ware
848faf8115
Refactor reviewer partitioning in PR edit command
...
Extracted logic for splitting reviewer identifiers into users and teams into a new helper function, partitionUsersAndTeams. Updated updatePullRequestReviews to use this function for both adding and removing reviewers, improving code clarity and maintainability. Also clarified comments regarding PR author handling.
2025-10-01 16:02:05 -06:00
Kynan Ware
7094a55eec
Remove unused ghIds function and githubv4 import
...
Deleted the unused ghIds helper function and the associated githubv4 import from edit.go to clean up the codebase.
2025-10-01 15:47:39 -06:00
Lucas
ccfc2c3045
fix(cache): report correct deleted count for key and key+ref deletions
...
Previously, deleting caches by key or key+ref could misreport the number of deleted entries, especially when multiple caches matched the criteria. This change ensures the actual number of deleted caches is reported by consuming the API response's total_count field.
2025-10-01 18:44:24 +02:00
Kynan Ware
87468f40db
Refactor PR reviewer editing to use REST API and optimize team fetch
...
Switches pull request reviewer add/remove operations from GraphQL to the REST API, enabling separate add and remove calls for reviewers and teams. Refactors reviewer editing logic to avoid fetching organization teams unless required for interactive editing, improving performance for non-interactive flows. Updates tests and supporting code to reflect the new reviewer management and metadata fetching behavior.
2025-09-30 10:45:44 -06:00
Babak K. Shandiz
52ba836605
Merge pull request #11805 from juejinyuxitu/FieldsFuncSeq
...
refactor: use strings.FieldsFuncSeq to reduce memory allocations
2025-09-30 11:18:57 +01:00
Eugene
a9efc8d3d2
Merge pull request #11801 from cli/eugene/remove_hidden_for_release_verify
...
visible for `release verify` and `release verify-asset` cmd
2025-09-29 10:43:09 -04:00
Kynan Ware
b76bc7706a
Merge pull request #11544 from benjlevesque/auth-status-json-output-8635
...
Add JSON output to `gh auth status`
2025-09-25 09:50:46 -06:00
Lucas Nørgård
8e963a8c14
Merge branch 'trunk' into gist-edit-large-file
2025-09-25 15:47:20 +02:00
Babak K. Shandiz
38d6a83e35
test(auth status): correctly replace JSON-escaped paths
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-25 10:51:47 +01:00
ejahnGithub
a2034545cc
update the description
2025-09-24 14:04:28 -04:00
juejinyuxitu
f5cf156af1
refactor: use strings.FieldsFuncSeq to reduce memory allocations
...
Signed-off-by: juejinyuxitu <juejinyuxitu@outlook.com>
2025-09-24 23:11:17 +08:00
Babak K. Shandiz
0ec5f13283
fix(pr checkout): add alias co
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-09-24 14:56:59 +01:00
ejahnGithub
c1969f0523
remove hidden value for release verify cmd
2025-09-23 16:45:26 -04:00
Eugene
ea08200f01
Merge branch 'trunk' into eugene/release_verify_tag_name_fix
2025-09-23 11:52:17 -04:00
ejahnGithub
4fb9b29ac9
fix latest tag for relase verify asset
2025-09-23 11:50:57 -04:00
Kynan Ware
7ff84cff2e
Merge pull request #11797 from cli/github-cli-epic-990
...
`gh agent-task` commandset
2025-09-23 09:45:59 -06:00
Kynan Ware
8c75079bf2
Add math package import to sessions.go
...
Imported the math package in sessions.go
2025-09-23 09:33:26 -06:00
Kynan Ware
e673dfe61c
Add TODO for better integer handling in GetPullRequestDatabaseID
2025-09-23 09:28:08 -06:00