Alan Donovan
48ada6d5f2
Use correct destination string, not root@localhost
2021-10-18 13:59:41 -04:00
Parth Patel
93221a19d4
fix
2021-10-18 13:56:48 -04:00
Parth Patel
cc63e7de8d
minor fix
2021-10-18 13:54:30 -04:00
Parth Patel
fd376d552c
final changes, update local remote left
2021-10-18 13:53:31 -04:00
Alan Donovan
e31b2567b8
gh cs cp: copy files between local/remote file systems
2021-10-18 12:39:09 -04:00
Mike McDonald
e923eb8853
Merge branch 'trunk' into mm-codespaces-remove-friendly-machine-name
2021-10-18 10:35:48 -06:00
Jose Garcia
84ced52131
Update cmd docs to match other commands
2021-10-16 17:10:34 -04:00
Parth Patel
5ed77c9968
made some progress, not done yet
2021-10-15 19:10:05 -04:00
Mike McDonald
e175d0f0a6
removing unused dependencies
2021-10-15 22:05:54 +00:00
Mike McDonald
5f98c9d2e4
Fixing formatting
2021-10-15 21:58:52 +00:00
Mike McDonald
21ff083b9b
Removing "friendly" machine name from prompt
...
Currently the options end up as `Basic` through to `X`. No other client
provides these types of names, so we should just show machine info.
2021-10-15 21:56:17 +00:00
Nate Smith
06c06c87dc
Merge pull request #3833 from cristiand391/gh-run-cancel
...
Add `run cancel` command
2021-10-15 15:14:49 -05:00
nate smith
a4015b7f09
prompt tests
2021-10-15 15:08:53 -05:00
nate smith
f381a804fc
fix tests
2021-10-15 14:57:20 -05:00
nate smith
18975e61d1
fix imports
2021-10-15 14:31:29 -05:00
nate smith
b81eda0c46
newline
2021-10-15 14:28:28 -05:00
nate smith
f329ebd7ca
add interactive prompt for in progress runs
2021-10-15 14:19:16 -05:00
Nate Smith
dcf3f60e00
Merge pull request #4007 from bchadwic/relative-path
...
gh browse relative path enhancement
2021-10-15 14:13:58 -05:00
nate smith
4a01e6b702
Merge remote-tracking branch 'origin/trunk' into gh-run-cancel
2021-10-15 14:12:53 -05:00
Meijke
f7b4588d09
scope error handling
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-10-15 08:35:33 -07:00
Marwan Sulaiman
6f34e4a605
Rename privacy sub-command to visibility ( #4533 )
...
* Rename privacy sub-command to visibility
* PR fixes
2021-10-15 09:51:46 -04:00
meiji163
caa282f0ba
commit review suggestions
2021-10-14 21:26:31 -07:00
Jose Garcia
4504e49e96
Update running method
2021-10-14 20:02:02 -04:00
Jose Garcia
1aec892326
Merge pull request #4520 from cli/jg/new-api-shape
...
codespace: implement new API payload
2021-10-14 19:59:59 -04:00
nate smith
70c78f2aa8
some fixes, streamlining
2021-10-14 17:07:51 -05:00
Mislav Marohnić
f6b33572fd
Merge pull request #4279 from SiarheiFedartsou/sf-pr-list-head-filter
...
Add `--head` filter to `gh pr list`
2021-10-14 20:54:56 +02:00
Nate Smith
cb89b8ca7a
Merge pull request #4442 from cli/cleanup-upgrade
...
Cleanup extension upgrade command
2021-10-14 13:39:14 -05:00
Mislav Marohnić
b0360612d2
Merge pull request #4521 from cli/jg/bind-locally
...
codespace: switches port binding to 127.0.0.1 where possible
2021-10-14 20:29:21 +02:00
Mislav Marohnić
78443964d4
Merge pull request #4513 from cli/missing-oauth-scopes
...
Warn about missing OAuth scopes when reporting HTTP 4xx errors
2021-10-14 20:21:13 +02:00
Mislav Marohnić
89ad870190
auth refresh: preserve existing scopes when requesting new ones
...
When there was a previously valid token that was granted some scopes,
ensure all those scopes will be re-requested when doing the
authentication flow for the new token.
2021-10-14 19:52:59 +02:00
nate smith
4996ba2ba4
Merge remote-tracking branch 'origin/trunk' into relative-path
2021-10-14 12:24:27 -05:00
Mislav Marohnić
64a19ee71f
Remove OAuth scopes checking logic from ssh-key commands
...
Scopes checking is now handled on the HTTP client level for all commands.
2021-10-14 18:36:55 +02:00
Nate Smith
78ac77180e
Merge pull request #3950 from bchadwic/browse-commit
...
Add feature open latest commit in gh browse
2021-10-14 11:31:15 -05:00
nate smith
5bdaab882b
fix
2021-10-14 11:25:33 -05:00
Jose Garcia
b0905a415f
Merge pull request #4508 from cli/jg/codespace-stop
...
codespace stop: new command to stop a running codespace
2021-10-14 11:22:25 -04:00
Jose Garcia
0748e658cc
Switches port binding to 127.0.0.1 where possible
2021-10-14 11:07:25 -04:00
Jose Garcia
5e56b4a7ce
Fix tests
2021-10-14 09:21:03 -04:00
Jose Garcia
3544275c2f
Implement new API payload for a Codespace
2021-10-14 09:10:15 -04:00
Mislav Marohnić
d68126af99
Avoid macOS prompt to allow incoming connections in liveshare tests
...
Listening on the localhost interface disallows connections from the
outside anyway, so the OS firewall doesn't have to prompt whether the
user wants to allow incoming connections to the Go process.
2021-10-14 14:23:36 +02:00
nate smith
d72d0f47f6
Merge remote-tracking branch 'origin/trunk' into browse-commit
2021-10-13 16:53:50 -05:00
Mislav Marohnić
2ca18e0600
Warn about missing OAuth scopes when reporting HTTP 4xx errors
...
If a 4xx server response lists scopes in the X-Accepted-Oauth-Scopes
header that are not present in the X-Oauth-Scopes header, the final
error messaging on stderr will now include a hint for the user that they
might need to request the additional scope:
$ gh codespace list
error getting codespaces: HTTP 403: Must have admin rights to Repository. (https://api.github.com/user/codespaces?per_page=30 )
This API operation needs the "codespace" scope. To request it, run: gh auth refresh -h github.com -s codespace
2021-10-13 23:24:14 +02:00
Parth Patel
3a21dfa1c5
lint fix
2021-10-13 16:41:46 -04:00
Parth Patel
69db6fca25
res comments
2021-10-13 16:31:54 -04:00
Parth Patel
c1c2946179
minor fix
2021-10-13 15:04:43 -04:00
Jose Garcia
d5c9630fae
Merge pull request #4511 from cli/jg/keepalive-fix
...
codespace ssh: fix for nil logger on non-debugging scenarios
2021-10-13 14:44:10 -04:00
Jose Garcia
3dbec86556
PR Feedback
2021-10-13 14:30:33 -04:00
Jose Garcia
d6b5157eff
Fix for nil logger on non-debugging scenarios
2021-10-13 14:15:26 -04:00
Marwan Sulaiman
b9bdef2b00
Add org scoped port forwarding + fix test formatting ( #4497 )
...
* Add org scoped port forwarding + fix test formatting
* Redesign port visibility
* Update pkg/cmd/codespace/ports.go
Co-authored-by: Jose Garcia <josebalius@github.com>
* Change sub command to privacy
* Example pr comment
* Fix test mock
* Fix test mock
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-10-13 13:56:03 -04:00
Jose Garcia
07fa60b69a
PR Feedback
2021-10-13 11:46:57 -04:00
Jose Garcia
be10950058
Update mocks
2021-10-13 11:04:15 -04:00
