Mislav Marohnić
d68df4a9d8
Do not output error messages for nontty
2021-07-16 15:10:36 +02:00
Mislav Marohnić
30beb67cb3
Merge pull request #3941 from cli/extension-install-check
...
Extension install check
2021-07-16 14:58:52 +02:00
Mislav Marohnić
d6b0749ea2
Tweak error messages and add more tests for extension install name check
2021-07-16 14:52:05 +02:00
bchadwic
b3a24d273b
cleaned up git.go, browse_test.go, and browse.go
2021-07-16 00:07:04 -07:00
bchadwic
25a35a6e88
added relative path access in gh browse
2021-07-15 23:38:54 -07:00
Des Preston
45a4257612
add --discussion-category flag to release cmd
...
Flag for signaling that a discussion should be created with the given
category for the release. Discussions are not supported for draft
releases. If a discussion category is given for a draft, an err will be
shown.
Closes #3381
2021-07-15 10:07:21 -04:00
Mislav Marohnić
5c21c949a0
Merge remote-tracking branch 'origin' into fix/private-repo-create
2021-07-15 12:58:00 +02:00
Mislav Marohnić
0ad153f696
Separate payload structs for REST vs GraphQL repo create
...
This enforces strict separation between serialization structs used for
repository creation payload with respect to whether GraphQL or REST was
used. Before, a field added to a GraphQL payload would leak to REST
payload (and vice versa).
2021-07-15 12:56:14 +02:00
Des Preston
17b58bf0b2
fix repo create --confirm
...
Respect the --confirm flag when deciding whether to prompt for gitignore
and license creation during `repo create`
Fixes #3989
2021-07-14 09:59:04 -04:00
bchadwic
158a15160d
Changed name from SHA to Commit
2021-07-14 01:19:55 -07:00
Des Preston
c95f30af80
add browser option to config
...
Allows setting the path to the browser using the config.
Closes #858
2021-07-13 15:07:57 -04:00
Gowtham Munukutla
e600ce054a
fix description related bugs in creating a template repo
2021-07-13 09:38:34 +05:30
Gowtham Munukutla
0a9fcb9332
Merge branch 'trunk' of https://github.com/cli/cli into fix/private-repo-create
2021-07-13 09:30:48 +05:30
Benjamin Chadwick
0e18db2b11
Merge branch 'cli:trunk' into browse-commit
2021-07-12 14:26:10 -07:00
Nate Smith
161de77fd7
Merge pull request #3943 from silby/browse-output
...
Add a no-browser mode to gh browse
2021-07-12 13:39:30 -05:00
nate smith
98d3b7cc79
don't check Fprintf error
...
we don't ever check the return of Fprintf anywhere else in the codebase
so doing it here suggests that it's a special case. if it's something we
should be doing we can circle back and do it more consistently.
2021-07-12 13:05:49 -05:00
Nate Smith
6c7bff2524
Merge pull request #3912 from bchadwic/trunk
...
Added colors to issue / pr labels in the terminal
2021-07-12 12:46:01 -05:00
Mislav Marohnić
13037226c2
Add test for gh run watch --exit-status with completed runs
2021-07-12 16:58:45 +02:00
Gowtham Munukutla
a1f26057de
gofmt
2021-07-10 23:04:46 +05:30
Gowtham Munukutla
52550f0bee
fix private repo creation in case of ignore templates
2021-07-10 23:03:16 +05:30
Des Preston
1980cc83b9
return SilentError if completed run failed
...
If `gh run watch ${ID} --exit-status` is run and "ID" is the ID of a
completed job that failed, return a SilentError. This ensures that the
program returns a non-zero code.
Fixes #3962
2021-07-09 11:54:58 -04:00
bchadwic
0a496317a5
added in the ability to view repository by commit hashes
2021-07-05 14:57:44 -07:00
Cristian Dominguez
bec0a102c5
Fix tests
2021-07-05 12:47:48 -03:00
Cristian Dominguez
bcab8c0766
Only merge PRs if branch checks have passed
2021-07-05 12:46:36 -03:00
bchadwic
47314a6bbc
modified HexToRGB to check whether terminal and gh have color enabled, as well as created tests for HexToRGB
2021-07-03 17:09:25 -07:00
Evan Silberman
49ff0c6530
Add a no-browser mode to gh browse
...
For when you just want the destination URL on stdout.
2021-07-02 17:12:16 -07:00
Sam Coe
16d218508d
Fix tests
2021-07-02 13:53:26 -07:00
Sam Coe
0482e5cd9b
Disallow installing extensions with the same name
2021-07-02 13:50:15 -07:00
Sam Coe
103e18cab5
Disallow installing extensions with same name as gh command
2021-07-01 13:45:29 -07:00
Sam Coe
bc7eaf8004
Add IsLocal helper func
2021-07-01 11:19:25 -07:00
Sam Coe
86f2df1f49
Add confirmation to extensions remove
2021-07-01 10:43:41 -07:00
Sam Coe
d19c348d7a
Rework code for go 1.15
2021-07-01 10:14:29 -07:00
Sam Coe
63f7372b31
Fix lint
2021-07-01 09:55:13 -07:00
Sam Coe
e9a8b7f781
Skip trying to upgrade local extensions
2021-07-01 09:45:30 -07:00
vilmibm
589b695bcf
test for org + license/ignore
2021-06-30 17:41:39 -05:00
vilmibm
202168ee8d
add nebula preview
2021-06-30 17:38:07 -05:00
vilmibm
2723a01760
fix repo generation in org with license/ignore
2021-06-30 17:21:58 -05:00
bchadwic
af2499cb69
renamed func RGB to HexToRGB
2021-06-29 22:35:23 -07:00
bchadwic
4c412bc88c
Added in label rgb functionality for both prs and issues
2021-06-29 22:26:41 -07:00
Sam Coe
a1e1842e6d
Catch a couple more edge cases
2021-06-29 20:48:30 -07:00
Nate Smith
554250bc4e
Merge pull request #3779 from jgold-stripe/unix
...
Add ability to dial API via unix socket
2021-06-29 09:46:33 -07:00
Nate Smith
0474ba686d
Merge pull request #3773 from bchadwic/first-browse-pull
...
Feature/Create browse command
2021-06-29 09:17:30 -07:00
Sam
33c3fb5cdd
Merge pull request #3870 from cli/extensions-revisited
...
Improvements to gh extensions
2021-06-28 17:12:29 -07:00
Sam Coe
0b80c30789
Fix remote resolving for source repo
2021-06-28 17:00:06 -07:00
Nate Smith
7fc0acd8a5
Merge pull request #3746 from g14a/feature/repo-with-gitignore-license
...
Feature/create repo with gitignore license
2021-06-28 14:57:31 -07:00
nate smith
6c984f4512
remove dead code
2021-06-28 14:36:51 -05:00
Nate Smith
c33b7d0c22
Merge pull request #3807 from camillesf/nonempty_fork_org
...
repo fork: check that --org is not the empty string
2021-06-28 11:16:30 -07:00
Sam Coe
0477084a30
remove now unused color code
2021-06-28 10:57:01 -07:00
jonathan gold
666ed2f3d9
Apply value of http_unix_socket if present in config
2021-06-25 11:47:24 -07:00
jonathan gold
fc3dec4a58
Change signature of NewHTTPClient to accomodate errors
2021-06-25 11:26:21 -07:00