Commit graph

11279 commits

Author SHA1 Message Date
Kynan Ware
4da3fc5713
Merge pull request #12707 from cli/kw/use-shared-pr-workflows
Migrate PR triage workflows to shared workflows
2026-02-17 10:36:42 -07:00
Kynan Ware
5f66c0e8b7 Remove feedback issue template
Delete the .github/ISSUE_TEMPLATE/feedback.md file
2026-02-17 08:07:02 -07:00
Kynan Ware
e90343db35 Migrate PR triage workflows to shared workflows
Replace prauto.yml and pr-help-wanted.yml with a single
triage-pull-requests.yml that calls shared reusable workflows from
desktop/gh-cli-and-desktop-shared-workflows:

- triage-label-external-pr: labels external PRs with external,needs-triage
- triage-close-from-default-branch: closes PRs opened from trunk
- triage-pr-requirements: enforces body length + help-wanted issue linkage
- triage-close-no-help-wanted: closes PRs labeled no-help-wanted-issue
- triage-ready-for-review: removes needs-triage on ready-for-review label

Also adds a daily schedule to auto-close PRs with unmet requirements
after 7 days.

Deletes:
- prauto.yml
- pr-help-wanted.yml
- scripts/check-help-wanted.sh

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-17 07:57:52 -07:00
Kynan Ware
f28380b98f
Merge pull request #12677 from cli/kw/use-shared-triage-workflows
Migrate issue triage workflows to shared workflows
2026-02-17 07:49:38 -07:00
Kynan Ware
e1983ce457 Rename triage workflow to triage-discussion-label
Rename .github/workflows/triage.yml to .github/workflows/triage-discussion-label.yml and update the workflow name from "Discussion Triage" to "Process Discuss Label" to better reflect its intent.
2026-02-17 07:32:35 -07:00
Kynan Ware
e861681139 Pass environment as input to shared triage workflow
The `environment` property cannot be set at the job level when using
`uses:` to call a reusable workflow. Pass it as a workflow input instead.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-17 07:27:01 -07:00
Kynan Ware
b77057d825
Merge pull request #12706 from cli/copilot/sub-pr-12677
Add missing environment and label check to triage workflow
2026-02-17 07:08:19 -07:00
copilot-swe-agent[bot]
8e6cdf7059 Add missing environment and label check to triage workflow
Co-authored-by: BagToad <47394200+BagToad@users.noreply.github.com>
2026-02-17 14:05:39 +00:00
copilot-swe-agent[bot]
772e677e73 Initial plan 2026-02-17 14:03:42 +00:00
Babak K. Shandiz
31f3756089
fix(workflow run): bail out on feature detection error
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-17 11:48:25 +00:00
Babak K. Shandiz
52eca96873
refactor(featuredetection): remove temp in favour of early returns
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-17 11:46:33 +00:00
Babak K. Shandiz
ce016217d0
docs(workflow run): improve help docs
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2026-02-16 22:49:42 +00:00
Babak K. Shandiz
c47a10e583
docs(workflow run): add cleanup marker with explanation on future changes
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 22:02:18 +00:00
Babak K. Shandiz
36a85fd71f
fix(workflow run): apply url.PathEscape when compiling URL
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 21:55:25 +00:00
Babak K. Shandiz
3e9fbbb2fa
refactor(workflow run): remove temp out
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 21:53:17 +00:00
Kynan Ware
8d819c5584
Merge pull request #12701 from cli/kw/add-missing-fd-todos
Add missing TODO comments for featuredetection if-statements
2026-02-16 14:41:48 -07:00
Kynan Ware
9de48154de Add missing TODO comments for featuredetection if-statements
Add greppable TODO identifiers above all if-statements that reference
featuredetection struct fields, as required by the featuredetection
linter. This ensures every feature detection branch is tagged for
future cleanup when GHES gains support.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-16 14:24:32 -07:00
Babak K. Shandiz
61ab5e0b5d
docs(featuredetection): fix typo in comment
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 13:07:24 +00:00
Babak K. Shandiz
b64dd58d8b
test(featuredetection): fix test case name
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 13:06:23 +00:00
Babak K. Shandiz
bf2ff7c39b
test(workflow run): verify retrieval of workflow run details
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 12:57:01 +00:00
Babak K. Shandiz
e73bf113dd
feat(workflow run): retrieve workflow run if supported by the API
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 12:56:01 +00:00
Babak K. Shandiz
33825477ae
test(featuredetection): add tests for ActionsFeatures
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 11:54:07 +00:00
Babak K. Shandiz
a0dea00fdd
fix(featuredetection): add ActionsFeatures to detect workflow dispatch features
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-02-16 11:53:33 +00:00
4RH1T3CT0R7
fa95f3a21b Add --no-upstream flag to gh repo clone
When cloning a forked repository, `gh repo clone` automatically adds the
parent repo as an `upstream` remote and sets it as the default repository.
This can be problematic when the user lacks access to the parent repo,
the upstream fetch is expensive for large repos, or the user simply
doesn't want the upstream remote.

Add a `--no-upstream` flag that skips adding the upstream remote when
cloning a fork. When used, origin (the fork) is set as the default
repository instead. The flag is mutually exclusive with
`--upstream-remote-name`. For non-fork repos the flag is a harmless
no-op.

Closes #8274
2026-02-14 20:31:02 +03:00
Kynan Ware
ceb904413d Clarify ReviewerCandidate relationship to AssignableActor
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-13 13:45:00 -07:00
Kynan Ware
72a6e9f3a7 Move PR review queries from queries_pr.go to queries_pr_review.go
Consolidate all review-related types, methods, and functions into
queries_pr_review.go for better code organization. The file is now
ordered by logical sections: review data types, review status, review
requests, reviewer candidates, API operations, and helpers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-13 13:40:59 -07:00
William Martin
1af2823fc3
Merge pull request #12680 from cli/wm-add-api-version
Pin REST API version to 2022-11-28
2026-02-13 19:55:27 +01:00
William Martin
166db75d36 pin REST API version to 2022-11-28
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-02-13 19:46:16 +01:00
William Martin
4e76bb0f47
Merge pull request #12679 from cli/wm-run-view-exit-status-not-respected
Respect `--exit-status` with `--log` and `--log-failed` in `run view`
2026-02-13 19:40:48 +01:00
Kynan Ware
f1ebf6f8d9 Migrate stale workflow to shared workflow 2026-02-13 11:17:33 -07:00
William Martin
24964681a8 Respect --exit-status with --log and --log-failed
Fixes #12674
2026-02-13 16:04:06 +01:00
William Martin
2c54a0d36a
Merge pull request #12673 from cli/wm-explore-fork-branches-in-pr
Fork with default branch only during pr create
2026-02-13 15:50:38 +01:00
William Martin
2b5c3b5ecb document fork default branch behavior 2026-02-13 15:36:37 +01:00
Kynan Ware
a5e97b5b6c Migrate issue triage workflows to shared workflows 2026-02-12 23:32:45 -07:00
William Martin
7448aed8ab fork default branch only in pr create 2026-02-12 16:56:14 +01:00
Kynan Ware
1d730951d2 Use org/slug format in test fixtures and remove /slug normalization 2026-02-11 14:51:12 -07:00
Kynan Ware
1cb776384e Normalize /slug team shorthand to org/slug and fix docs 2026-02-11 14:33:13 -07:00
Kynan Ware
a8655bcda9 Include bot logins in login-based reviewer mutation guard 2026-02-11 13:55:57 -07:00
Kynan Ware
e361335e5c Skip reviewer metadata fetch when using search-based selection 2026-02-11 13:18:39 -07:00
Kynan Ware
38661646ee Update test assertions to expect org/slug team format 2026-02-11 13:18:07 -07:00
Kynan Ware
ad64d10bf4 Wire bot reviewer logins through CreatePullRequest 2026-02-11 13:16:23 -07:00
Kynan Ware
1209b24e69 Partition bot reviewers separately for RequestReviewsByLogin 2026-02-11 13:16:03 -07:00
Kynan Ware
db167d3116 Preserve org/slug format for team reviewer slugs 2026-02-11 13:15:14 -07:00
Kynan Ware
cf08f4d51e
Apply suggestion from @BagToad 2026-02-10 11:08:12 -07:00
Kynan Ware
7373de3e70
Remove redundant comment 2026-02-10 10:58:23 -07:00
Kynan Ware
dd9ab7152b
Don't swallow error from FD
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-10 10:54:03 -07:00
Kynan Ware
620261fea4
Remove redundant comments 2026-02-10 10:53:30 -07:00
Kynan Ware
c187b882a0
Merge branch 'trunk' into kw/pr-create-multi-select-with-search-ccr 2026-02-10 10:37:41 -07:00
gunadhya
b38f6772e5 Fix issue develop repeated invocation with named branches 2026-02-09 23:31:22 +05:30
Babak K. Shandiz
4e65637471
Merge pull request #12631 from cli/kw/bump-go-is-workflow-dispatchable
Add manual dispatch to bump-go workflow
2026-02-09 12:48:34 +00:00