STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11279 commits 87 branches 0 tags 160 MiB
Commit graph

11279 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kynan Ware
6adf803127
Merge pull request #12526 from cli/github-cli-1070-multi-select-with-search-ccr 
`gh pr edit`: new interactive prompt for assignee selection, performance and accessibility improvements
 2026-01-27 09:16:26 -07:00
dependabot[bot]
fdc72751a7
chore(deps): bump actions/attest-build-provenance from 3.1.0 to 3.2.0 
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases)
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md)
- [Commits](00014ed6ed...96278af6ca)

---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
  dependency-version: 3.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-01-27 14:01:36 +00:00
Kynan Ware
23e80a9d24 Remove outdated comment in SuggestedAssignableActors 
Deleted a comment about the query variable being passed as null when empty, as it is no longer relevant or necessary.
 2026-01-26 15:09:58 -07:00
Kynan Ware
a33d809c88
Apply suggestions from code review 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2026-01-26 15:09:16 -07:00
Kynan Ware
968a912a07 Remove outdated TODO comments in survey.go 
Cleaned up obsolete TODO comments related to assignee and reviewer selection logic in the MetadataSurvey function.
 2026-01-26 15:05:18 -07:00
Kynan Ware
a8053d6e93 Remove redundant comment in editRun test 2026-01-26 14:56:50 -07:00
Kynan Ware
28e07666f8 Return total assignee count in SuggestedAssignableActors 
Updated SuggestedAssignableActors to return the total count of available assignees in the repository. Modified assigneeSearchFunc to use this count to calculate and display the number of additional assignees beyond the current results.
 2026-01-26 14:33:45 -07:00
Kynan Ware
af124cd5d2 Add test for MultiSelectWithSearch error propagation 
Introduces a test case to verify that errors returned from the MultiSelectWithSearch search function are properly propagated to the caller.
 2026-01-26 13:56:47 -07:00
Kynan Ware
fb031b2b43 Add test for legacy assignee flow on GHES 
Introduces a test case to verify that the interactive edit flow on GitHub Enterprise Server uses the legacy assignee selection without search, ensuring correct behavior when editing pull request assignees.
 2026-01-26 13:48:23 -07:00
Kynan Ware
48bea46504 Remove unused Viewer struct from SuggestedAssignableActors 
Deleted the Viewer struct from the responseData type in SuggestedAssignableActors as it was not being used.
 2026-01-26 13:48:22 -07:00
Kynan Ware
e3a3a01f2d Add comments to assigneeSearchFunc for clarity 
Added detailed comments to the assigneeSearchFunc explaining its purpose and the importance of updating assignable actors metadata for later ID resolution when mutating assignees with the GraphQL API.
 2026-01-26 13:29:22 -07:00
Kynan Ware
dc105ce7a4 Simplify variables map in SuggestedAssignableActors 
Refactored the construction of the variables map by directly assigning the 'query' key, removing the conditional logic for nil assignment.
 2026-01-26 13:29:22 -07:00
Kynan Ware
346bd8c002 Simplify suggested assignable actors 
Simplifies SuggestedAssignableActors by no longer including the viewer in the returned actors list when the query is blank. Removes related logic and variables for viewer handling.
 2026-01-26 13:29:22 -07:00
Kynan Ware
38f9d7891b Fix linter and mock prompter signature 2026-01-26 13:29:22 -07:00
Kynan Ware
30cfbd9fdd Apply suggestions from code review 
Co-authored-by: Babak K. Shandiz <babakks@github.com>
 2026-01-26 13:29:22 -07:00
Kynan Ware
f6a09a3e5c Apply suggestions from code review 
Co-authored-by: Babak K. Shandiz <babakks@github.com>
 2026-01-26 13:29:22 -07:00
Kynan Ware
c0df49043f Clarify TODO comment for reviewer search function 
Updated the TODO comment to specify wiring up the reviewer search function if or when it exists, providing clearer intent for future development.
 2026-01-26 13:29:22 -07:00
Kynan Ware
ad8c770013 Only support assignee searchfunc on GitHub.com 2026-01-26 13:29:22 -07:00
Kynan Ware
07dfdf97ae Update edit tests 
Updated test mocks and logic to consistently use lowercase 'monalisa' for login names and display names for user assignees. Improved handling of dynamic assignee fetching in interactive flows by relying on searchFunc and metadata population, and clarified logic in FetchOptions to fetch assignees only when necessary. These changes ensure more accurate simulation of interactive assignment and better test coverage for actor assignee features.
 2026-01-26 13:29:22 -07:00
Kynan Ware
d46f42a752 Refactor MultiSelectWithSearch to use result struct 
Refactored the MultiSelectWithSearch function and related interfaces to use a MultiSelectSearchResult struct instead of multiple return values. This change improves clarity and extensibility of the search function signature, and updates all usages, mocks, and tests accordingly.
 2026-01-26 13:29:22 -07:00
Kynan Ware
38578f7991 Add comment describing logger 
Added a comment explaining how to enable logging in expect-based tests by using expect.WithLogger. This helps developers debug by printing characters read to stdout.
 2026-01-26 13:29:22 -07:00
Kynan Ware
7e7f8c6f6e Pass editable to assigneeSearchFunc and update metadata 
The assigneeSearchFunc now receives the editable struct to update its Metadata.AssignableActors field with suggested assignable actors. This change ensures that the editable struct has the necessary actor metadata for later PR updates.
 2026-01-26 13:29:22 -07:00
Kynan Ware
d04317c273 Add dynamic assignee search to PR edit flow 
Introduces SuggestedAssignableActors API query and wires up a dynamic assignee search function in the PR edit command. Updates Editable and EditPrompter interfaces to support search-based multi-select for assignees, improving the user experience when assigning users to pull requests.
 2026-01-26 13:29:22 -07:00
Kynan Ware
0beb74bf72 MultiSelectWithSearch initial implementation 
Initial implementation of MultiSelectWithSearch:

- Implement by survey and accessible prompters. They use the same internal func under the hood.
- Implement in `gh preview prompter` for initial testing and demonstration
- Implement interface changes across the codebase and mocks to satisfy compiler.
- Implement tests for new MultiSelectWithSearch prompter
 2026-01-26 13:29:22 -07:00
Kynan Ware
be1e21095c prshared: named prompt interface parameters 
Updated the Prompt interface in survey.go to include parameter names for all methods, improving code readability and clarity.
 2026-01-26 13:29:22 -07:00
Kynan Ware
009cf6e167
Merge pull request #12554 from cuiweixie/typo 
typo: dont to don't
 2026-01-26 10:54:05 -07:00
cuiweixie
b9c85fff68
typo: dont to don't 2026-01-26 22:25:00 +08:00
Kynan Ware
cf53b76d71
Merge pull request #12354 from cli/dependabot/github_actions/goreleaser/goreleaser-action-6.4.0 
chore(deps): bump goreleaser/goreleaser-action from 6.0.0 to 6.4.0
 2026-01-23 11:31:37 -07:00
dependabot[bot]
09e66252fd
chore(deps): bump goreleaser/goreleaser-action from 6.0.0 to 6.4.0 
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 6.0.0 to 6.4.0.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](286f3b13b1...e435ccd777)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-version: 6.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-01-23 18:22:34 +00:00
Kynan Ware
c8335e3f55
Merge pull request #12315 from cli/dependabot/github_actions/actions/upload-artifact-6 
chore(deps): bump actions/upload-artifact from 5 to 6
 2026-01-23 11:18:50 -07:00
Kynan Ware
970a1ebbc1
Merge pull request #12314 from cli/dependabot/github_actions/actions/download-artifact-7 
chore(deps): bump actions/download-artifact from 6 to 7
 2026-01-23 11:18:19 -07:00
Babak K. Shandiz
e643df99cf
Merge pull request #12515 from cli/dependabot/go_modules/github.com/theupdateframework/go-tuf/v2-2.3.1 
chore(deps): bump github.com/theupdateframework/go-tuf/v2 from 2.3.0 to 2.3.1
 2026-01-22 21:10:41 +00:00
Babak K. Shandiz
1318fe94d7
chore: update licenses 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2026-01-22 21:02:13 +00:00
dependabot[bot]
0162ee2c7a
chore(deps): bump github.com/sigstore/rekor from 1.4.3 to 1.5.0 
Bumps [github.com/sigstore/rekor](https://github.com/sigstore/rekor) from 1.4.3 to 1.5.0.
- [Release notes](https://github.com/sigstore/rekor/releases)
- [Changelog](https://github.com/sigstore/rekor/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sigstore/rekor/compare/v1.4.3...v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/sigstore/rekor
  dependency-version: 1.5.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-01-22 20:59:20 +00:00
dependabot[bot]
d4a4bc4dda
chore(deps): bump github.com/theupdateframework/go-tuf/v2 
Bumps [github.com/theupdateframework/go-tuf/v2](https://github.com/theupdateframework/go-tuf) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/theupdateframework/go-tuf/releases)
- [Commits](https://github.com/theupdateframework/go-tuf/compare/v2.3.0...v2.3.1)

---
updated-dependencies:
- dependency-name: github.com/theupdateframework/go-tuf/v2
  dependency-version: 2.3.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-01-22 20:59:01 +00:00
Babak K. Shandiz
8fb8006c86
Merge pull request #12525 from cli/dependabot/go_modules/github.com/sigstore/sigstore-1.10.4 
chore(deps): bump github.com/sigstore/sigstore from 1.10.0 to 1.10.4
 2026-01-22 20:57:36 +00:00
Babak K. Shandiz
56b2a15128
chore: update licenses 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2026-01-22 20:49:25 +00:00
dependabot[bot]
6811f941f3
chore(deps): bump github.com/sigstore/sigstore from 1.10.0 to 1.10.4 
Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore) from 1.10.0 to 1.10.4.
- [Release notes](https://github.com/sigstore/sigstore/releases)
- [Commits](https://github.com/sigstore/sigstore/compare/v1.10.0...v1.10.4)

---
updated-dependencies:
- dependency-name: github.com/sigstore/sigstore
  dependency-version: 1.10.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-01-22 20:30:02 +00:00
Kynan Ware
a9f297b7e9
Merge pull request #12521 from Sethispr/patch-2 
Lint source.md
 2026-01-22 09:38:50 -07:00
seth
c1c5ac82d8
docs: lint source.md 
Fixes:
- MD022 / blanks-around-headings 
Headings should be surrounded by blank lines
- MD031 / blanks-around-fences
Fenced code blocks should be surrounded by blank lines
 2026-01-22 05:44:11 -08:00
Babak K. Shandiz
3220ab5ab2
Merge pull request #12516 from mikelolasagasti/pr-shared-error-atoi 
Fix fmt.Errorf format argument in ParseFullReference
 2026-01-21 23:38:49 +00:00
Babak K. Shandiz
0d8a697c7c
fix(pr/shared): improve ParseFullReference error message 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2026-01-21 23:30:43 +00:00
Mikel Olasagasti Uranga
bd0177b039 Fix fmt.Errorf format argument in ParseFullReference 
The error path passed an int to fmt.Errorf with %q, which expects a
string. Use the original reference string to avoid a format mismatch.

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
 2026-01-21 23:14:59 +01:00
Kynan Ware
49f72234ac
Merge pull request #12376 from majiayu000/fix-11903-pr-create-same-ref 
fix: error when head and base refs are identical in pr create
 2026-01-21 10:21:14 -07:00
Kynan Ware
c34c47c013
Merge pull request #12505 from cli/kw/contributing-guidelines-clarity 
Update contributing guidelines for clarity
 2026-01-21 09:50:22 -07:00
majiayu000
0f4b9b0d91
refactor: address review comments 
Signed-off-by: majiayu000 <1835304752@qq.com>
 2026-01-21 18:28:21 +08:00
Kynan Ware
fe729082ad Update contributing guidelines for clarity 2026-01-20 15:21:23 -07:00
Kynan Ware
3e8855f755
Merge pull request #12101 from davidspek/feat/delete-all-cache-ref 
feat(cache delete): allow for delete all caches for a ref
 2026-01-20 12:16:47 -07:00
Kynan Ware
c4fd102016
Merge branch 'trunk' into fix-11903-pr-create-same-ref 2026-01-20 10:33:17 -07:00
Kynan Ware
3d89222e2d
Merge pull request #12500 from cli/babakks/polish-copilot-cmd-tests 
Fix Windows asset URL in `copilot` command tests
 2026-01-20 09:39:35 -07:00