Kynan Ware
c0d5f164f2
Merge pull request #12089 from cli/kw/use-source-govulncheck-scan-lint
...
CI: Update lint govulncheck to use source mode
2025-11-03 13:18:27 -07:00
Kynan Ware
52391ff0f8
Apply suggestions from code review
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-03 13:08:16 -07:00
Kynan Ware
b151f53d02
Add note on govulncheck source mode for Go 1.25
2025-11-03 13:05:33 -07:00
Babak K. Shandiz
917e365c5c
docs(pkg/search): fix typo
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:28 +00:00
Babak K. Shandiz
0e53651bb2
docs(repo garden): improve func godoc
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:27 +00:00
Babak K. Shandiz
d3b333e5be
fix: ignore nilerr on intentionally swallowed error
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:27 +00:00
Babak K. Shandiz
d002d30327
fix: resolve nilerr issues
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:26 +00:00
Babak K. Shandiz
f498f2e882
fix: resolve copyloopvar issues
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:26 +00:00
Babak K. Shandiz
3ad3fcdce9
fix: resolve gocritic issue
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:26 +00:00
Babak K. Shandiz
0eb5640edb
test(pkg/httpmock): ignore bodyclose on mock response value
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:25 +00:00
Babak K. Shandiz
2709c39179
refactor(repo garden): return pagination link instead of resp
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:25 +00:00
Babak K. Shandiz
9f65e89760
fix: close resp body (bodyclose)
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:25 +00:00
Babak K. Shandiz
d129b94fc5
refactor: remove returned resp from api.EndpointNeedsScopes
...
The returned response from `api.EndpointNeedsScopes` causes `bodyclose`
linter to raise a false positive error, assuming it's a new response that
its body needs to be closed.
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:24 +00:00
Babak K. Shandiz
dde7fce602
refactor(pkg/search): remove passing resp for pagination
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:24 +00:00
Babak K. Shandiz
c6c97b32d5
ci: enable basic linters
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 20:05:20 +00:00
Kynan Ware
6c1d1c4f49
Update lint govulncheck to use source mode
...
Replaces binary mode scan of 'bin/gh' with source mode scan of all packages using govulncheck.
2025-11-03 12:55:13 -07:00
Babak K. Shandiz
3d76c668f3
Merge pull request #12085 from cli/babakks/govulncheck-via-workflow-dispatch
...
chore: add `workflow_dispatch` to govulncheck triggers
2025-11-03 19:49:18 +00:00
Babak K. Shandiz
eaddf5baf9
chore: add workflow_dispatch to govulncheck triggers
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-11-03 19:43:01 +00:00
Kynan Ware
e73a0e077a
Merge pull request #11926 from cli/bump-go-1.25.3
...
Bump Go to 1.25.3
2025-11-03 11:32:09 -07:00
Kynan Ware
cd9e5e534f
Merge pull request #12068 from cli/kw/spike-custom-agents
...
`gh agent-task create`: support `--custom-agent`/`-a` flag
2025-10-31 18:19:44 -06:00
Kynan Ware
44653c5aeb
Add example for --custom-agent usage
...
Added a usage example to the help text demonstrating how to create a task with a custom agent using the --custom-agent flag.
2025-10-31 16:18:10 -06:00
Kynan Ware
5d17666a69
Update error messages in job creation tests
2025-10-31 16:16:03 -06:00
Kynan Ware
591050a8d2
Update pkg/cmd/agent-task/capi/job.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-31 16:06:37 -06:00
Kynan Ware
0dcb1d1e43
Add shorthand flag for custom-agent option
...
Introduces the '-a' shorthand for the --custom-agent flag in the agent-task create command, improving CLI usability.
2025-10-31 15:59:23 -06:00
Kynan Ware
24885040cb
Fix: do not swallow job creation error
...
Reads the response body before decoding to allow multiple decoding attempts. Enhances error reporting by including HTTP status and error messages from both Job and JobError structures when job creation fails.
2025-10-31 15:54:01 -06:00
Kynan Ware
64de314640
Clarify custom agent flag description
...
Updated the help text for the --custom-agent flag to provide an example usage, making it clearer how to specify a custom agent for the task.
2025-10-31 15:10:03 -06:00
Kynan Ware
17085d3c5e
Add custom agent support to job creation
...
Introduces a 'customAgent' parameter to the CreateJob API, CLI options, and related mocks and tests.
2025-10-31 14:57:48 -06:00
Babak K. Shandiz
9d2bea6308
docs(release list): fix typo
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 20:38:04 +00:00
Babak K. Shandiz
98389269b6
docs(release list): reword comment
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 20:36:27 +00:00
Babak K. Shandiz
065fc38c4d
feat(release list): add isImmutable JSON field
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 19:53:39 +00:00
Babak K. Shandiz
26552f3489
fix(featuredetection): add ReleaseFeatures method
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 19:52:09 +00:00
Kynan Ware
1ad9093b42
Merge branch 'trunk' into bump-go-1.25.3
2025-10-31 12:19:01 -06:00
Kynan Ware
a701a374d3
Merge pull request #12062 from cli/babakks/add-example-for-input-to-api-cmd
...
Improve `api` command docs around `--input` and `--field`
2025-10-31 12:14:59 -06:00
Kynan Ware
83c51dc89e
Merge pull request #12058 from cli/babakks/exclude-third-party-from-golangci-lint
...
Exclude `third-party` from Golangci-lint formatting paths
2025-10-31 12:14:33 -06:00
Babak K. Shandiz
ba5c9af957
docs(api): add example for --input option
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 13:44:17 +00:00
Babak K. Shandiz
ad0252e845
docs(api): mention use of @<path> and @- for --field
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 13:35:20 +00:00
Babak K. Shandiz
38c280ec8a
docs: update go version 1.25
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 12:22:48 +00:00
Babak K. Shandiz
139c2c4f9a
refactor: replace backport with strings.CutSuffix
...
The `cutSuffix` function was added to backport the functionality of
`strings.CutSuffix` from Go 1.20. Now that we're using Go 1.25, we can
safely replace our backport with the standard library function. Our
backport was an intact copy/paste of the stdlib implementation, so this
change does not alter any behavior.
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 12:21:02 +00:00
Babak K. Shandiz
c07e94f64f
chore: exclude third-party from Golangci-lint formatting paths
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 12:13:10 +00:00
Babak K. Shandiz
a73a6937ab
chore: bump Go in devcontainer
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-31 12:03:25 +00:00
Babak K. Shandiz
9e55f83a04
Merge branch 'trunk' into bump-go-1.25.3
2025-10-31 10:05:40 +00:00
Kynan Ware
20c7bdc2a4
Merge pull request #11761 from luxass/gist-edit-large-file
...
fix(gist): add support for editing & viewing large files
2025-10-30 20:35:23 -06:00
Babak K. Shandiz
a722c88e98
Merge pull request #12056 from cli/babakks/fix-linter-issues
...
Apply `go fix` to remove deprecated `// +build` tags
2025-10-30 21:41:33 +00:00
Babak K. Shandiz
05986e4cb3
chore: apply go fix to remove deprecated // +build tags
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-10-30 21:10:45 +00:00
Babak K. Shandiz
757a6dece4
Merge pull request #12053 from 2003Aditya/fix-interval
...
Fix `--interval` flags docs in `gh pr checks`
2025-10-30 20:22:19 +00:00
2003Aditya
15f01d43a4
fix: --interval flags docs in gh pr checks
2025-10-30 20:06:45 +00:00
Babak K. Shandiz
68e9b9a517
Merge pull request #12049 from cli/babakks/bump-golangci-lint
...
Bump Golangci-lint to `v2.6.0`
2025-10-30 20:02:50 +00:00
Babak K. Shandiz
c0937f404e
Merge pull request #12054 from cli/kw/tool-chain-bump
...
Update Go toolchain version to 1.24.9
2025-10-30 19:52:14 +00:00
Kynan Ware
36665a1fb8
Merge pull request #12050 from cli/babakks/improve-run-list-docs
...
Mention `pr checks` in `run list` docs
2025-10-30 13:20:15 -06:00
Lucas
7db532aca0
test(gist/edit): add tests for single file edit and interactive multi-file selection
...
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-10-30 18:50:49 +01:00