Commit graph

11279 commits

Author SHA1 Message Date
Gowtham Munukutla
3e5d5a23c0 add fixturefile const in tests 2021-02-24 10:22:56 +05:30
Gowtham Munukutla
d4e14beb57 remove unwanted tests and unwanted functionality 2021-02-24 10:14:31 +05:30
Gowtham Munukutla
8f1c467001 Merge branch 'trunk' of https://github.com/cli/cli into feature/add-files-to-gist 2021-02-24 09:44:19 +05:30
Gowtham Munukutla
a6fa14866b updating tests WIP 2021-02-24 09:44:11 +05:30
Sam Coe
34da59777b
Revert close and reopen changes 2021-02-23 13:24:48 -08:00
Mislav Marohnić
98df059e84
Merge pull request #3020 from cli/brew-upgrade-notice
Avoid upgrade notice for recent release if gh is under Homebrew prefix
2021-02-23 21:04:57 +01:00
Mislav Marohnić
3efa764305 Avoid the issue/pr recovery mechanism handling Ctrl-C keypress in prompts
Either InterruptErr or SilentErr will be present when the user has
chosen "Cancel" or pressed Ctrl-C in prompts. We don't want the recovery
mechanism to kick in these cases because the cancellation was likely
willingly initiated by the user.
2021-02-23 20:09:03 +01:00
Mislav Marohnić
fff051468e Avoid triggering recovery mechanism when cancelling issue/pr create 2021-02-23 19:42:41 +01:00
Sam Coe
9d062ed8fc
Normalize pr command arguments 2021-02-23 09:17:35 -08:00
boonhong
732e919a83 Add pr edit --base to change the base branch of a PR 2021-02-24 00:15:04 +08:00
Mislav Marohnić
b0b90afa87 issue/pr create: exit with nonzero status code when "Cancel" was chosen
This is to indicate that the command had not finished successfully.
2021-02-23 17:06:29 +01:00
Mislav Marohnić
c5af4ddfdc
Merge pull request #3009 from cli/git-credential-env
Fix `auth git-credential` when the token comes from environment
2021-02-23 16:32:23 +01:00
Gowtham Munukutla
cbf8a0d964 Accept only one argument when deleting a gist 2021-02-23 20:12:26 +05:30
Mislav Marohnić
fee7adf9ba Add issue create -F <file> flag and tests 2021-02-23 14:25:32 +01:00
castaneai
13c3c6543b Add pr create --body-file flag 2021-02-23 12:58:34 +01:00
Gowtham Munukutla
a60a6d854b Merge branch 'trunk' of https://github.com/cli/cli into feature/add-files-to-gist 2021-02-23 17:13:07 +05:30
Mislav Marohnić
27aea42d8a Avoid upgrade notice for recent release if gh is under Homebrew prefix
Before, when gh detected there was a new release in the `cli/cli` repo,
it would show this notice:

    A new release of gh is available: {V1} → {V2}

Additionally, when the release was more than 24h old, we would show this
to Homebrew users:

    To upgrade, run: brew update && brew upgrade gh

Ref. feb4acc2c0

This change makes it so that the original notice "A new release of gh is
available" is NOT shown to Homebrew users unless the release is older
than 24h. We effectively hide the fact that any release happened until
we're sure that the version bump has made it to `homebrew-core`.
2021-02-23 12:24:51 +01:00
Mislav Marohnić
d6798b1852
Merge pull request #3019 from cli/ghe-paste-token
Fix pasting Personal Access Token to `auth login` for GHE
2021-02-23 11:34:02 +01:00
Mislav Marohnić
cfddda8829 Indicate workflow scope is GHE 3.0+ only during auth login 2021-02-23 10:52:29 +01:00
Mislav Marohnić
f807795491 Fix pasting Personal Access Token to auth login for GHE 2021-02-23 10:19:11 +01:00
Mislav Marohnić
0e917dc1ad go mod tidy 2021-02-22 19:02:35 +01:00
Mislav Marohnić
329ba1d57b Add --filter to api command to filter data using jq syntax 2021-02-22 17:51:58 +01:00
Mislav Marohnić
fd82d621d5 Add color function to api templates 2021-02-22 16:54:27 +01:00
Mislav Marohnić
517cfc2365 Add api --format flag for specifying an output template
With the `--format` flag, the value of the flag is parsed as a Go
template which is then evaluated against parsed response data.
https://golang.org/pkg/text/template
2021-02-22 16:15:02 +01:00
Mislav Marohnić
9dff05bf20 Add api --cache flag
Cache API responses on disk for a specified duration.
2021-02-22 16:13:24 +01:00
Cristian Dominguez
2284ef43d0 repo list: add tests 2021-02-19 17:34:17 -03:00
Mislav Marohnić
9bf1668b3f Fix auth git-credential when the token comes from environment
When a token such as GH_TOKEN is set through environment variables and
`~/.config/gh/hosts.yml` is non-existent, the `auth git-credential get`
command used to fail due to missing username.

Since GitHub username isn't at all required for token authentication,
use the `x-access-token` faux username instead of trying to obtain one
from a config file.
2021-02-19 15:37:11 +01:00
Gowtham Munukutla
faffc4de95 Add go fmt to pass ci/cd 2021-02-19 12:05:20 +05:30
Gowtham Munukutla
f56b38908e Merge branch 'trunk' of https://github.com/cli/cli into feature/add-files-to-gist 2021-02-19 12:02:24 +05:30
Gowtham Munukutla
4ed10140ab Resolved PR review comments and test cases 2021-02-19 12:02:17 +05:30
Cristian Dominguez
cad875a05f repo list: render repo tags into the 3rd column instead of the 2nd 2021-02-18 19:02:59 -03:00
Cristian Dominguez
b7c2865d0f Remove archived filter from repo list 2021-02-18 17:34:00 -03:00
Mislav Marohnić
04dcb327ca
Merge pull request #2996 from cli/ghe-branchprotectionrule
Fix `pr status` for GHE 2.22 and older
2021-02-18 19:41:04 +01:00
Gowtham Munukutla
882bd1adb1 add go lint to pass checks 2021-02-18 22:39:56 +05:30
Mislav Marohnić
dcff6c4f2d Fix pr status for GHE 2.22 and older
This queries for the availability of the `branchProtectionRule` field on
"Ref" before trying to request it from GraphQL.
2021-02-18 17:46:13 +01:00
Gowtham Munukutla
a4a194011f gofmt 2021-02-18 19:18:49 +05:30
Gowtham Munukutla
9a4fd0d706 Remove unwanted prompt for user. Unwanted test as well 2021-02-18 19:17:42 +05:30
Gowtham Munukutla
d469f4b2cc Merge branch 'trunk' of https://github.com/cli/cli into feature/add-files-to-gist 2021-02-18 18:46:40 +05:30
Gowtham Munukutla
bff8b3007a Add test cases and improve errors with color schemes 2021-02-18 18:45:43 +05:30
Nate Smith
2f563babbf
Merge pull request #2990 from cli/ssh-key-commands
Add `ssh-key add` command and publish `ssh-key`
2021-02-17 14:30:37 -06:00
Mislav Marohnić
e596f8732b Fix creating a repository from template
Fixes a problem where setting up a new local directory for the
repository created from a template would not contain any files:

    gh repo create -p OWNER/some-template my-repo --private --confirm
    ls my-repo
    //=> [empty directory]

Fixes #2290
2021-02-17 20:26:06 +01:00
Mislav Marohnić
a8fdd9a303 Further clarify what will happen on repo create
In local git directory:
1. `This will add an "origin" git remote to your local repository.  Continue?`
2. "origin" git remote is added in current directory.

Outside of a local git directory:
1. This will create the "REPO" repository on GitHub. Continue?
2. `Create a local project directory for "REPO"?`
3. new directory called "REPO" now set up for the GitHub repository.
2021-02-17 20:22:23 +01:00
Mislav Marohnić
1a9e42ed55 Add ssh-key add command and publish ssh-key 2021-02-17 19:46:59 +01:00
Nate Smith
e91b97b4c5
fully restore fork remote renaming behavior (#2982)
* fully restore fork remote renaming behavior

* catch blank remote name and error + arg tests

* hard wrap fork usage

* do not rename if remote-name supplied

* tweak error text
2021-02-17 12:33:22 -06:00
Nate Smith
4a897f70c3
Merge pull request #2962 from ulwlu/fix_prompt_string_when_creating_remote_repository
Fix prompt string when creating remote repository
2021-02-17 12:32:27 -06:00
Mislav Marohnić
c148a9ba24
Merge pull request #2989 from cli/pr-merge-immediate-edit
pr merge: avoid prompting to enter editor after editing phase is chosen
2021-02-17 19:26:17 +01:00
Mislav Marohnić
a90997ec95 pr merge: avoid prompting to enter editor after editing phase is chosen
When user chooses "Edit commit message", open the editor immediately
instead of showing an additional prompt to open the editor.
2021-02-17 18:47:17 +01:00
Mislav Marohnić
70d4786e37
Merge pull request #2988 from cli/strict-status-checks-base
pr status: fix checking branch protection rules on the base branch
2021-02-17 18:13:15 +01:00
Mislav Marohnić
05421db404 pr status: fix checking branch protection rules on the base branch
Instead of checking branch protection rules on the main branch of the
repository, branch protection rules for a specific PR should be checked
on its base branch, since not all PRs are based on the main branch.

Additionally, do not display "Up to date" if the actual merge status
reported from the server was "UNKNOWN" or "DIRTY", since in those cases
"Up to date" could be false information.
2021-02-17 18:04:49 +01:00
Mislav Marohnić
3b117e6c3c
Merge pull request #2539 from divyaramanathan/issue-create-template
Implementing issue template GraphQL API call
2021-02-17 17:59:42 +01:00