STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11279 commits 87 branches 0 tags 160 MiB
Commit graph

11279 commits

This branch
This branch
All branches
Author SHA1 Message Date
Nate Smith
d25938e223
Merge pull request #2808 from KarelCoudijzer/fork-hang 
Show progress while creating a new pull request
 2021-01-21 14:54:15 -08:00
vilmibm
05d39ebd0d remove garbling spinner 
one of the three new spinners produced less than ideal output when a
push happened; the other two do enhance the create experience and i
think we can get away without one for push.
 2021-01-21 14:53:19 -08:00
Sam Coe
11e873c669
Cleanup impossible code path 2021-01-21 14:45:06 -08:00
Sam Coe
7cc2975a98
Fix tests 2021-01-21 14:42:42 -08:00
Nate Smith
3a9e47bf1b
Merge pull request #2664 from cristiand391/gist-friendly-error 
Print friendly error when 'gh gist <command>' is missing required argument
 2021-01-21 14:41:03 -08:00
Sam Coe
a305ff1488
Split apart interactive merge survey function 2021-01-21 14:00:33 -08:00
Sam Coe
2d782fcb46
Retrieve repo outside of survey function 2021-01-21 13:13:58 -08:00
Nate Smith
29805a4003
Merge pull request #2588 from cdce8p/gh-clone-fetch 
Only fetch default branch when adding upstream remote
 2021-01-21 12:57:10 -08:00
vilmibm
b906826a68 i like trunk 2021-01-21 12:56:53 -08:00
Sam Coe
71a66cc8d6
Fix merge 2021-01-21 12:53:04 -08:00
Sam Coe
a9123966e3
Merge branch 'trunk' into 1190-limit-merge-methods 2021-01-21 12:45:10 -08:00
vilmibm
dcedd32249 use newer command stubbing in tests 2021-01-21 12:32:40 -08:00
Nate Smith
4860cccd72
Merge pull request #2282 from cristiand391/repo-fork-gitflags 
Add support for git flags in gh repo fork
 2021-01-21 12:11:42 -08:00
vilmibm
48c89076f6 add positive case test 2021-01-21 12:04:19 -08:00
vilmibm
a27a94f8b5 Merge remote-tracking branch 'origin/trunk' into repo-fork-gitflags 2021-01-21 11:58:20 -08:00
Nate Smith
14b8047032
Merge pull request #2803 from cli/expectlines-deprecate 
Deprecate `test.ExpectLines`
 2021-01-21 11:45:20 -08:00
Sam
938f6f4bdd
Merge pull request #2809 from cli/deadcode 
delete unused parameter
 2021-01-21 09:56:15 -08:00
Sam
948088a143
Merge pull request #2776 from cli/pr-comments 
Comment on pull requests
 2021-01-21 09:55:52 -08:00
Mislav Marohnić
a70b69e359
Bring the "Press Enter" UI closer to the authentication experience 
- "Press Enter" is both bold
- "Enter" is capitalized
- The prompt ends with "..."
 2021-01-21 09:47:38 -08:00
Sam Coe
a26fba7800
Comment on pull requests 2021-01-21 09:47:38 -08:00
Mislav Marohnić
10b1314dc1 Hide ssh-key command until it's ready for prime-time 2021-01-21 17:55:44 +01:00
Mislav Marohnić
f89346f335
Merge pull request #2748 from cli/makefile-rewrite 
Port build tasks to Go script
 2021-01-21 17:36:36 +01:00
Mislav Marohnić
ad62d6a471
Merge pull request #2798 from cli/pr-merge-crossrepo 
Handle case when a cross-repo PR was already merged
 2021-01-21 17:36:00 +01:00
Mislav Marohnić
4158209d50
Merge pull request #2811 from cli/utils-spinner-buh-bye 
Retire utils.Spinner in favor of IOStreams.StartProgressIndicator
 2021-01-21 17:34:39 +01:00
Mislav Marohnić
3673a9beb2 Add more documentation for script/build.go 2021-01-21 17:16:11 +01:00
Mislav Marohnić
f1a9da40a4
Merge pull request #2812 from cli/updater-dev-version-match 
Update notifier: avoid false positives when gh is built from source
 2021-01-21 15:11:23 +01:00
Nate Smith
655728965d
Merge pull request #1882 from dfireBird/remote-renaming-847 
feat: implement prompt for remote renaming
 2021-01-20 16:19:10 -08:00
vilmibm
509e5dd0c9 fix tests 2021-01-20 16:10:56 -08:00
vilmibm
99c312e8ce accept a remote name instead of doing magic remote naming in repo fork 2021-01-20 15:32:19 -08:00
vilmibm
03f99a0140 Merge remote-tracking branch 'origin/trunk' into remote-renaming-847 2021-01-20 15:10:20 -08:00
Nate Smith
5430728a0a
Merge pull request #2813 from cli/token-from-env-err 
More descriptive error when aborting auth due to environment variables
 2021-01-20 15:06:52 -08:00
Björn Heinrichs
c9f79271b1
Add --maintainer-edit flag (#2250) 
* Add --maintainer-edit flag

Closes #2213 while retaining backwards compatibility.

* Fix linting

* Adjust documentation and validation

* Negate logic and fix build errors

* rename to no-maintainer-edit

* test

* use a positive option instead of negative

Co-authored-by: vilmibm <vilmibm@github.com>
 2021-01-20 14:51:27 -08:00
Sam
3bec668aaa
Merge pull request #2757 from cli/review-comments 
Display reviews when viewing pull requests
 2021-01-20 12:22:03 -08:00
Sam Coe
b9b1079493
Display reviews when viewing pull requests 2021-01-20 12:15:25 -08:00
Mislav Marohnić
dcf5a27f53
Merge pull request #1862 from edualb/trunk 
[#1755] SSH key management (gh ssh-key list)
 2021-01-20 20:47:21 +01:00
Mislav Marohnić
4a2cc8d2a4 Simplify ssh-key list 
Do not require nor request `read:public_key` scope by default.
 2021-01-20 20:23:57 +01:00
edualb
e26a1b98a1 add ssh-key command 2021-01-20 20:23:38 +01:00
Cristian Dominguez
2086d135f3
Respect system/user timezone in API requests (#2630) 
* Respect system/user timezone in API requests

* Fall back to a known timezone if TZ is not set

Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
 2021-01-20 10:44:46 -08:00
Mislav Marohnić
c9407b2629 More descriptive error when aborting auth due to environment variables 
Old message:

    read-only token in GH_TOKEN cannot be modified

This message was vague and some users did not understand that this
refers to the value that is read from environment variables.

New message:

    $ GH_TOKEN=123 ghd auth login -h github.com
    The value of the GH_TOKEN environment variable is being used for authentication.
    To have GitHub CLI store credentials instead, first clear the value from the environment.
 2021-01-20 18:27:35 +01:00
Mislav Marohnić
82d19b73d6 Update notifier: avoid false positives when gh is built from source 
When gh was built from source, the version number will look something
like this since it's taken from `git describe`:

    v1.4.0-34-g{SHA}

When compared as semver against `v1.4.0`, the latter version is falsely
reported as newer. This is because the output of `git describe` wasn't
meant to be interpreted as semver.

The solution is to translate the `git describe` string to faux-semver so
it can be safely compared with the version reported from the server.

Fixes this case:

    A new release of gh is available: v1.4.0-41-g2f9e4cb1 → v1.4.0
    https://github.com/cli/cli/releases/tag/v1.4.0
 2021-01-20 16:13:50 +01:00
Mislav Marohnić
a2bee1fad3 🔥 utils.Spinner 2021-01-20 14:48:14 +01:00
Mislav Marohnić
aa0de5f636 Stop using utils.Spinner in repo fork 2021-01-20 14:46:45 +01:00
Peter Kristensen
bc7f733267 Add body argument to pr merge command. 2021-01-20 13:24:27 +01:00
vilmibm
3797aa72ff delete unused parameter 2021-01-19 19:08:49 -08:00
Karel Coudijzer
a7b9e3916c Show progress while creating pr 2021-01-19 22:19:10 +01:00
Mislav Marohnić
b5366c6ebf
Merge pull request #2794 from cristiand391/use-testify-assertion 
Use Testify assertions in tests
 2021-01-19 14:08:25 +01:00
Mislav Marohnić
75ebb863e3 Use testify assertions for error matching 2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087 Equal: flip arguments position 2021-01-18 21:00:59 -03:00
Mislav Marohnić
fc77cbc964 Deprecate test.ExpectLines 
For asserting command output, exact string matches are preferred in most cases. In cases when a pattern match is needed, the test can use regexp ad hoc.
 2021-01-18 23:25:45 +01:00
Mislav Marohnić
411bd4a70e 🔥 unused test/fixtures/ 2021-01-18 22:53:03 +01:00