Commit graph

11279 commits

Author SHA1 Message Date
Daniel Leong
a33124414c Add a test to verify the behavior of prepending commit body to message 2020-09-08 20:12:28 -04:00
Daniel Leong
c4227455e3 Prepend PR body defaults to the selected template (if any)
See #1570
2020-09-08 20:12:28 -04:00
Nate Smith
74614b13da
Merge pull request #1627 from giacomoalbe/add-commit-headline-to-pr-merge
Add PR Title to CommitHeadline during merge PR
2020-09-08 17:05:26 -05:00
Nate Smith
c2d7cbf51f
Merge pull request #1582 from AliabbasMerchant/interactiveCreationTests
Interactive template selection test for issue create
2020-09-08 16:55:04 -05:00
vilmibm
e59431eeef more ubuntus 2020-09-08 16:26:25 -05:00
vilmibm
338f37d6aa support extant ubuntu LTSs 2020-09-08 16:11:15 -05:00
Lee Reilly
527a1e466f Add auth command and flag usage to README 2020-09-08 14:07:33 -07:00
Nate Smith
ab2c38eb82
Merge pull request #1563 from cli/checks
gh pr checks
2020-09-08 15:58:38 -05:00
Amanda Pinsker
14c4331a51
tweak availability language 2020-09-08 12:46:45 -04:00
Amanda Pinsker
e10bbdd24f
Flip docs and feedback sections 2020-09-08 12:45:07 -04:00
Amanda Pinsker
032c9ddbc6
Update README.md 2020-09-08 12:12:09 -04:00
Mislav Marohnić
72e9747662
Merge pull request #1626 from cli/ghe-auth-tweaks
Make GitHub remote parsing and authentication stricter
2020-09-08 10:14:29 +02:00
Mislav Marohnić
d13e6b300e
Merge pull request #1635 from cli/table-width-fix
Fix measuring terminal width for output
2020-09-08 10:01:15 +02:00
Mislav Marohnić
22b3ce66ad
Merge pull request #1615 from cli/linux-pkg
linux repository automation
2020-09-08 09:57:28 +02:00
Mislav Marohnić
d77a8c2e61 Scope pr merge commit headline to only squash method 2020-09-07 22:27:27 +02:00
Mislav Marohnić
fae66a62e4 Fix measuring terminal width for output 2020-09-07 22:03:54 +02:00
Mislav Marohnić
ece17c4ce2 Add GITHUB_ENTERPRISE_TOKEN mention to api help 2020-09-07 21:37:55 +02:00
Mislav Marohnić
c80292c2e8 Extend Config object with GITHUB_TOKEN support
Adding GITHUB_TOKEN & GITHUB_ENTERPRISE_TOKEN support orthogonal to
Config was getting out of hand, especially in `auth` commands that
adjust their messaging and error status based on the presence of these
environment variables.

The new approach builds in support for tokens from environment straight
into Config object by composition. Thus, commands need not ever be
concerned with any specific environment variables.
2020-09-07 21:33:26 +02:00
Mislav Marohnić
feadf684fb Merge remote-tracking branch 'origin' into ghe-auth-tweaks 2020-09-07 17:37:16 +02:00
Mislav Marohnić
9109b68344
Merge pull request #1625 from cli/api-no-accept
Avoid setting a default `Accept` header in `hub api`
2020-09-07 17:30:12 +02:00
Mislav Marohnić
016df6af1c Consolidate Linux installation docs
- Move all Linux installation docs to the separate page to eliminate repetition
- Indicate that only Ubuntu 20.04 is supported for apt-add-repository method
- Pull openSUSE/SUSE out of the "unofficial" section since it refers to
  downloading our official packages
- Point out manual installation methods as well
2020-09-07 17:06:03 +02:00
Mislav Marohnić
44a500e50f Remove Homebrew tap from goreleaser config
Our tap is now deprecated in favor of `gh` from homebrew-core
2020-09-07 16:28:51 +02:00
Mislav Marohnić
a983131479 Exercise most of the release process on prereleases
- deb and rpm packages are now built for prereleases
- consolidate setup for deb & rpm
- man pages are generated for prereleases
- the `cli.github.com` site is only pushed to on full releases

Bonus:
- only publish the GitHub release after the Windows MSI is uploaded
- hub does not need downloading
2020-09-07 16:11:27 +02:00
Mislav Marohnić
a0e0f31363 Disable ANSI color in prompts when color is disabled 2020-09-07 13:10:43 +02:00
Mislav Marohnić
d38a0c5d84 Encapsulate checking color-controlling environment variables 2020-09-07 13:10:43 +02:00
Mislav Marohnić
84b1b36433 Simplify handling the "broken pipe" error 2020-09-07 12:41:28 +02:00
Mislav Marohnić
5e11fe8fa0
Merge pull request #1623 from bdougie/bdougie-filter-credit-bots
Filter gh credits for humans
2020-09-07 11:44:59 +02:00
Brian 'bdougie' Douglas
d83c99f87f filter by contributor type 2020-09-06 22:02:02 -07:00
Mislav Marohnić
ccfe38de26 Add PAGER support to commands that produce significant output 2020-09-04 23:36:14 +02:00
Giacomo Alberini
cab0e0f43d Add pr Title and number to commitHeadline in merge request 2020-09-04 23:07:51 +02:00
Mislav Marohnić
d01355e24b Add global PAGER support
Extract the ad-hoc PAGER behavior from `pr diff` command and make it
available opt-in to any command through IOStreams.
2020-09-04 23:07:17 +02:00
Mislav Marohnić
ca2f2b18ca Add support for CLICOLOR "standard"
The CLICOLOR_FORCE environment variable can now be used to force color
output even when stdout is redirected. https://bixense.com/clicolors/
2020-09-04 21:32:58 +02:00
Mislav Marohnić
995828abf8 Avoid setting a default Accept header in hub api
Due to our HTTP client default behavior, an `Accept` header is added to
all API requests. This is fine for all commands except `gh api`, where
the user should ideally have fine-grained control over most aspects of
HTTP requests and where there should be little to no defaults in general.
2020-09-04 17:42:57 +02:00
Mislav Marohnić
2bb5e052d8 Send GITHUB_TOKEN to github.com and GITHUB_ENTERPRISE_TOKEN to GHES 2020-09-04 17:25:37 +02:00
Mislav Marohnić
3e7a2585c5 Tighten git remote URL parsing
We now only support git URLs that have one of the explicitly supported protocols.
2020-09-04 16:18:26 +02:00
Mislav Marohnić
6ceea6e531
Merge pull request #1616 from cli/display-width-punctuation
Fix detecting display width of common punctuation characters
2020-09-04 16:04:43 +02:00
ShubhankarKG
05a39b732a Fix tests 2020-09-04 18:58:15 +05:30
ShubhankarKG
147cdcdbb4 Add extra confirm step and a flag 2020-09-04 18:24:31 +05:30
vilmibm
deb92f93a6 update linux installation docs 2020-09-03 14:54:35 -05:00
vilmibm
eb132a1ae6 Merge remote-tracking branch 'origin/trunk' into checks 2020-09-03 14:48:32 -05:00
vilmibm
894be03923 linux repo creation 2020-09-03 13:47:48 -05:00
Mislav Marohnić
a470d49c64 Fix reporting release URL when creating with assets 2020-09-03 16:06:28 +02:00
Mislav Marohnić
1ad9b0b14e Have FindDraftRelease be truer to its name 2020-09-03 15:35:07 +02:00
Mislav Marohnić
d4b45c68e2 Allow downloading assets from the latest release 2020-09-03 15:34:10 +02:00
Mislav Marohnić
151a7340a6 Fix .zip and .js overrides for Windows 2020-09-03 11:44:54 +02:00
Mislav Marohnić
02a057a709 Try fixing Windows tests 2020-09-02 22:11:46 +02:00
Mislav Marohnić
b93c896561 Upgrade text/width package 2020-09-02 21:01:39 +02:00
Mislav Marohnić
1f86e7cd04 Fix display width of common punctuation characters
These characters get classified as "East Asian Mixed" by Go's
`text/width` package, and thus assumed that their printed version
occupies a width of 2 characters, whereas they each only occupy one.

I'm not sure why they are classified as East Asian, but I did not have
the energy to dive into Go's Unicode tables, so here is a workaround
based on an exclusion list.
2020-09-02 20:59:11 +02:00
Sam
00836079dd
Merge pull request #1600 from cli/update-readme
Remove feedback survey from README
2020-09-02 19:42:40 +02:00
vilmibm
2961c655fb review feedback 2020-09-02 11:33:39 -05:00