Commit graph

11279 commits

Author SHA1 Message Date
Toshiya Doi
fbff7226ac Add comments on review state values 2020-04-10 04:51:42 +09:00
Toshiya Doi
2df5281f2f Merge branch 'master' into reviewers-in-pr-view 2020-04-10 04:46:05 +09:00
Billy Griffin
8518b8255a
Update contributing to reflect something closer to reality 2020-04-09 13:40:03 -06:00
Mislav Marohnić
d14b5d3e2c
Merge pull request #764 from cli/pr-view-docs
Improve `issue/pr/repo view` documentation
2020-04-09 19:12:34 +02:00
Nate Smith
3c335104c5
Merge pull request #748 from doi-t/add-pr-metadata-to-view
Add relevant metadata to pr view in CLI
2020-04-09 12:12:18 -05:00
Mislav Marohnić
7f9aef6c0d
Merge pull request #761 from cli/completion-fixes
Improve `completion` command
2020-04-09 19:10:36 +02:00
Toshiya Doi
6223a2c198 Puts completed reviews before review requests and sort reviewer names alphabetically 2020-04-10 01:16:43 +09:00
Toshiya Doi
6d0e5bf2b8 Remove Participants related codes for pr view` 2020-04-10 01:02:51 +09:00
Toshiya Doi
054ec3c635 Remove Participants related codes 2020-04-10 00:56:45 +09:00
Toshiya Doi
531bfbc295 Update unit tests for PR metadata 2020-04-08 20:07:19 +09:00
Mislav Marohnić
a6495a8c0d
Merge pull request #733 from michaelld/add_MP_to_readme
add MacPorts usage info
2020-04-08 12:27:30 +02:00
Mislav Marohnić
60e7bb6243
Tweak macOS installation docs 2020-04-08 12:26:15 +02:00
Mislav Marohnić
d1754b2bb0 Improve issue/pr/repo view documentation
- Short-form docs for `pr/repo view` no longer say "in browser"

- Long-form docs for all these commands now list more information about
  what will be displayed in the terminal, plus stressing out the
  alternate behavior with the `--web` flag.

- `--web` flag docs: add English articles
2020-04-08 12:04:39 +02:00
Toshiya Doi
5c261e2318 Give a color to reviewer states 2020-04-08 16:27:30 +09:00
Toshiya Doi
bc42228171 Parses Reviews and ReviewRequests to show reviewers and their state 2020-04-08 16:27:30 +09:00
Toshiya Doi
cef525a0a2 Update unit tests for PR metadata 2020-04-08 16:27:10 +09:00
Toshiya Doi
d07617817d Query first 100 issue metadata by PR number and branch (3 --> 100) 2020-04-08 14:53:55 +09:00
Toshiya Doi
542314a9c3 Omit participants metadata from pr view 2020-04-08 14:53:23 +09:00
Toshiya Doi
9169c8d0eb Update unit tests for issue metadata 2020-04-08 14:48:08 +09:00
Toshiya Doi
24fcc69f9e Query first 100 issue metadata by issue number (3 --> 100) 2020-04-08 14:47:46 +09:00
Toshiya Doi
d600709e9e Omit participants metadata from issue view 2020-04-08 13:50:13 +09:00
Mislav Marohnić
2915abc2ba Improve user-friendliness of completion command
When ran directly in the terminal, the command now errors out with:

    $ gh completion
    error: the value for `--shell` is required
    see `gh completion --help` for more information

This is to avoid the previously default bash code output confusing the
user if they ran the command out of curiousity.

A backwards compatibility layer is present here: if stdout is not a
terminal, then output bash code like before. This is to support users
who have already added a line like this to their bash profile:

    eval "$(gh completion)"
2020-04-07 16:58:50 +02:00
Mislav Marohnić
79f749a02b Avoid checking for updates during gh completion
This is due to the fact that `gh completion` can be programatically used
during shell startup and we definitely don't want to
1. slow down people's startup time
2. show any upgrade notice until the user has invoked `gh` manually
2020-04-07 16:46:36 +02:00
Mislav Marohnić
c0c28622bd
Merge pull request #754 from cli/long-from
spell out PR text
2020-04-07 11:13:39 +02:00
Tiernan L
1aba837589
update text to long-form
Change from "repo" to "repository".  Run "gh repo clone -h` to see the usage text I am referring to.

We use the word "repository" here:

Usage:
  gh repo fork [<repository>] [flags]

Usage:
  gh repo view [<repository>] [flags]
2020-04-06 11:27:17 -10:00
Tiernan L
806574f9c1
spell out PR
changes "PR" ---> "pull request" for consistency and clarity
2020-04-06 09:56:45 -10:00
Mislav Marohnić
e878cdf060
Merge pull request #752 from lumaxis/feature/fetch-upstream-after-adding
Fetch upstream remote after adding it

Fixes #731
2020-04-06 19:48:14 +02:00
Toshiya Doi
8fca78f584 Query first 100 requestedReviewer and last 100 reviews 2020-04-06 17:56:51 +09:00
Toshiya Doi
a4fcb634c2 Fix requestedReviewer struct 2020-04-06 17:53:41 +09:00
Lukas Spieß
7e1ed5f9a3
Fetch upstream remote after adding it 2020-04-05 20:54:29 +02:00
Toshiya Doi
f14459c451 Clean up unnecessary fmt.Sprintf 2020-04-04 15:11:57 +09:00
Toshiya Doi
d5bff70259 Clean up unnecessary fmt.Sprintf 2020-04-04 15:09:22 +09:00
Toshiya Doi
92dea433e4 An attempt of collecting reviewers metadata 2020-04-04 13:28:47 +09:00
Toshiya Doi
85d8f808f2 Test pr metadata in CLI preview 2020-04-04 13:14:34 +09:00
Toshiya Doi
0cb6890c74 Print pr metadata in CLI preview 2020-04-04 13:09:34 +09:00
Toshiya Doi
d538f7a1be Query pr metadata by number and branch 2020-04-04 13:08:22 +09:00
Toshiya Doi
125ff06b2c Add metadata to PullRequest struct 2020-04-04 13:07:44 +09:00
Toshiya Doi
5a17962188 Add a new line to test a dynamic string of metadata 2020-04-04 12:53:22 +09:00
Toshiya Doi
13864131c0 Rename issue metadata list functions to avoid naming conflicts with pr 2020-04-04 11:28:52 +09:00
Toshiya Doi
1279131f0f Simplify issue struct avoiding to sue edges 2020-04-04 11:28:52 +09:00
Toshiya Doi
97cad74d75 Add a new line even an issue Body content is empty 2020-04-04 11:28:52 +09:00
Toshiya Doi
8c697a0d99 Test issue metadata in CLI preview 2020-04-04 11:28:52 +09:00
Toshiya Doi
bfb3501cf9 Print issue metadata in CLI preview 2020-04-04 11:28:52 +09:00
Toshiya Doi
6dbf821198 Query issue metadata by number 2020-04-04 11:28:52 +09:00
Toshiya Doi
013481c0d6 Add metadata to issue struct 2020-04-04 11:28:52 +09:00
Mislav Marohnić
e10ccefaf5
Merge pull request #667 from doi-t/view-the-current-state
Show the state (open, closed, merged) in issue view and pr view
2020-04-03 19:41:29 +02:00
Mislav Marohnić
43b28f769b
Merge pull request #727 from thefotios/respect-clone-target
Respect clone target

Closes #721
2020-04-03 19:18:05 +02:00
Mislav Marohnić
250114e2c0
Merge pull request #742 from brettbuddin/no-color
Support NO_COLOR environment variable to disable color
2020-04-03 19:10:16 +02:00
Mislav Marohnić
baeb86a401
Merge pull request #734 from cli/golangci-lint
Check code with golangci-lint on push
2020-04-03 17:35:40 +02:00
Mislav Marohnić
ee2456f3c0 Don't build during linting
Building is already covered in CI workflows that run tests
2020-04-03 16:51:47 +02:00