Commit graph

11279 commits

Author SHA1 Message Date
Mislav Marohnić
030c997301 Avoid long first line of gh help
This splits help text over paragraphs and lines to make the output of
`gh` easier to read. It takes care not to go over 80 characters in width
and wraps the URL in `<...>` which will help the URL get auto-linked
when these docs are converted to man and HTML formats.
2019-12-16 15:55:21 +01:00
Mislav Marohnić
48aeff1ca7 Assert stdout separarely from stderr in command tests
This stubs stderr separately from stdout in command tests (before those
streams were combined) and improves test assertions around output.

Additionally, no longer use the `cmd.Print*()` family of Cobra functions
because their name sounds like the text will go to stdout, but they
write to stderr instead. Use the more explicit `cmd.ErrOrStderr()` as
output destination instead.
2019-12-16 15:46:42 +01:00
Mislav Marohnić
d7513ef3f6 Fix test assertion when running on Windows 2019-12-16 14:56:44 +01:00
Mislav Marohnić
57c7266328 Fix displaying "There are no issues assigned to you" notice 2019-12-16 14:08:55 +01:00
Mislav Marohnić
5d6b095f1a Add "Opening URL in your browser" notice to issue create --web 2019-12-16 13:39:22 +01:00
Corey Johnson
d1905f5824 update comment 2019-12-13 16:17:28 -08:00
Corey Johnson
9becb5f790 Have one place manage the config dir location 2019-12-13 16:16:46 -08:00
Mislav Marohnić
e93ab66107 Merge pull request #147 from github/pr-to-pull-request
Consistently use "pull request" instead of "PR" in user-facing copy
2019-12-13 17:14:17 +01:00
Mislav Marohnić
caa1c49c6c Merge pull request #151 from github/less-aggressive-checking
Only check for new version once every 24 hours
2019-12-13 17:09:26 +01:00
Mislav Marohnić
b7191e3a6f Simplify case when state.yml is non-existent or corrupt
- non-existent file simply returns an error
- corrupt file (e.g. YAML unmarshal error) also returns an error
- if there were errors, just check for new release normally instead of aborting
2019-12-13 17:04:07 +01:00
Corey Johnson
0bfd8213e2 Merge pull request #144 from github/better-better-better
Better error messages when you don't supply an arg
2019-12-12 11:31:26 -08:00
Corey Johnson
2979c5fc4c Use embeding 2019-12-12 11:27:22 -08:00
Corey Johnson
9b5f7a8148 Use new error.As method 2019-12-12 11:09:50 -08:00
Corey Johnson
10ca1e7646 Whitespace cleanup 2019-12-11 16:53:00 -08:00
Corey Johnson
23fdd730e9 Less 🌭 2019-12-11 16:52:16 -08:00
Corey Johnson
6f339285b5 Whoops 2019-12-11 16:48:48 -08:00
Corey Johnson
9428df4597 Fix tests 2019-12-11 16:48:33 -08:00
Corey Johnson
deac6da2f4 Add state yml 2019-12-11 15:53:46 -08:00
Nate Smith
0f970e6328 Merge pull request #150 from github/vilmibm-patch-1
s/-B/-T
2019-12-11 15:51:55 -06:00
Nate Smith
995093591b s/-B/-T 2019-12-11 15:03:23 -06:00
Corey Johnson
92642f4d53 Create NotFoundError 2019-12-11 10:58:59 -08:00
Corey Johnson
2218e60264 Label as pull request 2019-12-11 10:24:58 -08:00
Corey Johnson
573dda22a1 Simplify flag setting 2019-12-11 10:19:18 -08:00
Mislav Marohnić
cc7b2f0ea8 Consistently use "pull request" instead of "PR" in user-facing copy 2019-12-11 09:31:57 +01:00
Corey Johnson
53ed20f32a Fix test 2019-12-10 16:15:37 -08:00
Corey Johnson
748b213c9a Add error details for gh issue view 2019-12-10 16:04:04 -08:00
Corey Johnson
9b40efcad5 Add better gh pr view message 2019-12-10 16:03:10 -08:00
Corey Johnson
5296f72189 Better messaging for gh pr checkout 2019-12-10 16:03:05 -08:00
Corey Johnson
5949ca4b56 Merge pull request #142 from github/empty-pr-list
Add empty state for `gh pr list`
2019-12-10 12:04:41 -08:00
Corey Johnson
71add1baf5 Merge pull request #130 from github/rm-obsolete-fixtures
Cleanup: remove unused fixture files
2019-12-09 09:10:51 -08:00
Corey Johnson
4de0a76234 Merge pull request #141 from github/add-url-branch-to-usage
Add better usage docs for `gh pr view` `gh pr checkout` `gh issue view`
2019-12-06 14:39:43 -08:00
Corey Johnson
e9cbf8f3ba Merge pull request #143 from github/newlines-are-the-devils-whitespace
Don't display newlines in pr and issue lists
2019-12-06 14:34:56 -08:00
Corey Johnson
eb414bf2a1 Add a little test 2019-12-06 14:33:04 -08:00
Corey Johnson
f70473c234 Replace excessive whitespace 2019-12-06 14:32:55 -08:00
Corey Johnson
00b38bb11c Add better message to empty gh issue list 2019-12-06 14:10:01 -08:00
Corey Johnson
9aa3f35f8a Better language in the "no pr" state 2019-12-06 13:33:57 -08:00
Corey Johnson
387b9d9544 better name? 2019-12-06 13:33:23 -08:00
Corey Johnson
f1eb29b791 Add colorableErr 2019-12-06 13:32:36 -08:00
Mislav Marohnić
5f90cdc801 Elaborate on what is accepted as issue/PR arguments 2019-12-06 18:01:36 +01:00
Mislav Marohnić
4b8921f011 Consistently use {} to denote mutually exclusive options 2019-12-06 18:01:14 +01:00
Mislav Marohnić
8222e7d74f Consistently use <> to denote placeholders 2019-12-06 17:59:36 +01:00
Corey Johnson
bbb91d6a2a Replace newlines 2019-12-05 14:12:12 -08:00
Corey Johnson
fee303699a Show message when there are no PRs 2019-12-05 12:01:05 -08:00
Corey Johnson
196cdddb5e Merge pull request #140 from github/wtf-finder
Don't open PRs in the finder
2019-12-05 11:42:06 -08:00
Corey Johnson
cce2fd4a22 Add better usage docs 2019-12-05 11:40:36 -08:00
Corey Johnson
50fccd796a not needed 2019-12-05 09:58:45 -08:00
Corey Johnson
ee7f6339ae Return url for PRs 2019-12-05 09:54:30 -08:00
Mislav Marohnić
9425d33b3d Merge pull request #127 from github/help-site
Generate help docs to GitHub Pages
2019-12-05 18:37:46 +01:00
Corey Johnson
7c1390d02d Merge pull request #131 from github/move-config-to-folder
Move config to a directory
2019-12-04 15:53:34 -08:00
Corey Johnson
ae68acb901 Move to context package 2019-12-04 15:39:25 -08:00