Babak K. Shandiz
df8c9a317d
Update run_log.zip fixture
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:29 +01:00
Babak K. Shandiz
5e78832a7e
Fallback to print entire job run log if step logs are missing
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:29 +01:00
Babak K. Shandiz
f7efdde5ef
Add Log to Job data structure
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:28 +01:00
Babak K. Shandiz
4dee1c3c98
Add jobLogFilenameRegexp function
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:28 +01:00
Babak K. Shandiz
2582948d5f
Extract job name sanitization as a separate function
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-04-07 13:54:20 +01:00
Andy Feller
918cafc222
Deprecate ColorScheme.Gray for ColorScheme.Muted
...
This commit converts all of the places using ColorScheme.Gray and ColorScheme.Grayf to Muted and Mutedf.
There is a little extra tidying up with local variable names or converting code to use Mutedf format.
2025-04-06 10:18:48 -04:00
Kynan Ware
e21243fe9b
ci: pin third party actions to commit sha
2025-04-04 21:45:54 -06:00
Kynan Ware
f89700160b
doc(prompter): clarify comments
2025-04-04 15:08:17 -06:00
Kynan Ware
0b49522467
refactor(prompter): less magic strings
2025-04-04 15:07:21 -06:00
Kynan Ware
2e48cadf58
fix(prompter): remove impossible condition
2025-04-04 15:05:23 -06:00
Kynan Ware
5c39e0bd10
fix(prompter): notes about Confirm default
2025-04-04 14:52:25 -06:00
Kynan Ware
4cf048a8d1
fix(prompter): input returns default when blank
2025-04-04 11:33:10 -06:00
Kynan Ware
5b0d49c6ec
test(prompter): more tests for bad input
2025-04-04 11:06:40 -06:00
Andy Feller
e067eacd81
Refactor ColorScheme initializer
...
This commit completely removes the iostreams.NewColorScheme() initializer function in favor of exporting the type fields for greater clarity in its use.
The result being code specifying only the fields that matter to test cases.
2025-04-04 11:57:37 -04:00
Andy Feller
addbc6ac5c
Add label color env var to help topic, unused fix
...
This commit adds the new environment variable to the `gh environment` help topic.
Additionally, there is a small fix for Go linter for an unused variable raised as a problem.
2025-04-04 11:02:44 -04:00
Andy Feller
e9a12853cb
Merge branch 'trunk' into andyfeler/colorize-label-optin
2025-04-04 09:47:41 -04:00
Barak Amar
06d22d96c0
handle find pr number 0
2025-04-04 11:14:02 +03:00
Kynan Ware
a30df14b6a
refactor(prompter): rename env var for speech synthesizer friendly prompter
2025-04-03 13:08:16 -06:00
Kynan Ware
49ddacf5b8
docs(prompter): doc prompter interface
2025-04-03 13:06:31 -06:00
Meredith Lancaster
579fae19c9
Merge branch 'trunk' into move-predicate-type-filtering
2025-04-03 11:20:21 -06:00
Meredith Lancaster
69507282d2
restore deleted file
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-03 11:07:06 -06:00
Meredith Lancaster
164a56cb66
move filterAttestations function
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-03 11:02:45 -06:00
Kynan Ware
02fc12e7b7
fix(linter): linter errors
2025-04-03 08:51:54 -06:00
Kynan Ware
88e6285b49
test(prompter): move to external package
2025-04-03 08:45:58 -06:00
Kynan Ware
8827803bd1
test(prompter): skip vt10x tests on Windows
2025-04-03 08:25:33 -06:00
Andy Feller
5f03c208a1
Fix comment language
2025-04-02 18:32:37 -04:00
Andy Feller
3eca268a7f
Introduce color_labels support, update commands
...
This commit implements the actual changes around configuration setting / environment variable logic for displaying labels using their RGB hex color code in terminals with truecolor support.
One of the subtler changes in this commit is renaming generic ColorScheme.HexToRGB logic to render truecolor to ColorScheme.Label as this feature was being used exclusively for labels. This is due to confusion about introducing the new `color_labels` config on top of generic coloring logic.
2025-04-02 18:24:20 -04:00
Andy Feller
b52c131d4c
Merge pull request #10709 from cli/andyfeller/table-datetime-contrast-github-cli-832
...
Ensure table datetime columns have thematic, customizable muted text
2025-04-02 17:20:15 -04:00
Kynan Ware
e299b56c0f
test(prompter): remove needless variable declaration
2025-04-02 13:08:36 -06:00
Kynan Ware
e42af35839
tests(prompter): rename huhprompter
2025-04-02 13:00:46 -06:00
Kynan Ware
0d7fd36f11
test(prompter): replace assert with require
2025-04-02 12:58:44 -06:00
Kynan Ware
94bbd26aab
fix(prompter): rename huhprompter
2025-04-02 12:56:44 -06:00
Kynan Ware
f7de9e0c11
test(prompter): go-expect based prompter tests
2025-04-02 12:56:44 -06:00
Kynan Ware
88a98ea63a
feat(prompter): include no as false-y value
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-02 11:58:10 -06:00
Lucas Holt
af87389a19
Add instructions for MidnightBSD installation
2025-04-02 09:09:36 -04:00
William Martin
bab2bc8172
Acceptance test issue/pr create/edit with project ( #10707 )
2025-04-02 14:50:10 +02:00
Meredith Lancaster
56d924d25b
getAttestations unit tests
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-01 12:58:37 -06:00
Meredith Lancaster
f43ec0079b
add test for predicate type filtering
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-01 11:52:13 -06:00
Meredith Lancaster
13dafefcb5
add missing nil struct checks and udpate error messages
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-01 11:23:25 -06:00
Meredith Lancaster
cdfb1b7279
Merge branch 'move-predicate-type-filtering' of github.com:malancas/cli into move-predicate-type-filtering
2025-04-01 11:16:05 -06:00
Meredith Lancaster
05d9156a99
add check for nil api client
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-04-01 11:16:00 -06:00
Meredith Lancaster
a04be55092
Merge branch 'trunk' into move-predicate-type-filtering
2025-04-01 10:48:13 -06:00
Kynan Ware
92b1a8e0f0
test(prompter): remove t.parallel calls
...
t.Parallel() cannot be used when env vars are being set.
2025-03-31 16:01:16 -06:00
Kynan Ware
e973ee332d
fix(md prompter): accessible prompt allows blank
...
Allow the accessible markdownEditor prompt to be blank when the blank
comes from the result of an interactive session with an editor, even when
blankAllowed is false.
This behavior aligns the accessible prompter with the behavior of the
current standard prompter.
2025-03-31 15:58:20 -06:00
Kynan Ware
7b0c09541d
feat(md prompter): md prompt respects blankAllowed
...
Accessible prompter now respects blankAllowed and
will not prompt for "skip" if blankAllowed is false.
2025-03-31 15:52:26 -06:00
Kynan Ware
202c1ad16b
feat(prompter): add accessible prompter support
2025-03-31 15:04:57 -06:00
Andy Feller
b3c8c70cba
Remove deprecated note on gray color functions
...
Without fixing all ColorScheme.Gray and ColorScheme.Grayf usage in this pull request, golangci-lint throws errors for using deprecated functions.
As that code should be replaced within github/cli#833 , I'm removing the deprecation indicator for now to get this PR passing.
2025-03-31 17:00:40 -04:00
Andy Feller
e36d795629
Regenerate mocks
2025-03-31 15:59:18 -04:00
Andy Feller
1bf1ad282b
Remove configuration setting vestage
2025-03-31 15:58:37 -04:00
Andy Feller
de86cc6c15
Remove out of scope configuration setting change
2025-03-31 15:57:37 -04:00