STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
11279 commits 87 branches 0 tags 160 MiB
Commit graph

11279 commits

This branch
This branch
All branches
Author SHA1 Message Date
Meredith Lancaster
5d26f0b767 skip check 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-15 14:39:22 -07:00
Meredith Lancaster
daf63543ea add tty check 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-15 14:33:13 -07:00
Meredith Lancaster
423a764f2a
Merge branch 'trunk' into update-attestation-verify-table-output 2025-01-15 14:25:38 -07:00
Meredith Lancaster
4fb265c597 formatting 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-15 14:22:05 -07:00
Meredith Lancaster
6d2f71d0f4 delete unused function 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-15 14:17:49 -07:00
Meredith Lancaster
4967eaff8b Merge branch 'update-attestation-verify-table-output' of github.com:malancas/cli into update-attestation-verify-table-output 2025-01-15 14:13:22 -07:00
Meredith Lancaster
555c9b65f5 drop unused handler method 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-15 14:13:16 -07:00
Meredith Lancaster
2ffce8ae9f print attestation output info as bullet points instead of table 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-15 14:11:54 -07:00
dependabot[bot]
2757d22b4b
Bump google.golang.org/protobuf from 1.36.2 to 1.36.3 
Bumps google.golang.org/protobuf from 1.36.2 to 1.36.3.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-01-15 14:49:31 +00:00
William Martin
e7ffb1e435 Fix typo in secret base repo selection comment 2025-01-15 14:55:18 +01:00
William Martin
88a64d2a11 Change wording on secret repo prompt 2025-01-15 14:55:17 +01:00
William Martin
b382b24728 Print informative message before prompting for secret repo 2025-01-15 14:55:17 +01:00
William Martin
a47327aee6 Secret base repo prompting should not use resolved remote 
This is because the secret commands don't use the SmartBaseRepo behaviour, and therefore
don't care about the resolved remote.
 2025-01-15 14:55:17 +01:00
William Martin
ce47fabc27 Move secret base repo prompting earlier 2025-01-15 14:55:17 +01:00
William Martin
5630252f78 Add acceptance test for secrets remote disambiguation 2025-01-15 14:55:17 +01:00
William Martin
d831e3e1db Remove validated TODO and add review warning 2025-01-15 14:55:17 +01:00
William Martin
4da4c82090 Rename secret BaseRepo func 2025-01-15 14:55:17 +01:00
William Martin
870da79886 Use smarter base repo funcs for secret commands 2025-01-15 14:55:17 +01:00
William Martin
73244c010e Move secret repo validation into secrets subpackage 2025-01-15 14:55:17 +01:00
William Martin
df8bb51c9c Always prompt on secret set when multiple remotes 2025-01-15 14:55:17 +01:00
Wing
0be5720c1c Update setdefault test 2025-01-15 14:55:17 +01:00
Wing
cad59036f5 Update docs for set-default 
NOTE: gh does not use the default repository for managing repository and environment secrets.
 2025-01-15 14:55:17 +01:00
Wing
3de2fd94b3 Prompt for secret commands 
Co-authored-by: William Martin <williammartin@github.com>
 2025-01-15 14:55:16 +01:00
Wing
57c9ee0ad2 Add tests for secret commands 
Co-authored-by: William Martin <williammartin@github.com>
 2025-01-15 14:55:16 +01:00
Wing
88988374b5 Add remote check to secret commands 
Co-authored-by: William Martin <williammartin@github.com>
 2025-01-15 14:55:16 +01:00
Tyler McGoffin
adc5f01d23
Merge pull request #10214 from cli/dependabot/go_modules/github.com/sigstore/protobuf-specs-0.3.3 
Bump github.com/sigstore/protobuf-specs from 0.3.2 to 0.3.3
 2025-01-14 16:08:39 -08:00
Tyler McGoffin
018438088e Add missing git stubs to tests 2025-01-14 16:02:41 -08:00
Tyler McGoffin
12ee8b7a86
Merge pull request #10154 from danochoa/gh-gist-delete-prompt 
gh gist delete: prompt for gist id
 2025-01-14 14:42:13 -08:00
Tyler McGoffin
3feeb9a826 Add tests for deleteGist 2025-01-14 14:21:49 -08:00
Rajhans Jadhao
10d4d27d8c
Merge branch 'trunk' into rerun-err-msg 2025-01-14 15:04:15 +05:30
Tyler McGoffin
48e2681017 Merge branch 'trunk' into find-pr-by-rev-parse-push 
A recent refactor caused the API for ReadBranchConfig to change, resulting
in changes for its consumers. Additionally, there was a large refactor of
the tests associated with ReadBranchConfig and its consumers to gain
confidence in this refactor. This commit attempts to resolve the
conflicts between the refactor and this effort as well as massage the
changes introduced here to reflect the refactor.

The refactor PR can be found here: https://github.com/cli/cli/pull/10197

I'll note that there are still a few failing tests in status_test.go. I
haven't had a chance to fully grok while they are failing, yet, and
suspect that some insights from the original PR author may be helpful
here.

Full disclaimer: I haven't verified any of this is working locally yet.
My primary motivation is to get these new changes working together in a
manner that unblocks further iteration on this effort.

* trunk: (79 commits)
  Enhance help docs on ext upgrade notices
  chore: fix some function names in comment
  Expand docs on cleaning extension update dir
  Simplifying cleanExtensionUpdateDir logic
  Separate logic for checking updates
  Capture greater detail on updaterEnabled
  Restore old error functionality of prSelectorForCurrentBranch
  Change error handling on ReadBranchConfig to respect git Exit Codes
  fix: add back colon that I removed
  fix: actually read how MaxFunc work and simplify the code
  fix: padded display
  Collapse dryrun checks in ext bin upgrade
  Bump github.com/mattn/go-colorable from 0.1.13 to 0.1.14
  Rename test user in tests
  Change pr number in test
  Surface and handle error from ReadBranchConfig in parseCurrentBranch
  Directly stub headBranchConfig in Test_tryDetermineTrackingRef
  Refactor error handling in ReadBranchConfig to avoid panic
  Refine error handling of ReadBranchConfig
  Add test for empty BranchConfig in prSelectorForCurrentBranch
  ...
 2025-01-13 20:38:00 -08:00
Daniel A. Ochoa
3370bc8a04
Merge branch 'trunk' into gh-gist-delete-prompt 2025-01-13 21:17:23 -06:00
Andy Feller
bc8c46b0b1 Make extension update check non-blocking 
Fixes #10235

This commit updates the Cobra command logic around extension upgrade checks to be non-blocking.

Previously, we were waiting for 1 second after the extension completed to allow the update checking logic complete, however users want the GitHub CLI to run as far as possible.
 2025-01-13 20:38:03 -05:00
Meredith Lancaster
ab26df324f
Merge branch 'trunk' into update-attestation-verify-table-output 2025-01-13 14:46:54 -07:00
Meredith Lancaster
2ddfe865f4
Update pkg/cmd/attestation/verify/verify.go 
Co-authored-by: Phill MV <phillmv@github.com>
 2025-01-13 13:02:05 -07:00
Meredith Lancaster
1d807c2291 add missing return statement 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 12:50:58 -07:00
Meredith Lancaster
611eb86e68 method update 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 12:47:25 -07:00
Meredith Lancaster
b7f6af03b5 update no attestations found err 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 12:42:10 -07:00
Meredith Lancaster
fc0d0210c0 remove old tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 12:21:27 -07:00
AMS21
960f533234
add install instructions for Manjaro Linux 2025-01-13 20:01:28 +01:00
Meredith Lancaster
5462582401 drop unneeded methods 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 11:05:17 -07:00
Meredith Lancaster
40e7353b52 deduplicate get attestation code 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 11:02:33 -07:00
Tyler McGoffin
6fe21d8f52
Merge pull request #10197 from cli/jtmcg/remove-named-returns 
Remove naked return values from `ReadBranchConfig` and `prSelectorForCurrentBranch`
 2025-01-13 09:55:17 -08:00
Meredith Lancaster
4d99ae920c fix tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 10:34:06 -07:00
Meredith Lancaster
d60f6c24d0 Merge branch 'trunk' into attestation-bundle-fetch-improvements 2025-01-13 08:34:43 -07:00
Meredith Lancaster
c7d04c980b update testing 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-01-13 08:34:15 -07:00
dependabot[bot]
7300f0d568
Bump github.com/gabriel-vasile/mimetype from 1.4.7 to 1.4.8 
Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype) from 1.4.7 to 1.4.8.
- [Release notes](https://github.com/gabriel-vasile/mimetype/releases)
- [Commits](https://github.com/gabriel-vasile/mimetype/compare/v1.4.7...v1.4.8)

---
updated-dependencies:
- dependency-name: github.com/gabriel-vasile/mimetype
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-01-13 15:23:32 +00:00
Meredith Lancaster
112552fec1
Merge pull request #10185 from malancas/fetch-artifact-attestation-bundles-with-sas-url 2025-01-13 08:20:33 -07:00
Mateus Marquezini
4eb0e8138f
Merge branch 'trunk' into fix/issue_10042 2025-01-13 11:47:52 -03:00
Mateus Marquezini
c0f6eb0598 #10042: Attempt to add a new test scenario for handling error messages when TTY is unavailable 2025-01-13 11:39:48 -03:00