Commit graph

11279 commits

Author SHA1 Message Date
Meredith Lancaster
4431fa9d8f add test for signerRepo and tenant
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-18 06:55:00 -07:00
Meredith Lancaster
86b815e9bf add some more fields to test that san, sanregex are set properly
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-18 06:49:08 -07:00
William Martin
d3f6ad491e
Merge pull request #10094 from cli/dependabot/go_modules/github.com/cpuguy83/go-md2man/v2-2.0.6
Bump github.com/cpuguy83/go-md2man/v2 from 2.0.5 to 2.0.6
2024-12-17 18:02:52 +01:00
dependabot[bot]
ede6c4de1a
Bump github.com/cpuguy83/go-md2man/v2 from 2.0.5 to 2.0.6
Bumps [github.com/cpuguy83/go-md2man/v2](https://github.com/cpuguy83/go-md2man) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/cpuguy83/go-md2man/releases)
- [Commits](https://github.com/cpuguy83/go-md2man/compare/v2.0.5...v2.0.6)

---
updated-dependencies:
- dependency-name: github.com/cpuguy83/go-md2man/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-12-17 14:41:05 +00:00
Meredith Lancaster
83770d8e55 update san and sanregex configuration for readability
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 18:42:29 -07:00
Meredith Lancaster
9acd0c7e06 Merge branch 'consolidate-verify-policy-options-config' of github.com:malancas/cli into consolidate-verify-policy-options-config 2024-12-16 17:06:41 -07:00
Meredith Lancaster
1df2976e81 reduce duplication when creating policy content
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 17:06:36 -07:00
Meredith Lancaster
f3982b278c add more verification integration tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 16:57:05 -07:00
Meredith Lancaster
ab4912ff48 fix failing tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 12:40:13 -07:00
Meredith Lancaster
e4431a3f55 add mock http client
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 12:22:20 -07:00
Meredith Lancaster
fb020f2a79 update error messages
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 12:13:22 -07:00
Meredith Lancaster
8f5d7100f5 var naming
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 12:02:52 -07:00
Meredith Lancaster
45121f6674 go mod tidy
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 12:02:42 -07:00
Meredith Lancaster
6b95175363 add httpClient field to LiveClient struct
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 11:57:45 -07:00
Meredith Lancaster
e51b4efaa9 remove unused method
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 11:50:46 -07:00
Meredith Lancaster
5a6a7968a3 fetch bundles with sas url
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-16 11:25:43 -07:00
Meredith Lancaster
08f6e2f943
Merge branch 'trunk' into consolidate-verify-policy-options-config 2024-12-16 08:08:09 -07:00
Meredith Lancaster
64bf37e31c
Merge pull request #10051 from malancas/gh-attestation-download-windows-bug
Use Windows compatible file name for downloaded attestations when running `gh attestation download`
2024-12-16 08:01:36 -07:00
nilvng
3987f4af4a chore: remove unused file 2024-12-15 18:08:45 +11:00
nilvng
55598d0a2c feat: integrate new PRLister into pr list command 2024-12-15 18:04:51 +11:00
nilvng
91b3b99b76 issue #2329: create shared PRLister 2024-12-15 17:53:00 +11:00
nilvng
d7cabf18f7 fix: tab format may break checkout prompts 2024-12-15 13:55:47 +11:00
nilvng
1f525bf175 issue #2329: handle empty list of PR 2024-12-15 12:34:46 +11:00
Andy Feller
edc0351c85 Fix failig local extension tests
Extensions have to be gh- prefixed and these newer tests were failing because of expectation.
2024-12-13 23:20:42 -05:00
Andy Feller
bfc63a14cc Implement remaining PR feedback
After merging in upstream changes regarding local extensions, this commit addresses remaining PR feedback while also bringing the newly merged tests into alignment with other changes.
2024-12-13 23:09:18 -05:00
Andy Feller
5ad6ccf73a Merge branch 'trunk' into andyfeller/cli-cli-8183-timeout-pt2 2024-12-13 22:53:13 -05:00
Andy Feller
c12e3694e8 Implement partial feedback before trunk update 2024-12-13 22:52:03 -05:00
Nilln
de13d7b721
Merge branch 'trunk' into nil/fix-2329 2024-12-14 11:03:22 +11:00
Tyler McGoffin
a50fc7079e
Merge pull request #10055 from jobegrabber/improve-apt-setup-script
Improve error handling in apt setup script
2024-12-13 15:16:37 -08:00
Meredith Lancaster
7160f7ef50 Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2024-12-13 15:25:00 -07:00
Meredith Lancaster
90f5dae82b Merge branch 'trunk' into consolidate-verify-policy-options-config 2024-12-13 15:23:01 -07:00
Meredith Lancaster
9b905d9f18
Merge pull request #9891 from malancas/print-policy-info 2024-12-13 15:14:05 -07:00
Phill MV
dd95e5a863 tweak output of build policy info 2024-12-13 15:55:49 -05:00
Kynan Ware
b3f74900f2
Merge pull request #10078 from cli/10077-gh-pr-view-cannot-find-pr-from-branch-when-fork-is-in-the-same-org-as-upstream
Support `pr view` for intra-org forks
2024-12-13 11:44:43 -07:00
Phill MV
c789b56da4
Merge pull request #9954 from cli/phillmv/improve-gh-at-inspect 2024-12-13 09:50:52 -05:00
William Martin
d662226ae4 Name conditionals in PR finder 2024-12-13 14:33:33 +01:00
William Martin
96ac8d6a2f Support pr view for intra-org forks 2024-12-13 14:27:41 +01:00
Kynan Ware
c35d725b0b
Merge pull request #10074 from cli/kw/cli-7011-fix-delete-branch-with-merge-queue-v2
`gh pr merge --delete-branch` exits with error when merge requested via merge queue
2024-12-12 16:05:06 -07:00
Kynan Ware
253b082600 Return err instead of silentError in merge queue check 2024-12-12 15:54:01 -07:00
Meredith Lancaster
76ffe4fb28
Merge pull request #9999 from malancas/sigstore-verifier-cleanup
Sigstore verifier logic updates
2024-12-12 15:10:52 -07:00
Phill MV
cae97c9da8 linting pointed out this var is no longer used 2024-12-12 17:00:02 -05:00
Phill MV
75cbdc0d04 Removed fun, but inaccessible ASCII header 2024-12-12 16:58:26 -05:00
Phill MV
85f9cfdccb further tweaks to the long description 2024-12-12 16:56:02 -05:00
Kynan Ware
439cfa08bb Exit on pr merge with -d and merge queue
When running `gh pr merge -d` on a repo with a merge queue policy, exit before attempting to merge.
2024-12-12 14:49:38 -07:00
Phill MV
94943eac10 Merge branch 'phillmv/improve-gh-at-inspect' of github.com:cli/cli into phillmv/improve-gh-at-inspect 2024-12-12 16:47:11 -05:00
Phill MV
94525f83f6 Addressed PR review feedback; expanded Long command help string, used ghrepo, clarified some abbreviations 2024-12-12 16:46:58 -05:00
Phill MV
e7f3d739ba
Update pkg/cmd/attestation/inspect/inspect.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-12-12 16:20:56 -05:00
Andy Feller
5e9283c70c
Merge pull request #10026 from ankddev/better-document-auth-scopes
docs: better document auth scopes
2024-12-12 11:16:14 -05:00
Andy Feller
4f32282f93 Update gh auth commands to point to GitHub Docs
After initial discussion with core maintainers, it didn't seem prudent to duplicate the GitHub Docs information on OAuth scopes within the GitHub CLI codebase.

Instead, this commit updates help usage information in relevant commands on the page within GitHub Docs for more information.
2024-12-12 11:03:57 -05:00
Kynan Ware
e2422b7e7e
Merge pull request #9933 from cli/kw/improve-ext-installation-no-executable-error
Improve documentation and error messaging for local extension installations without executables
2024-12-12 07:08:16 -07:00