Commit graph

11279 commits

Author SHA1 Message Date
Meredith Lancaster
cfbc1c7e10 wording
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 12:16:12 -07:00
Meredith Lancaster
6ca5e6f18c add newlines for additional policy info
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 11:42:39 -07:00
Meredith Lancaster
63f37eb369 pr feedback
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:24:25 -07:00
Meredith Lancaster
30ae1388e4
Update pkg/cmd/attestation/download/download.go
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:19:41 -07:00
Meredith Lancaster
762e99d151 fix function param calls
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:19:07 -07:00
Meredith Lancaster
c518a3b1f5
Update pkg/cmd/attestation/verification/extensions.go
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:18:04 -07:00
Fredrik Skogman
075691b03e
Formatting fix
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-11-18 15:17:34 +01:00
Fredrik Skogman
601982faf1
Updated formatting to be more clear
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-11-18 15:16:47 +01:00
Fredrik Skogman
5098ea407a
Updated markdown syntax for a note.
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-11-18 14:48:34 +01:00
Fredrik Skogman
9168a5d7d8
Added a section on manual verification of the relases.
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-11-18 14:12:44 +01:00
bagtoad
c5497b4d28 Document requirements for local extensions 2024-11-17 21:01:49 -07:00
bagtoad
b575fe8ebc Warn when installing local ext with no executable 2024-11-17 21:01:49 -07:00
Andy Feller
7b91b17395 Refactor extension command testing
This commit allows for stubbing/mocking the function used for checking update release info.  Additionally, this does a minor refactor moving from non-blocking to blocking channel.
2024-11-17 21:59:06 -05:00
Andy Feller
0d3f7cae4e Bring extension update check in line with gh check
This commit is a bit of refactoring to bring the extension update checking logic up to par with what is done with `gh` including creation of state file per extension and listening to env vars for disabling version checking.

This work is not complete as it does not address necessary test changes.
2024-11-17 16:10:58 -05:00
nilvng
36eaf14857 issue #2329: improve UI/UX
Improve the interactive PR selection UI by
- prefix the PR number with hashcode #
- perserve the text formatting (bold) upon an option is hovered
- add the PR head label

Technical changes:
- Replace \033[0m with \033[39m for maintaining text formatting
2024-11-17 23:47:36 +11:00
nilvng
c6c27113fe issue #2329: add happy path unit test 2024-11-17 16:36:10 +11:00
nilvng
1832c1a767 issue #2329: fix the linting issue 2024-11-17 14:58:38 +11:00
nilvng
4386fcb4e5 issue #2329: fix the unit tests issue - ensure its backward compatible 2024-11-17 14:57:48 +11:00
Nillin
49b10b745d
Merge branch 'trunk' into nil/fix-2329 2024-11-17 13:47:29 +11:00
bagtoad
68f3ef79ca Handle missing "workflow" scope in createRelease 2024-11-16 19:32:37 -07:00
Kynan Ware
9decf1b526
Merge pull request #9905 from cli/9904-gh-repo-create-to-work-on-bare-repos
Support bare repo creation
2024-11-15 12:08:26 -07:00
Kynan Ware
04e2a5dd63
Merge branch 'trunk' into 9904-gh-repo-create-to-work-on-bare-repos 2024-11-15 11:56:31 -07:00
Meredith Lancaster
a56ff4a0eb wording
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-14 10:29:24 -07:00
Meredith Lancaster
91577594de formatting
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-14 10:20:48 -07:00
Andy Feller
cd3f2ad064
Merge pull request #9920 from cli/andyfeller/github-cli-676-improved-visibility
Mention GitHub CLI team on discussion issues
2024-11-14 10:44:45 -05:00
Andy Feller
e64742cc84
Merge commit from fork
adding username validation to the invoker ssh server
2024-11-14 10:44:15 -05:00
Andy Feller
d4262f8183 Mention GitHub CLI team on discussion issues 2024-11-14 10:31:36 -05:00
Kynan Ware
8990b1c7df
Merge pull request #9914 from cli/andyfeller/cli-cli-8183-timeout
Shorten extension release checking from 3s to 1s
2024-11-13 11:33:48 -07:00
Andy Feller
b8ef951de1 Shorten extension release checking from 3s to 1s
Addressing feedback from extension author demonstration about a noticable pause waiting for extension execution to complete due to amount of time waiting on channel.
2024-11-13 13:04:01 -05:00
William Martin
7bcb063391 Modify push prompt on repo create when bare 2024-11-11 16:17:06 +01:00
William Martin
8e63268aba Doc push behaviour for bare repo create 2024-11-11 16:10:32 +01:00
William Martin
e3665955a5 Push --mirror on bare repo create 2024-11-11 16:09:03 +01:00
William Martin
6a97dbfadf Add acceptance test for bare repo create 2024-11-11 15:51:52 +01:00
William Martin
2efb9935db Doc isLocalRepo and git.Client IsLocalRepo differences 2024-11-11 14:18:26 +01:00
William Martin
f515e9c1e7 Use errWithExitCode interface in repo create isLocalRepo 2024-11-11 14:17:29 +01:00
William Martin
bc85e11d05 Backfill repo creation failure tests 2024-11-11 14:11:16 +01:00
William Martin
4a7f2e57b0 Support bare repo creation 2024-11-11 13:57:05 +01:00
Sarah Barili
a02f84528a
Update internal/codespaces/rpc/invoker.go
Co-authored-by: Caleb Brose <5447118+cmbrose@users.noreply.github.com>
2024-11-08 09:11:44 -07:00
Meredith Lancaster
43e5abbcd8 use logger println method
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 15:50:46 -07:00
Tyler McGoffin
9b9e654c76
Merge pull request #9866 from andyfeller/andyfeller/cli-cli-8183
Check extension for latest version when executed
2024-11-07 14:48:12 -08:00
Andy Feller
3ec657d087 Enhance extension upgrade tests for URL 2024-11-07 17:35:59 -05:00
Meredith Lancaster
e4cd729a7b simplify verifyCertExtensions
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 14:59:21 -07:00
Meredith Lancaster
8ab5f247af rename type
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 14:47:53 -07:00
Meredith Lancaster
ff9b6bb883 refactor fetch attestations funcs
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 14:39:11 -07:00
Meredith Lancaster
c7e4411a88 print policy information before verifying
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 13:16:13 -07:00
Meredith Lancaster
07e9a4a19d add initial policy info method
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-07 11:08:58 -07:00
Meredith Lancaster
6d4c74b252
Merge pull request #9856 from malancas/verify-attestation-monotonic-tests 2024-11-07 07:45:25 -07:00
Andy Feller
54c0739659
Delete .github/workflows/licenses.yml 2024-11-06 23:18:43 -05:00
Andy Feller
e629443a2c
Delete .github/licenses.tmpl 2024-11-06 23:18:32 -05:00
Andy Feller
ddf7287ab8 Test extension command update behaviors
This commit expands upon the previous work by creating tests around extension command execution and how various extension update scenarios are handled.

Along the way, the logic handling formatting update messaging has been switched to use `ColorScheme` in order to honor color behavior flags.
2024-11-06 22:49:02 -05:00