Edmundo Gonzalez
ee36a005b1
Merge remote-tracking branch 'origin/main' into edgonmsft/codespaces-ssh-rpc
2021-08-30 05:01:22 +00:00
Edmundo Gonzalez
13917a289d
Moved function to ssh.go file.
2021-08-30 04:52:27 +00:00
Edmundo Gonzalez
5db9e2d83e
PR changes.
2021-08-30 04:48:56 +00:00
Jose Garcia
634796e8a8
merge main
2021-08-27 18:18:30 -04:00
Jose Garcia
0cf2640c86
better docs and stop ticker
2021-08-27 18:14:10 -04:00
Jose Garcia
272af2fadf
add docs
2021-08-27 18:12:06 -04:00
Jose Garcia
a5a18026cc
fix linter
2021-08-27 17:39:10 -04:00
Jose Garcia
368e8c6110
simplify contract for state polling
2021-08-27 17:34:06 -04:00
Jose Garcia
1e8a8370fe
initial round of PR feedback
2021-08-27 16:29:02 -04:00
Jose Garcia
2cc91c224e
add comment for improvements
2021-08-27 12:53:27 -04:00
Jose Garcia
cb6552f4ca
more efficient impl for processing states
2021-08-27 12:50:32 -04:00
Alan Donovan
38ff786a7d
cmd/ghcs: style tweaks
2021-08-27 12:03:20 -04:00
Edmundo Gonzalez
d5a26e1536
Apply renames on the go-liveshare side.
2021-08-26 23:14:13 +00:00
Edmundo Gonzalez
b6094e0006
Changes to point to RPC service.
2021-08-26 21:50:20 +00:00
Mislav Marohnić
11fbb60ae7
Rename the module to "github.com/cli/cli/v2"
2021-08-25 12:41:30 +02:00
Jose Garcia
46ee45bcdd
simplify the state iteration
2021-08-24 17:46:24 -04:00
Jose Garcia
55f0dad3db
merge upstream
2021-08-19 18:30:10 +00:00
Sam
8fb6bb66c8
Merge pull request #3992 from despreston/858-config-browser
...
add browser option to config
2021-08-17 14:17:54 -07:00
Sam Coe
315c6e4eb7
Remove backwards compatibility with homedir library for config files
2021-08-17 10:28:16 -07:00
Sam Coe
34b3d5bb86
Add tests and a little polish
2021-08-17 10:05:54 -07:00
Mislav Marohnić
b47686163a
Fixes for log/output streams
2021-08-17 13:04:55 +02:00
Mislav Marohnić
20d75f0ff9
Normalize logging, output, and error reporting
...
- Return errors as errors, not print to stdout and return nil
- Ensure errors and warnings are always written to stderr, not stout
- Do not print progress to stdout unless stdout is a terminal
2021-08-12 14:37:23 +02:00
Jose Garcia
76aca39f5b
Create status support
2021-08-04 17:35:11 +00:00
Jose Garcia
e57b390d4a
dotfiles status spike
2021-08-03 13:42:34 +00:00
Jose Garcia
58a055609d
logs cmd spike and refactor of ssh tunnel methods
2021-07-29 10:57:51 -04:00
Jose Garcia
9544f8acc9
Commit vendors
2021-07-28 09:05:58 -04:00
Mislav Marohnić
aec0f10041
Fix error message when using GH_ENTERPRISE_TOKEN but host is ambiguous
...
Before:
$ GH_ENTERPRISE_TOKEN="..." gh pr create
could not find hosts config: not found
Now:
$ GH_ENTERPRISE_TOKEN="..." gh pr create
set the GH_HOST environment variable to specify which GitHub host to use
Also amends `gh help environment` documentation to suggest the use of
GH_HOST when scripting operations with GitHub Enterprise repositories.
2021-07-20 14:11:07 +02:00
Mislav Marohnić
25b6eecc8d
Merge pull request #4017 from despreston/des/avoid-migrate
...
Skip auto migrate of config when GH_CONFIG_DIR
2021-07-20 13:33:16 +02:00
Des Preston
1c9b4bf99d
Skip auto migrate of config when GH_CONFIG_DIR
...
If GH_CONFIG_DIR is set, don't auto migrate the config file. This fixes
the situation where the path given via GH_CONFIG_DIR does not exist and
the cli attempts to migrate an existing config to that location.
Fixes #3837
2021-07-19 16:33:51 -04:00
Jose Garcia
798413848b
Portfowarding private/public/forward now supported
2021-07-17 20:32:47 -04:00
Des Preston
c95f30af80
add browser option to config
...
Allows setting the path to the browser using the config.
Closes #858
2021-07-13 15:07:57 -04:00
Sam Coe
b514d22f1e
Fix issue in FindEntry that causes extensions and alias crash
2021-06-29 15:01:00 -07:00
jonathan gold
5f162561ac
Add config handling for http_unix_socket
2021-06-25 11:47:22 -07:00
jonathan gold
fb54cae00e
Add package httpunix
2021-06-25 11:26:21 -07:00
Sam Coe
e6ad8a10d0
Add support for XDG_DATA_HOME
2021-06-02 09:46:14 -04:00
Sam Coe
1d7ffc2013
Add support for LocalAppData and .local/state/ fallback
2021-06-01 15:50:10 -04:00
Sam Coe
602167c0c7
Address PR comments
2021-05-26 11:28:58 -04:00
Sam Coe
583e74d70c
Add support for XDG_STATE_HOME
2021-05-25 16:30:51 -04:00
Sam Coe
972d5ff5f0
Fix test that was deleting local config folder
2021-05-24 18:35:37 -04:00
Sam Coe
0d49bfba42
Add support for XDG_CONFIG_HOME and AppData on Windows
2021-05-24 16:13:33 -04:00
Mislav Marohnić
e0e25c82ff
Fix creating Windows directory for gh config
2021-05-19 17:13:12 +02:00
Cristian Dominguez
2f94adabb2
Use T.TempDir for temporary dirs in tests ( #3580 )
2021-05-07 12:21:26 +02:00
Mislav Marohnić
c57e30fff0
Fix stubbing config in tests on Windows
2021-04-22 11:42:51 +02:00
Mislav Marohnić
c6c3e72f43
Unexport StubConfig
2021-04-22 11:42:28 +02:00
Junjie Yuan
927e4c7e4d
using filepath.Join() instead of path.Join() to fix wrong filepath on Windows:
...
PS C:\Users\Junjie Yuan> gh auth status
github.com
✓ Logged in to github.com as junjieyuan (C:\Users\Junjie Yuan\.config\gh/hosts.yml)
✓ Git operations for github.com configured to use https protocol.
✓ Token: *******************
Signed-off-by: Junjie Yuan <yuan@junjie.pro>
2021-04-22 15:19:16 +08:00
Sam Coe
ee687d7e7f
Add tests for quick fix
2021-04-02 08:42:19 -07:00
Mislav Marohnić
69ca2dda4a
Quick fix: respect default hostname when parsing owner/repo pairs
...
This re-enables using GH_HOST to set a default hostname when
supplying repo argument like `gh repo clone owner/repo`.
2021-04-02 15:16:27 +02:00
Mislav Marohnić
44ae7ae3cf
Merge pull request #3279 from cli/browser-refactor
...
Pass web browser to each individual command
2021-03-30 16:54:59 +02:00
Sam
9ec1e21d4c
Default to GHES host if only GHES is authenticated ( #3286 )
2021-03-30 16:51:00 +02:00
Mislav Marohnić
111e8dbcf2
Pass web browser to each individual command
...
This removes sensitivity to the BROWSER environment variable in tests
and makes it easier to verify the URL that the browser was invoked with
without having to stub sub-processes.
2021-03-19 21:22:37 +01:00
