Andy Feller
0180c7fce4
Restored original test setup, clarified
...
After discussing my previous change to the test, I'm restoring the previous keyring setup to reflect the specific situation.
I added clarifying comments to help the next reviewer.
2025-06-20 15:38:09 -04:00
Andy Feller
b7c2b19e70
Enhance Activetoken prioritize test
...
- ensure test user tokens are different from unkeyed token
- ensure assertion expected / actual are in correct order
2025-06-20 14:36:45 -04:00
Eugene
98d7135ccc
Merge branch 'trunk' into eugene/release-verify
2025-06-20 06:50:04 -07:00
ejahnGithub
169b909015
improve the description for gh release verify cmd
2025-06-19 10:18:23 -04:00
William Martin
dc7b22b659
Merge pull request #11149 from jinjingroad/trunk
...
chore: fix function name
2025-06-19 11:31:49 +02:00
jinjingroad
28d5de9d8e
chore: fix function name
...
Signed-off-by: jinjingroad <jinjingroad@sina.com>
2025-06-19 12:36:52 +08:00
Anuraag Agrawal
12a41333c3
Merge branch 'trunk' of https://github.com/cli/cli into active-token-user
2025-06-18 09:57:09 +09:00
Anuraag Agrawal
848cedd2c8
Push up
2025-06-18 09:56:44 +09:00
Eugene
524aee8cfb
Merge branch 'trunk' into eugene/release-verify
2025-06-17 08:20:37 -07:00
William Martin
d9d0e14e85
Merge pull request #11145 from cli/kw/fix-step-order-in-codeql-workflow
...
Fix step order for CodeQL workflow
2025-06-17 17:03:43 +02:00
William Martin
b5613cdbbe
Merge pull request #10699 from laffer1/patch-1
...
Add instructions for MidnightBSD installation
2025-06-17 16:55:53 +02:00
Eugene
898bb42719
Merge branch 'trunk' into eugene/release-verify
2025-06-17 07:54:26 -07:00
William Martin
9cf0c73ae4
Merge pull request #10935 from MagneticNeedle/patch-1
...
docs: update install command for Debian
2025-06-17 16:54:02 +02:00
William Martin
6b36060d58
Update docs/install_linux.md
2025-06-17 16:43:25 +02:00
Kynan Ware
50e4a4ad15
Fix step order for CodeQL workflow
2025-06-17 08:41:14 -06:00
Vibhakar Solanki
1ac3f064f3
docs: update install command for Debian
...
Make sure that `sources.list.d` exists before trying to populate `github-cli.list`
2025-06-17 16:39:58 +02:00
William Martin
e51b03d989
Merge pull request #10888 from aconsuegra/ac/fix-acceptance-test-output
...
Fix expected error output of TestRepo/repo-rename-transfer-ownership
2025-06-17 16:26:16 +02:00
William Martin
8deae3038a
Use active token stubbing on auth config
2025-06-17 15:53:13 +02:00
William Martin
fb35097dec
Merge pull request #11120 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.20.6
...
chore(deps): bump github.com/google/go-containerregistry from 0.20.3 to 0.20.6
2025-06-17 12:39:04 +02:00
dependabot[bot]
f55443d7b0
chore(deps): bump github.com/google/go-containerregistry
...
Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry ) from 0.20.3 to 0.20.6.
- [Release notes](https://github.com/google/go-containerregistry/releases )
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml )
- [Commits](https://github.com/google/go-containerregistry/compare/v0.20.3...v0.20.6 )
---
updated-dependencies:
- dependency-name: github.com/google/go-containerregistry
dependency-version: 0.20.6
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-06-17 10:05:53 +00:00
William Martin
fe3bf3eeca
Merge pull request #11142 from cli/bump-go-to-1.24
...
Bump go to 1.24
2025-06-17 12:04:08 +02:00
William Martin
49ed6c4681
Use t.Chdir in tests
2025-06-17 11:44:14 +02:00
William Martin
b4cd2273d8
Bump to Go 1.24
2025-06-17 11:44:14 +02:00
William Martin
86c251154e
Merge pull request #11121 from cli/11101-use-golangci-lint-version-2
...
Bump golangci-lint to v2
2025-06-17 11:43:14 +02:00
William Martin
d9a2ffbf06
Merge pull request #11123 from cli/dependabot/go_modules/github.com/in-toto/attestation-1.1.2
...
chore(deps): bump github.com/in-toto/attestation from 1.1.1 to 1.1.2
2025-06-17 10:07:05 +02:00
William Martin
ac6fe9c96b
Merge pull request #11134 from cli/11119-suggested-run-list-command-for-workflows-with-space-in-name-doesnt-work
...
Quote filenames suggested at the end of worklow run
2025-06-17 09:55:15 +02:00
Kynan Ware
6224368f2e
Merge pull request #11135 from cli/kw/improve-help-wanted-check
...
Improve help wanted check skipping logic
2025-06-16 13:29:59 -06:00
Andy Feller
14c2673d27
Merge branch 'trunk' into andyfeller/9422-license-compliance
2025-06-16 15:27:28 -04:00
Kynan Ware
9e161cda4e
Apply suggestion from @Copilot
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-06-16 13:20:20 -06:00
Kynan Ware
fa3402f783
Improve help wanted check skipping logic
2025-06-16 13:11:37 -06:00
William Martin
8e5ed00ad7
Merge pull request #11133 from cli/wm/execute-gh
...
Ensure gh executes in workflow check script
2025-06-16 21:02:50 +02:00
William Martin
31b3dc1ba6
Ensure gh executes in workflow check script
2025-06-16 20:46:24 +02:00
William Martin
cc8cfbe77b
Merge pull request #11128 from cli/kw/fix-file-not-found-in-help-wanted-workflow-2
...
Second fix for file not found in help-wanted check
2025-06-16 20:18:00 +02:00
Kynan Ware
2609b4e283
Merge branch 'trunk' into kw/fix-file-not-found-in-help-wanted-workflow-2
2025-06-16 11:59:31 -06:00
Kynan Ware
7d1b5d2ce0
Fix repo checkout in help-wanted check
2025-06-16 11:47:48 -06:00
Andy Feller
8532997a4b
Merge pull request #11127 from cli/andyfeller/11126-ghas-ignore-3rd-party-source
...
Exclude 3rd party license compliance content from GHAS scanning
2025-06-16 13:45:42 -04:00
Andy Feller
c7b1afd293
Fixes #11126
...
These changes will cause GitHub Advanced Security to ignore the auto-generated content around 3rd party dependencies used by `cli/cli` from static code analysis and secret scanning.
For more information:
- https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning
- https://docs.github.com/en/code-security/secret-scanning/using-advanced-secret-scanning-and-push-protection-features/excluding-folders-and-files-from-secret-scanning
2025-06-16 13:36:37 -04:00
Andy Feller
f652fd76dc
Merge pull request #11125 from cli/kw/fix-file-not-found-in-help-wanted-workflow
...
Fix script path for help-wanted check
2025-06-16 13:14:18 -04:00
Kynan Ware
7fa213251c
Fix script path for help-wanted check
2025-06-16 10:14:38 -06:00
William Martin
cfc45042dc
Merge pull request #11122 from cli/fix-pr-help-wanted-draft-if
...
Quote workflow conditional
2025-06-16 18:05:53 +02:00
William Martin
da9ed6a336
Quote filenames suggested at the end of worklow run
2025-06-16 18:02:47 +02:00
dependabot[bot]
32a7400e22
chore(deps): bump github.com/in-toto/attestation from 1.1.1 to 1.1.2
...
Bumps [github.com/in-toto/attestation](https://github.com/in-toto/attestation ) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/in-toto/attestation/releases )
- [Commits](https://github.com/in-toto/attestation/compare/v1.1.1...v1.1.2 )
---
updated-dependencies:
- dependency-name: github.com/in-toto/attestation
dependency-version: 1.1.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-06-16 16:02:19 +00:00
William Martin
c7baa7a555
Quote workflow conditional
2025-06-16 17:54:24 +02:00
Eugene
8d0161fa5d
Merge branch 'trunk' into eugene/release-verify
2025-06-16 08:49:58 -07:00
William Martin
35e95a42c9
Merge pull request #11107 from cli/dependabot/github_actions/actions/attest-build-provenance-2.4.0
...
chore(deps): bump actions/attest-build-provenance from 2.3.0 to 2.4.0
2025-06-16 17:09:33 +02:00
William Martin
928a326cee
Add workflow to check help wanted labelling ( #11105 )
...
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-06-16 17:09:04 +02:00
dependabot[bot]
f8a3133003
chore(deps): bump actions/attest-build-provenance from 2.3.0 to 2.4.0
...
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance ) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases )
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md )
- [Commits](db473fddc0...e8998f9491
2025-06-12 14:33:02 +00:00
William Martin
73b7d61475
Merge pull request #11099 from cli/11097-duplicate-review-requests-when-using-gh-pr-edit-add-reviewer
...
Avoid requesting PR reviewer twice
2025-06-11 19:42:12 +02:00
Dylan Ancel
1eee56ec00
Add accurate context when run rerun fails ( #10774 )
...
* Add accurate context when run rerun fails
* Update tests to verify behaviour for API errors
Signed-off-by: Babak K. Shandiz <babakks@github.com>
* Use the new `httpmock.JSONErrorResponse` helper
Signed-off-by: Babak K. Shandiz <babakks@github.com>
---------
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-06-11 15:28:03 +01:00
William Martin
ee3db50e43
Avoid requesting PR reviewer twice
2025-06-11 15:54:16 +02:00
