Commit graph

1393 commits

Author SHA1 Message Date
Mislav Marohnić
05328fbe13
Merge pull request #4114 from cli/powershell-docs
Add PowerShell instructions to completions help
2021-08-16 19:28:22 +02:00
Mislav Marohnić
a7fc43bc5f Add hint about argument to extensions remove usage synopsis 2021-08-12 15:41:17 +02:00
Mislav Marohnić
ac6c859ca0 Print "Upgrade available" instead of "Update available"
This is because we have an `upgrade` command, not `update` command.
2021-08-12 15:40:46 +02:00
Mislav Marohnić
fbe1487dd0
Merge pull request #4112 from cli/extension-cmd-rename
Rename `gh extensions` → `gh extension`
2021-08-12 15:35:01 +02:00
Mislav Marohnić
0c99f7d8d5
Merge pull request #4051 from cli/extensions-overhaul
Rework local extensions for Windows
2021-08-12 15:33:56 +02:00
Mislav Marohnić
e567ce00cd
Merge pull request #4102 from cli/sync-no-checkout
Repo sync optimizations
2021-08-12 15:33:32 +02:00
Mislav Marohnić
e35d41ec1f Add PowerShell instructions to completions help 2021-08-12 12:56:46 +02:00
Mislav Marohnić
bf9c49eccd Rename gh extensionsgh extension
This is for compatibility with other core commands which are all singular.
2021-08-11 22:22:39 +02:00
Mislav Marohnić
3946606e5e Use symlinks on most platforms and keep using plain files on Windows 2021-08-11 22:11:24 +02:00
Mislav Marohnić
21521b06b9 Check git presence during auth login only if it's going to be needed 2021-08-11 19:22:16 +02:00
Shaharyar Ahmed
e28236a447 Check path for git executable before auth
There was a bug where if git was not installed then gh would do its
authentication and try to configure git but would then find out that the
git executable was not in PATH.

Now gh checks to see if the git executable is in PATH before
authenticating the user. If the git executable is in PATH the
authentication continues as normal, if it is not in PATH then it prints
out an error to the console:

$ git executable not found in $PATH

Resolves: #3818
2021-08-11 19:22:16 +02:00
Mislav Marohnić
4fa984a333
Merge pull request #4003 from despreston/3381-release-discussions
add --discussion-category flag to release cmd
2021-08-10 15:54:03 +02:00
Des Preston
bdc5b55f55 pr comments
Only add discussion category to request if there is one. This eliminates
the need to update old tests.

Renaming the variable to something shorter.
2021-08-10 09:47:49 -04:00
Mislav Marohnić
f4bded30f8 Mark test helper 2021-08-10 14:30:55 +02:00
Mislav Marohnić
6136a39ed6 Use remotes.FindByRepo() 2021-08-10 14:30:36 +02:00
Mislav Marohnić
0f1ab13b9e Only check if working copy is dirty when syncing current branch
In other cases, we don't have to abort the operation since it can
proceed without being affected by the working copy at all.
2021-08-10 14:29:23 +02:00
Mislav Marohnić
66ad6ad7d0 Avoid git checkout during gh repo sync
- If the local branch already exists, use `git update-ref`
- If it needs to be created, use `git branch <newbranch>`, but don't
  switch to the new branch

Bonus fixes
- Enables operation while on detached HEAD
- Enables operation even when the current remote doesn't track all
  branches in the remote repo (uses FETCH_HEAD instead of the
  `<remote>/<branch>` syntax)
2021-08-09 22:10:52 +02:00
Sam
c5371d5303
Merge pull request #3813 from cli/repo-sync
Add repo sync command
2021-08-05 19:39:40 -07:00
Mislav Marohnić
9a485ddfa2 💅 Cleanup local branch handling during pr checkout 2021-08-05 20:44:34 +02:00
Des Preston
294a029e70 add --branch flag to pr checkout
Allows renaming the checked out branch.
2021-08-05 20:44:20 +02:00
Sam Coe
174e26ecac
Fix tests 2021-08-04 18:26:30 -07:00
Sam Coe
2c4a662660
Rework git client interface 2021-08-04 18:13:58 -07:00
Sam Coe
00d67e3e5a
Remove unnecessary + 2021-08-04 17:10:50 -07:00
Sam Coe
86f16dbaf5
Use more idiomatic pattern 2021-08-04 17:00:20 -07:00
Sam Coe
c0756c2d1c
Clean up UX 2021-08-04 16:42:27 -07:00
Mislav Marohnić
95a515ecf0
Merge pull request #4087 from cli/graphql-error-fix
Fix unmarshalling GraphQL error type
2021-08-04 15:43:00 +02:00
Mislav Marohnić
90b7886142 Fix unmarshalling GraphQL error type
The "path" field of a GraphQL error object contains a mix of strings and
numbers and cannot be deserialized into `[]string`. Fortunately, we
don't need to rely on the "path" field and instead have the final error
message be constructed by aggregating human-readable "message" fields.
2021-08-04 15:34:53 +02:00
Mislav Marohnić
1007c1a3ae
Merge pull request #4079 from cli/no-label-colors
Disable colorizing labels in `issue list` output
2021-08-04 15:23:36 +02:00
Marc Khouzam
549caf29b5 Enable completion descriptions for powershell
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
2021-08-04 07:45:30 -04:00
Mislav Marohnić
65d1124799 Close file after resolving faux symlinks on Windows
https://github.com/cli/cli/pull/4051/checks?check_run_id=3186063173
2021-08-03 16:46:04 +02:00
Mislav Marohnić
930ee60ac5 Disable colorizing labels in issue list output
- Labels with dark color are not visible on a dark background
- "Raw" `issue view` output should never output color, not even with
  CLICOLOR_FORCE=1
2021-08-03 16:02:16 +02:00
Mislav Marohnić
5d1d967c43 💅 Clean up pr merge admin logic 2021-08-03 15:49:55 +02:00
rsteube
baa18c164d pr merge: added --admin flag 2021-08-02 13:02:32 +02:00
Mislav Marohnić
bbd74f004f Go 1.14 compat 2021-07-28 23:00:34 +02:00
Mislav Marohnić
0d999ddaa1 Rework local extensions for Windows
Replace the implementation that relied on symlinks with the one that
create regular files that act like symlinks: they contain a reference to
the local directory where to find the extension.
2021-07-28 22:47:54 +02:00
Mislav Marohnić
4b499be96b
Merge pull request #3942 from dscho/complete--repo-flag
Allow auto-completing the `--repo` values
2021-07-28 17:27:56 +02:00
Mislav Marohnić
d6b70beeaa List repos from non-default hostnames in completions for -R 2021-07-28 17:18:56 +02:00
Johannes Schindelin
b43f78bc19 completions: auto-complete --repo values
Looking at the locally-registered remotes, we have a pretty good idea
what `--repo` values are available. Let's complete them.

Helped by Nate Smith and Mislav Marohnić.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
2021-07-28 15:36:30 +02:00
Sam
92ed42c54a
Merge pull request #4029 from cli/extensions-upgrade-force
Add --force flag for extensions upgrade
2021-07-27 08:07:14 -07:00
Mislav Marohnić
f3a7d0076e
Merge pull request #4028 from cli/bump-cobra
Upgrade Cobra for improved shell completion support
2021-07-27 16:34:20 +02:00
Mislav Marohnić
fdad37e248
Merge pull request #4019 from cli/enterprise-env
Fix error message when using GH_ENTERPRISE_TOKEN but host is ambiguous
2021-07-27 15:29:14 +02:00
Mislav Marohnić
82c6fb7d1a Add a note about the dummy GHE hostname 2021-07-26 18:59:53 +02:00
Sam Coe
340a1fdc93
Add --force flag for extensions upgrade 2021-07-21 11:06:22 -07:00
Mislav Marohnić
2801206663 Switch to Cobra's bash completion V2 2021-07-21 16:32:39 +02:00
Mislav Marohnić
6ed2e8f7f8 Add completion support to repo create --gitignore and --license 2021-07-21 16:12:38 +02:00
Mislav Marohnić
4d7625c8a0 Allow shell-completing multiple --json fields separated by commas 2021-07-21 16:12:38 +02:00
Mislav Marohnić
db8204dc56 Allow space to be added after completing issue/pr list --state values
The "nospace" directive instructs the shell completion logic to avoid
adding a space after completing the word. However, this feature was
broken in an older Cobra, and users still saw a space character added.
In most case we want the space because we anticipate that the user might
want to add extra arguments to the command.
2021-07-21 16:12:38 +02:00
Sam Coe
e70bdbf7a9
Add update checking to extensions list 2021-07-20 13:13:20 -07:00
Mislav Marohnić
a83c2924c5 Never prompt to delete branch if --auto was given 2021-07-20 19:49:19 +02:00
Mislav Marohnić
6e026412df Add "UNSTABLE" to immediately mergeable statuses
This status describes a state where the head branch is mergeable and
technically not blocked per base branch requirements, but it does have
non-passing checks.
2021-07-20 19:42:53 +02:00