Mislav Marohnić
70a9621928
💅 cleanup in gist create
2021-05-07 14:15:27 +02:00
Gowtham Munukutla
cc94dc762d
shift gist validation to server rather than client
2021-05-07 14:12:00 +02:00
Mislav Marohnić
44ae7ae3cf
Merge pull request #3279 from cli/browser-refactor
...
Pass web browser to each individual command
2021-03-30 16:54:59 +02:00
Mislav Marohnić
b70b0402eb
Merge pull request #3200 from cli/table-widths
...
Ensure that table printer always uses all available width in the terminal
2021-03-30 16:54:13 +02:00
Sam
9ec1e21d4c
Default to GHES host if only GHES is authenticated ( #3286 )
2021-03-30 16:51:00 +02:00
Mislav Marohnić
111e8dbcf2
Pass web browser to each individual command
...
This removes sensitivity to the BROWSER environment variable in tests
and makes it easier to verify the URL that the browser was invoked with
without having to stub sub-processes.
2021-03-19 21:22:37 +01:00
Nate Smith
2ab073d599
Refactor use of glamour to allow style overrides ( #3243 )
...
* Refactor use of glamour to allow style overrides
* leave the things the way they were and just expose the ability to set overrides
2021-03-19 16:29:32 +00:00
Mislav Marohnić
ed15bebb84
Ensure that table printer fills the full width of the terminal
...
Sometimes, due to rounding errors, after calculating the width of each
column in a table, the sum of all columns would be shorter that the
total available width in the terminal. This reimplements the elastic
column resizing algorithm to ensure that all available space has been
filled.
As a bonus fix, columns that contain URLs are never truncated.
2021-03-11 19:04:57 +01:00
Nate Smith
2fbc037658
Merge pull request #3042 from g14a/bug/gist-binary-files
...
Remove functionality to add, view and edit binary files in gists
2021-03-04 13:01:54 -06:00
Mislav Marohnić
e16c3124dd
Disallow binary files with gist edit -a
2021-03-02 14:58:16 +01:00
Mislav Marohnić
066ba54549
Sort gist files case-insensitively
2021-03-02 14:53:19 +01:00
Mislav Marohnić
77d9051d0e
Simplify looking up binary types in gist
2021-03-02 14:53:10 +01:00
Gowtham Munukutla
973fbb0925
Disallow operating on binary files in gist
2021-03-02 14:52:44 +01:00
Mislav Marohnić
dd34cae112
Merge remote-tracking branch 'origin' into cancel-error-status
2021-03-02 13:52:07 +01:00
Mislav Marohnić
2ebdde1ddd
Exit with status code "2" on user cancellation errors
...
This also stops printing "interrupt" after Ctrl-C is pressed.
2021-03-02 13:48:44 +01:00
vilmibm
39718cd5ca
just hide empty descriptions
2021-03-01 16:07:04 -06:00
vilmibm
00e8c07021
Merge remote-tracking branch 'origin/trunk' into interactive-gist-view
2021-03-01 16:05:26 -06:00
vilmibm
e100b15acb
some text tweaks
2021-03-01 16:03:48 -06:00
Mislav Marohnić
8f96e406ac
Improve error handling and avoid writing confirmation to stdout
...
Right now the `gist edit` command doesn't write anything to stdout, so
let's keep it that way until we want to intentionally provide some
feedback in the terminal.
2021-02-27 12:23:18 +01:00
Mislav Marohnić
406d7eee45
💅 cleanup gist edit -a feature
2021-02-27 12:07:35 +01:00
Gowtham Munukutla
7fd0634a24
rebase with trunk
2021-02-25 14:47:26 +05:30
boonhong
0833bdc6b4
Merge branch 'trunk' of github.com:cli/cli into interactive-gist-view
2021-02-24 23:32:23 +08:00
boonhong
5403a37601
Add interactive select in gist view
2021-02-24 18:38:05 +08:00
Gowtham Munukutla
61eb7eeeab
Add msg in gist delete
2021-02-24 15:53:07 +05:30
Gowtham Munukutla
56ead91702
Add helper function to validate exact args in cmdutil
2021-02-24 15:49:40 +05:30
Gowtham Munukutla
3e5d5a23c0
add fixturefile const in tests
2021-02-24 10:22:56 +05:30
Gowtham Munukutla
d4e14beb57
remove unwanted tests and unwanted functionality
2021-02-24 10:14:31 +05:30
Gowtham Munukutla
a6fa14866b
updating tests WIP
2021-02-24 09:44:11 +05:30
Gowtham Munukutla
cbf8a0d964
Accept only one argument when deleting a gist
2021-02-23 20:12:26 +05:30
Gowtham Munukutla
faffc4de95
Add go fmt to pass ci/cd
2021-02-19 12:05:20 +05:30
Gowtham Munukutla
4ed10140ab
Resolved PR review comments and test cases
2021-02-19 12:02:17 +05:30
Gowtham Munukutla
882bd1adb1
add go lint to pass checks
2021-02-18 22:39:56 +05:30
Gowtham Munukutla
a4a194011f
gofmt
2021-02-18 19:18:49 +05:30
Gowtham Munukutla
9a4fd0d706
Remove unwanted prompt for user. Unwanted test as well
2021-02-18 19:17:42 +05:30
Gowtham Munukutla
bff8b3007a
Add test cases and improve errors with color schemes
2021-02-18 18:45:43 +05:30
Gowtham Munukutla
2983887458
Add files by absolute path to gist
2021-02-17 20:39:43 +05:30
Gowtham Munukutla
037343c5c2
Add existing files in the current wd to gist
2021-02-17 19:20:43 +05:30
Gowtham Munukutla
05e45e3863
Feature of adding new files to an existing Github gist
2021-02-17 11:27:57 +05:30
Mislav Marohnić
622317ee89
Tweak gist docs
2021-02-03 22:39:58 +01:00
Ruslan Gilyazetdinov
907524f459
add --files to list filenames in gist ( #2885 )
2021-02-03 22:39:58 +01:00
Mislav Marohnić
3f7b1387e5
Improve gist view rendering
...
- Separate out logic to render a single file
- Render directly to stdout instead of to string slice
- Normalize whitespace between files; ensure no excessive trailing whitespace
- Add terminal pager support
- Sentence-case for flags
2021-02-02 14:21:48 +01:00
Ruslan Gilyazetdinov
bf4370bc3a
linter fixes
2021-02-02 10:56:29 +03:00
Ruslan Gilyazetdinov
232dc7b7fa
change condition for single file, remove empty lines in single file mode
2021-02-02 10:54:07 +03:00
Ruslan Gilyazetdinov
8e86129e2e
remove gist description from single file raw view ( #2886 )
2021-02-01 18:49:26 +03:00
Mislav Marohnić
f46bab256c
Rename to SuccessIconWithColor
2021-01-25 14:56:39 +01:00
Mislav Marohnić
96fa6e7830
Merge remote-tracking branch 'origin' into success-icon-consistency
2021-01-22 23:56:54 +01:00
Mislav Marohnić
23d68705bc
Match color of the success icon with the end state of the record
2021-01-22 23:55:33 +01:00
Mislav Marohnić
06cf2c9f81
Merge remote-tracking branch 'origin' into cmd-stub-new
2021-01-22 16:31:29 +01:00
Nate Smith
3a9e47bf1b
Merge pull request #2664 from cristiand391/gist-friendly-error
...
Print friendly error when 'gh gist <command>' is missing required argument
2021-01-21 14:41:03 -08:00
Mislav Marohnić
c63acf6728
Migrate to new cmd stubber in misc. tests
2021-01-18 22:42:01 +01:00
