Commit graph

3717 commits

Author SHA1 Message Date
Mislav Marohnić
8e1f736775
Merge pull request #2519 from cli/issue-create-browser-fix
Fix respecting chosen action in interactive `issue create`
2020-12-02 13:02:16 +01:00
Sam
0ade39351a
Merge pull request #2521 from cli/fix-env-auth-token
Properly check env auth tokens in CheckAuth
2020-12-01 21:08:59 -05:00
Mislav Marohnić
be759785f0 Fix "Continue in browser" for pr create coming from forks
Ensures that the `owner:` prefix is present when referencing the head branch
2020-12-01 21:23:39 +01:00
Mislav Marohnić
a84b9f09d4
Merge pull request #2456 from ismaell/build-flags
Simplify build flags setup
2020-12-01 20:52:32 +01:00
Mislav Marohnić
d74086da92
Merge pull request #2505 from nilsleiffischer/patch-1
Fix typo in an error message
2020-12-01 20:42:31 +01:00
Mislav Marohnić
faa1e44f52
Merge pull request #2455 from ismaell/install-target
Add make (un)install targets for POSIX systems 

Fixes #293
2020-12-01 20:33:37 +01:00
Mislav Marohnić
6f689ff051 Document make install 2020-12-01 20:31:20 +01:00
Sam Coe
e21c5100fa
Properly check env auth tokens in CheckAuth 2020-12-01 11:44:14 -05:00
Mislav Marohnić
df2ca9c9f9 Fix browser URL test on Windows 2020-12-01 15:55:40 +01:00
Mislav Marohnić
c92f416cc0 Simplify make install/uninstall 2020-12-01 15:46:18 +01:00
Mislav Marohnić
dc1fad9cb0 Fix respecting chosen action in interactive issue create
The `action` variable started being shadowed in the `if` block in
6671106448
2020-12-01 15:28:39 +01:00
Nils Leif Fischer
413ccb71cc
Delete an error message that is not useful (and had a typo) 2020-11-30 13:20:43 +01:00
Ismael Luceno
8d2881d5ea Install manual pages 2020-11-29 21:01:38 +01:00
Ismael Luceno
da3287c26c Add make (un)install targets for POSIX systems
The implementation imitates the behavior of build-systems generated by
GNU Automake.

Implemented targets:
- install
- install-strip
- uninstall

Implemented variables:
- DESTDIR
- prefix
- bindir
- INSTALL_STRIP_FLAG

Internal implementation details:

- install-bins variable collects user binaries to be installed
- install-dirs variable collects directories to be created
2020-11-29 21:01:38 +01:00
Max Horstmann
34d549e7b6
Document that reviewers can be teams (#2465)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-11-26 17:31:15 +01:00
Mislav Marohnić
7c6574d8e9
Merge pull request #2480 from cli/bump-survey
Bump AlecAivazis/survey
2020-11-26 12:06:25 +01:00
Mislav Marohnić
08408805a2
Merge pull request #2479 from cli/prs-by-branch-order
Prioritize latest (open) PR when looking up PRs for a branch
2020-11-26 11:55:11 +01:00
Zach Boyle
1135e5e3ed
set delete-branch merge flag default to false (#2466)
Co-authored-by: Divya Ramanathan <ramanad@umich.edu>
2020-11-26 11:54:28 +01:00
Amanda Pinsker
504cfbc654
Merge pull request #2482 from cli/ds-docs
Add design system docs to contributing
2020-11-25 16:06:29 -08:00
Amanda Pinsker
436846a715
Add design system docs to contributing 2020-11-25 11:58:26 -08:00
Cristian Dominguez
ab05736b98 don't reset previously added metadata 2020-11-25 13:30:54 -03:00
Mislav Marohnić
e9e8f207cc Bump AlecAivazis/survey 2020-11-25 14:52:13 +01:00
Mislav Marohnić
21e2544d73 Sort latest PRs first when looking up PRs for a branch
Fixes #2452
2020-11-25 12:06:35 +01:00
Vixb
37891a54d9
Update scoop install option (#2478)
Co-authored-by: Mislav Marohnić <mislav@github.com>
Co-authored-by: Jan Pokorný <JenomPokorny@gmail.com>
2020-11-25 11:40:30 +01:00
Cristian Dominguez
ea50666c30 Prompt: avoid resetting PR/issue metadata if no option is selected 2020-11-24 13:49:04 -03:00
Shubhankar Kanchan Gupta
9f84f0ffa1
Warn termux users with older Android versions (#2467)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-11-24 12:56:26 +01:00
Nate Smith
959b1aae67
Merge pull request #2408 from cli/preserve-input
Preserve/restore pr and issue input
2020-11-23 13:39:43 -06:00
vilmibm
cf37ce7463 no shorthand for --recover 2020-11-23 11:24:28 -08:00
vilmibm
d6e84a75fb switch to recover instead of resubmit 2020-11-23 11:21:34 -08:00
vilmibm
1d408eb30d linter appeasement 2020-11-23 11:21:28 -08:00
vilmibm
f68909b7a8 use TempFile though the testing is gross 2020-11-23 11:21:28 -08:00
vilmibm
fffd315a7e fix dumb test 2020-11-23 11:21:28 -08:00
vilmibm
d300526318 preserve and restore issue/pr input on failure 2020-11-23 11:21:28 -08:00
vilmibm
e92cd43259 add IOStreams.ReadUserFile 2020-11-23 11:21:28 -08:00
Mislav Marohnić
d56d92c908 If git credential helper is non-defined, set gh as credential helper 2020-11-23 20:20:05 +01:00
Mislav Marohnić
d6c9004d64
Merge pull request #2460 from cli/spell-check-fixes
Spell check fixes
2020-11-23 13:22:01 +01:00
Josh Soref
a66a65d422 spelling: unmatched 2020-11-21 21:43:51 -05:00
Josh Soref
ded92972cd spelling: template 2020-11-21 21:43:51 -05:00
Josh Soref
ec82d3c47e spelling: settings 2020-11-21 21:43:51 -05:00
Josh Soref
e5f59a15fe spelling: response 2020-11-21 21:43:51 -05:00
Josh Soref
c8b9486fd3 spelling: nonexistent 2020-11-21 21:43:51 -05:00
Josh Soref
76bd377253 spelling: error 2020-11-21 21:43:51 -05:00
Josh Soref
861d350440 spelling: dunno 2020-11-21 21:43:51 -05:00
Josh Soref
ddd438d5e1 spelling: dismissed 2020-11-21 21:43:51 -05:00
Josh Soref
8ba68fc68a spelling: deprecated 2020-11-21 21:43:51 -05:00
Josh Soref
e58b2dbe92 spelling: chestnuts 2020-11-21 21:43:51 -05:00
Josh Soref
0e681ca6c4 spelling: beginning 2020-11-21 21:43:46 -05:00
Ismael Luceno
a4daf96a69 Make bin/gh rule verbose 2020-11-21 23:17:54 +01:00
Ismael Luceno
e16bf094bd Simplify CGO flags setup 2020-11-21 23:16:42 +01:00
Mislav Marohnić
e36c9029d3 Fix broken tests 2020-11-20 20:33:08 +01:00