STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9362 commits 87 branches 0 tags 160 MiB
Commit graph

9362 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kynan Ware
8cd39923fe test(prompter): fix race condition 
This test was trying to block on `expect`’ing a string at the same
time the prompt was completed.

This doesn't need to happen for this test. It should just check for
the output from the Input prompt invocation.
 2025-04-10 17:09:22 -06:00
Andy Feller
b8cd094ca8 Ensure markdown confirm prompt shows editor name 
Apparently, `gh` might not actually have an editor at the time we're prompting
the user if they want to use it for markdown editing.  In the survey package,
there is a function that will handle fallback to the default editor based on
environment variables and parse it in the case the editor contains flags and
arguments for cases like Visual Studio Code.

Additionally, there are no tests for the EditorName function and the fact it
is loaded via `init` makes this difficult to test.

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2025-04-10 16:28:58 -06:00
Kynan Ware
20ff409bfc fix(prompter): remove needless default value assignment 2025-04-10 16:28:57 -06:00
Kynan Ware
9eee77a2bf test(prompter): doc how accessible prompter tests work 2025-04-10 10:55:24 -06:00
Kynan Ware
8b70870f4f test(prompter): describe why echo is editorcmd 2025-04-10 10:39:59 -06:00
Kynan Ware
47d603221d test(prompter): use *testing.T instead 2025-04-10 10:37:36 -06:00
Babak K. Shandiz
791e1af828
Add missing gc.AssertExpectations calls 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-10 14:09:49 +01:00
Babak K. Shandiz
f0d4acd501
Add tests for IsPinned method 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
 2025-04-10 14:00:24 +01:00
William Martin
057ad52fdb
Merge pull request #10759 from cli/cosign-no-regex 
Simplify cosign verification example by not using a regex.
 2025-04-10 12:29:44 +02:00
Fredrik Skogman
512fac2dba
Simplify cosign verification example by not using a regex. 2025-04-10 08:39:12 +02:00
Kynan Ware
4615069773 chore: go mod tidy 2025-04-09 15:51:02 -06:00
Kynan Ware
fab0de5583 fix(prompter): pass io to huh and refactor tests 2025-04-09 15:51:02 -06:00
Kynan Ware
2f5e896535 fix(prompter): update huh and fix tests 2025-04-09 15:18:53 -06:00
Kynan Ware
19633d3855
Merge pull request #10516 from iamazeem/8430-show-hostname-in-repo-creation-prompts 
[gh repo create] Show host name in repo creation prompts
 2025-04-09 14:30:56 -06:00
William Martin
8f33d81083
Merge pull request #10742 from cli/babakks/improve-regexp 
Escape dots in regexp pattern in `README.md`
 2025-04-09 20:40:03 +02:00
Kynan Ware
8fc8486af5 refactor(prompter): rename speechSynthesizerFriendlyPrompter to accessiblePrompter 2025-04-09 08:24:54 -06:00
Kynan Ware
a34c9ea799 doc(prompter env): accessible prompter includes braille reader 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-04-09 08:20:07 -06:00
Kynan Ware
3b2e7f7f71 chore: go mod tidy 2025-04-09 08:13:21 -06:00
Kynan Ware
861563269a Merge branch 'trunk' into kw/first-pass-accessible-prompter 2025-04-09 08:07:56 -06:00
Meredith Lancaster
17113f431d Merge branch 'trunk' into refactor-sigstore-verifier-logic 2025-04-09 07:23:48 -06:00
Meredith Lancaster
139e82c68c Revert "temporarily skip non-failing tests" 
This reverts commit de8778797f.
 2025-04-09 07:23:17 -06:00
Meredith Lancaster
7b20ee5549
Merge pull request #10749 from malancas/update-to-sigstore-go-v0.7.1 
Update github.com/sigstore/sigstore-go to 0.7.1 and fix breaking function change
 2025-04-09 11:58:20 +02:00
Meredith Lancaster
de8778797f temporarily skip non-failing tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 19:09:52 -06:00
Meredith Lancaster
29080dc70a reorganize func 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 16:40:52 -06:00
Meredith Lancaster
d63e2830e0 clean up unneeded sigstore verifier fields 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 16:35:17 -06:00
Meredith Lancaster
a535cfdbfc flip verifier choice logic 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 16:28:56 -06:00
Meredith Lancaster
2559a83945 Merge branch 'refactor-sigstore-verifier-logic' of github.com:malancas/cli into refactor-sigstore-verifier-logic 2025-04-08 16:23:46 -06:00
Meredith Lancaster
366485155e initiate custom verifiers when the sgistore verifier is created 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 16:23:37 -06:00
Meredith Lancaster
a3bfb158e4
Merge branch 'trunk' into refactor-sigstore-verifier-logic 2025-04-08 16:00:40 -06:00
Meredith Lancaster
323ea74733 add public good and github verifiers as fields for repeated use instead of creating a new one for every attestation 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 15:40:55 -06:00
Meredith Lancaster
35ec7f251c replace sigstore-go test bundle func 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 15:20:51 -06:00
Meredith Lancaster
68b1d8bf29 update sigstore-go 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 15:20:42 -06:00
Andy Feller
47225bcf56
Merge pull request #10737 from cli/andyfeller/muted-text-part2-github-cli-833 
Ensure muted text is thematic and customizable
 2025-04-08 16:59:36 -04:00
Andy Feller
6dd8f809b1
Merge pull request #10720 from cli/andyfeler/colorize-label-optin 
Introduce configuration setting for displaying issue and pull request labels in rich truecolor
 2025-04-08 16:44:25 -04:00
Meredith Lancaster
261cea2075 update error message 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2025-04-08 14:41:18 -06:00
Andy Feller
93e51c583b
Update pkg/cmd/run/shared/presentation.go 2025-04-08 16:40:39 -04:00
Andy Feller
644dbe6275
Apply suggestions from code review 
Co-authored-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
 2025-04-08 15:56:23 -04:00
Andy Feller
5c12f5633e Test for explicit config disable of label colors 2025-04-08 15:27:36 -04:00
Andy Feller
c5206109ca Use truthy value for GH_COLOR_LABELS 2025-04-08 15:24:18 -04:00
Kynan Ware
d230b08c43 test(prompter): re-add skipped test for accessible confirm default 2025-04-08 13:09:15 -06:00
Kynan Ware
fa03157beb doc(help): label GH_ACCESSIBLE_PROMPTER as preview 2025-04-08 13:04:04 -06:00
Kynan Ware
19387b8418 fix(prompter): rename GH_ACCESSIBLE_PROMPTER 2025-04-08 12:52:39 -06:00
Kynan Ware
9cf341302e refactor(prompter): explicit return values 2025-04-08 12:03:55 -06:00
Kynan Ware
8821f77fbb doc(prompter): remove senseless comment 2025-04-08 12:00:02 -06:00
Kynan Ware
c4be95afd9 refactor(prompter): remove unused variable 2025-04-08 11:58:50 -06:00
Kynan Ware
ef58e627f9 test(prompter): timeout for tests is 1s 2025-04-08 11:44:14 -06:00
Kynan Ware
d8d3874778 fix(prompter): use os.lookupenv for accessible prompter 2025-04-08 11:38:54 -06:00
Kynan Ware
fb80b5bd86 test(prompter): remove needless NO_COLOR set 2025-04-07 14:56:33 -06:00
Kynan Ware
c5ffb3cbfe
test: use example.com in tests 2025-04-07 14:54:41 -06:00
Kynan Ware
66407402c0
doc: comment typos and formatting 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-04-07 14:53:31 -06:00