Kynan Ware
07dfdf97ae
Update edit tests
...
Updated test mocks and logic to consistently use lowercase 'monalisa' for login names and display names for user assignees. Improved handling of dynamic assignee fetching in interactive flows by relying on searchFunc and metadata population, and clarified logic in FetchOptions to fetch assignees only when necessary. These changes ensure more accurate simulation of interactive assignment and better test coverage for actor assignee features.
2026-01-26 13:29:22 -07:00
Kynan Ware
d46f42a752
Refactor MultiSelectWithSearch to use result struct
...
Refactored the MultiSelectWithSearch function and related interfaces to use a MultiSelectSearchResult struct instead of multiple return values. This change improves clarity and extensibility of the search function signature, and updates all usages, mocks, and tests accordingly.
2026-01-26 13:29:22 -07:00
Kynan Ware
38578f7991
Add comment describing logger
...
Added a comment explaining how to enable logging in expect-based tests by using expect.WithLogger. This helps developers debug by printing characters read to stdout.
2026-01-26 13:29:22 -07:00
Kynan Ware
7e7f8c6f6e
Pass editable to assigneeSearchFunc and update metadata
...
The assigneeSearchFunc now receives the editable struct to update its Metadata.AssignableActors field with suggested assignable actors. This change ensures that the editable struct has the necessary actor metadata for later PR updates.
2026-01-26 13:29:22 -07:00
Kynan Ware
d04317c273
Add dynamic assignee search to PR edit flow
...
Introduces SuggestedAssignableActors API query and wires up a dynamic assignee search function in the PR edit command. Updates Editable and EditPrompter interfaces to support search-based multi-select for assignees, improving the user experience when assigning users to pull requests.
2026-01-26 13:29:22 -07:00
Kynan Ware
0beb74bf72
MultiSelectWithSearch initial implementation
...
Initial implementation of MultiSelectWithSearch:
- Implement by survey and accessible prompters. They use the same internal func under the hood.
- Implement in `gh preview prompter` for initial testing and demonstration
- Implement interface changes across the codebase and mocks to satisfy compiler.
- Implement tests for new MultiSelectWithSearch prompter
2026-01-26 13:29:22 -07:00
Kynan Ware
be1e21095c
prshared: named prompt interface parameters
...
Updated the Prompt interface in survey.go to include parameter names for all methods, improving code readability and clarity.
2026-01-26 13:29:22 -07:00
Kynan Ware
009cf6e167
Merge pull request #12554 from cuiweixie/typo
...
typo: dont to don't
2026-01-26 10:54:05 -07:00
cuiweixie
b9c85fff68
typo: dont to don't
2026-01-26 22:25:00 +08:00
Kynan Ware
cf53b76d71
Merge pull request #12354 from cli/dependabot/github_actions/goreleaser/goreleaser-action-6.4.0
...
chore(deps): bump goreleaser/goreleaser-action from 6.0.0 to 6.4.0
2026-01-23 11:31:37 -07:00
dependabot[bot]
09e66252fd
chore(deps): bump goreleaser/goreleaser-action from 6.0.0 to 6.4.0
...
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action ) from 6.0.0 to 6.4.0.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases )
- [Commits](286f3b13b1...e435ccd777 )
---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
dependency-version: 6.4.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2026-01-23 18:22:34 +00:00
Kynan Ware
c8335e3f55
Merge pull request #12315 from cli/dependabot/github_actions/actions/upload-artifact-6
...
chore(deps): bump actions/upload-artifact from 5 to 6
2026-01-23 11:18:50 -07:00
Kynan Ware
970a1ebbc1
Merge pull request #12314 from cli/dependabot/github_actions/actions/download-artifact-7
...
chore(deps): bump actions/download-artifact from 6 to 7
2026-01-23 11:18:19 -07:00
Babak K. Shandiz
e643df99cf
Merge pull request #12515 from cli/dependabot/go_modules/github.com/theupdateframework/go-tuf/v2-2.3.1
...
chore(deps): bump github.com/theupdateframework/go-tuf/v2 from 2.3.0 to 2.3.1
2026-01-22 21:10:41 +00:00
Babak K. Shandiz
1318fe94d7
chore: update licenses
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-01-22 21:02:13 +00:00
dependabot[bot]
d4a4bc4dda
chore(deps): bump github.com/theupdateframework/go-tuf/v2
...
Bumps [github.com/theupdateframework/go-tuf/v2](https://github.com/theupdateframework/go-tuf ) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/theupdateframework/go-tuf/releases )
- [Commits](https://github.com/theupdateframework/go-tuf/compare/v2.3.0...v2.3.1 )
---
updated-dependencies:
- dependency-name: github.com/theupdateframework/go-tuf/v2
dependency-version: 2.3.1
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2026-01-22 20:59:01 +00:00
Babak K. Shandiz
8fb8006c86
Merge pull request #12525 from cli/dependabot/go_modules/github.com/sigstore/sigstore-1.10.4
...
chore(deps): bump github.com/sigstore/sigstore from 1.10.0 to 1.10.4
2026-01-22 20:57:36 +00:00
Babak K. Shandiz
56b2a15128
chore: update licenses
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-01-22 20:49:25 +00:00
dependabot[bot]
6811f941f3
chore(deps): bump github.com/sigstore/sigstore from 1.10.0 to 1.10.4
...
Bumps [github.com/sigstore/sigstore](https://github.com/sigstore/sigstore ) from 1.10.0 to 1.10.4.
- [Release notes](https://github.com/sigstore/sigstore/releases )
- [Commits](https://github.com/sigstore/sigstore/compare/v1.10.0...v1.10.4 )
---
updated-dependencies:
- dependency-name: github.com/sigstore/sigstore
dependency-version: 1.10.4
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2026-01-22 20:30:02 +00:00
Kynan Ware
a9f297b7e9
Merge pull request #12521 from Sethispr/patch-2
...
Lint source.md
2026-01-22 09:38:50 -07:00
seth
c1c5ac82d8
docs: lint source.md
...
Fixes:
- MD022 / blanks-around-headings
Headings should be surrounded by blank lines
- MD031 / blanks-around-fences
Fenced code blocks should be surrounded by blank lines
2026-01-22 05:44:11 -08:00
Babak K. Shandiz
3220ab5ab2
Merge pull request #12516 from mikelolasagasti/pr-shared-error-atoi
...
Fix fmt.Errorf format argument in ParseFullReference
2026-01-21 23:38:49 +00:00
Babak K. Shandiz
0d8a697c7c
fix(pr/shared): improve ParseFullReference error message
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-01-21 23:30:43 +00:00
Mikel Olasagasti Uranga
bd0177b039
Fix fmt.Errorf format argument in ParseFullReference
...
The error path passed an int to fmt.Errorf with %q, which expects a
string. Use the original reference string to avoid a format mismatch.
Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
2026-01-21 23:14:59 +01:00
Kynan Ware
49f72234ac
Merge pull request #12376 from majiayu000/fix-11903-pr-create-same-ref
...
fix: error when head and base refs are identical in pr create
2026-01-21 10:21:14 -07:00
Kynan Ware
c34c47c013
Merge pull request #12505 from cli/kw/contributing-guidelines-clarity
...
Update contributing guidelines for clarity
2026-01-21 09:50:22 -07:00
majiayu000
0f4b9b0d91
refactor: address review comments
...
Signed-off-by: majiayu000 <1835304752@qq.com>
2026-01-21 18:28:21 +08:00
Kynan Ware
fe729082ad
Update contributing guidelines for clarity
2026-01-20 15:21:23 -07:00
Kynan Ware
3e8855f755
Merge pull request #12101 from davidspek/feat/delete-all-cache-ref
...
feat(cache delete): allow for delete all caches for a ref
2026-01-20 12:16:47 -07:00
Kynan Ware
c4fd102016
Merge branch 'trunk' into fix-11903-pr-create-same-ref
2026-01-20 10:33:17 -07:00
Kynan Ware
3d89222e2d
Merge pull request #12500 from cli/babakks/polish-copilot-cmd-tests
...
Fix Windows asset URL in `copilot` command tests
2026-01-20 09:39:35 -07:00
Babak K. Shandiz
da5e5ac6d4
test(copilot): fix windows asset URL
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-01-20 10:33:19 +00:00
David van der Spek
9cdc0c4fe5
fix(cache delete): add unit tests and expand help doc
...
Signed-off-by: David van der Spek <david.vanderspek@flyrlabs.com>
2026-01-20 08:30:34 +01:00
David van der Spek
6a798e76e1
feat(cache delete): allow for delete all caches for a ref
...
Signed-off-by: David van der Spek <david.vanderspek@flyrlabs.com>
2026-01-20 08:30:34 +01:00
Kynan Ware
2728635b43
Merge pull request #12444 from devm33/ghcopilot
...
feat: add native copilot command to shim copilot cli
2026-01-19 11:27:52 -07:00
Kynan Ware
d187bef56f
Fix OS name in test archive filename to 'win32'
...
Replaces runtime.GOOS with 'win32' in the test archive filename within TestDownloadCopilot. This ensures the test uses the expected archive name for Windows.
2026-01-19 11:18:35 -07:00
Babak K. Shandiz
bc5a44a4ae
fix(copilot): replace windows with win32 to match asset names
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-01-19 17:57:05 +00:00
Babak K. Shandiz
10b4a1f427
fix(root): avoid command name collision when registering extensions
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Kynan Ware <bagtoad@github.com>
Co-authored-by: Devraj Mehta <devm33@github.com>
2026-01-19 10:38:39 +00:00
Babak K. Shandiz
08a4413614
chore(root): register copilot command
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Kynan Ware <bagtoad@github.com>
Co-authored-by: Devraj Mehta <devm33@github.com>
2026-01-19 10:38:35 +00:00
Babak K. Shandiz
39880650d5
feat: add copilot command
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Kynan Ware <bagtoad@github.com>
Co-authored-by: Devraj Mehta <devm33@github.com>
2026-01-19 10:38:29 +00:00
Babak K. Shandiz
0f32f2ac46
refactor(run download): extract zip extraction func into a separate package
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Co-authored-by: Kynan Ware <bagtoad@github.com>
Co-authored-by: Devraj Mehta <devm33@github.com>
2026-01-19 10:38:21 +00:00
Babak K. Shandiz
559e729f9a
Merge pull request #12377 from majiayu000/fix-9149-set-default-remote-name
...
feat: allow git remote names in gh repo set-default
2026-01-14 11:00:32 +00:00
lif
1d506f5331
fix: simplify set-default remote parsing
2026-01-14 18:35:04 +08:00
lif
8de78e6410
Merge branch 'trunk' into fix-9149-set-default-remote-name
2026-01-10 11:08:42 +08:00
majiayu000
5f305e81c2
Handle repo argument before remote name
2026-01-10 00:54:51 +08:00
Babak K. Shandiz
722acf080d
Merge pull request #12452 from cli/dependabot/go_modules/github.com/yuin/goldmark-1.7.16
...
chore(deps): bump github.com/yuin/goldmark from 1.7.13 to 1.7.16
2026-01-09 14:55:48 +00:00
Babak K. Shandiz
ba0c2ad7dd
chore: update licenses
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2026-01-09 14:47:55 +00:00
dependabot[bot]
6b2f627640
chore(deps): bump github.com/yuin/goldmark from 1.7.13 to 1.7.16
...
Bumps [github.com/yuin/goldmark](https://github.com/yuin/goldmark ) from 1.7.13 to 1.7.16.
- [Release notes](https://github.com/yuin/goldmark/releases )
- [Commits](https://github.com/yuin/goldmark/compare/v1.7.13...v1.7.16 )
---
updated-dependencies:
- dependency-name: github.com/yuin/goldmark
dependency-version: 1.7.16
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2026-01-08 14:04:52 +00:00
Babak K. Shandiz
c858c524b1
Merge pull request #12440 from cli/babakks/enable-noop-linters
...
ci: enable noop linters
2026-01-07 22:11:36 +00:00
Kynan Ware
d808dcdc0f
Merge pull request #12393 from fchimpan/update-extention-create-template
...
Update actions/checkout to v6 in extension workflow templates
2026-01-07 11:46:03 -07:00